From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 408117CC8;
 Thu,  1 Jun 2017 12:33:51 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 01 Jun 2017 03:33:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,279,1493708400"; d="scan'208";a="93583461"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81])
 ([10.237.220.81])
 by orsmga004.jf.intel.com with ESMTP; 01 Jun 2017 03:33:49 -0700
To: =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>,
 Yongseok Koh <yskoh@mellanox.com>
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, stable@dpdk.org
References: <20170531174845.35951-1-yskoh@mellanox.com>
 <20170601080803.GN31330@autoinstall.dev.6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <3d87bfe6-134c-9e1c-0758-95b0dc886a63@intel.com>
Date: Thu, 1 Jun 2017 11:33:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170601080803.GN31330@autoinstall.dev.6wind.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant free of Tx buffer
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jun 2017 10:33:52 -0000

On 6/1/2017 9:08 AM, Nélio Laranjeiro wrote:
> On Wed, May 31, 2017 at 10:48:45AM -0700, Yongseok Koh wrote:
>> SW completion ring of Tx (txq->elts) stores individual mbufs even if a
>> multi-segmented packet is sent. rte_pktmbuf_free_seg() must be used when
>> cleaning up the completion ring. Otherwise, chained mbufs are redundantly
>> freed and finally it would cause a crash.
>>
>> CC: stable@dpdk.org
>> Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path")
>>
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>

> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied to dpdk-next-net/master, thanks.