From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 191E4A09DE; Fri, 13 Nov 2020 09:39:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 380D45AB8; Fri, 13 Nov 2020 09:39:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 8D27256A3 for ; Fri, 13 Nov 2020 09:39:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605256784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4sVDhnIvuX17MKvSyrr8pvR0gGmIWOm2bS4PkClmvWM=; b=gEGfAutvVjLfsZkVvu8mjZxlTrMlBbxNhs660FUK3KefBRvkNK0hEgwXTtnWbZU+tDkstC Aw5EtHYJSei+/asUBLUekWyyiGg5hrJvuZd4pvmDZKmfQD5M4x8BLD8vmCIhuVT/5D5+3l rhoHjF1uwXpWIJV9csioMUXqG2wiyG8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-582-eZButHjrM6K8tLP4qBdSGg-1; Fri, 13 Nov 2020 03:39:40 -0500 X-MC-Unique: eZButHjrM6K8tLP4qBdSGg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B02DB393B9; Fri, 13 Nov 2020 08:39:38 +0000 (UTC) Received: from [10.36.110.32] (unknown [10.36.110.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE07310013DB; Fri, 13 Nov 2020 08:39:36 +0000 (UTC) To: dev@dpdk.org, xuan.ding@intel.com, stephen@networkplumber.org, thomas@monjalon.net, stable@dpdk.org, chenbo.xia@intel.com, xuemingl@nvidia.com References: <20201112171029.354593-1-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <3db65e89-10bd-2847-b769-279fe56a8edb@redhat.com> Date: Fri, 13 Nov 2020 09:39:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201112171029.354593-1-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 0/3] vhost: fix fd an memory leaks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/12/20 6:10 PM, Maxime Coquelin wrote: > This series fixes several leaks in Vhost-user requests > handling. > > Thanks to Xuan Ding from Intel for reporting these > issues. > > Changes in v4: > - Fix wrong return value in set_mem_table (Xueming) > > Changes in v3: > - Remove the right closing of fds. (Chenbo) > Changes in v2: > - Fix typos in commit messages. (Chenbo) > - Remove useless closing of fds in set_log_base. (Chenbo) > > Maxime Coquelin (3): > vhost: fix error path when setting memory tables > vhost: fix fd leak in dirty logging setup > vhost: fix fd leak in kick setup > > lib/librte_vhost/vhost_user.c | 74 +++++++++++++++++++++++------------ > 1 file changed, 49 insertions(+), 25 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime