From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96E87A00C3; Wed, 7 Dec 2022 15:45:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B72F40F17; Wed, 7 Dec 2022 15:45:49 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2086.outbound.protection.outlook.com [40.107.244.86]) by mails.dpdk.org (Postfix) with ESMTP id D8CCD40156 for ; Wed, 7 Dec 2022 15:45:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nsgHwuLC10aJBqkPU0zaszUEc7P4qH1ZcFuhF0NAAMutzXgGPXm0UFvqmRwY5vTAWHHUfz0cAXw2dnBcV7oZI2JL1fQJ37hmE7+UymAcOhKD+78+W4AY1Hpu5RXQ7JS8MX24B+wnvt2aBYGQxsU61Se0j013W/MC/lo+s71f2Oxym5D+se8kxAKPxfnB4Pnzv/w+cAeRIR0mDGICKx8I3yEEP747oi7Ih8AhjhpXG4IClsQp+T+1ECZvQe8KfSBamnHXt+Tdysri6u4NU9FhM8w5CuSg0nwQOUmq+A27rGgeGB0csYw29M/odS9UgDJGByTe08UWqleh4gxCOHZ3tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tqSpEvz3UWLVGlDNOdPE9AgOBftuJhssVptkyulanjk=; b=YvqA3DLh6wgb92+hMnKpuuCIjqoKiYYerhOHdCKpvRuWthHYAVSe6sZs60UJKlCxwMi7NkhjdaLE8lwwINMOx7wVn5ocjlHpIjgi/hpHWr7yCJlbhHJCA2Guz5umwB56fE8ns/oU4frHMW5sRdasCI5N+IDhr2+qiFn4xJAYzL4BqmtmuZjzllH1f1IyGNhZUYHQMY8JrYZhm8O5C+dhNa+GgXPxbIwq8i2RQ9aygnwHpZWgeMwYy79h3PJEwdCN/vDA/MQjqMXHr7jPmOVS7jZJFy8y/RS0RkDJNfqeTe0ATVwRHGl915r/XP6mXa4X+31z2fLNRCHt/trykAKhJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tqSpEvz3UWLVGlDNOdPE9AgOBftuJhssVptkyulanjk=; b=ODnch44lfvq/DGrinR9BbIQ9aOBRSNe9jP0TShsfMLwRTusdcdry8YFqMtaICTpUmvKU60hPGaZaSs4xR8Y0Ez+WzpktVUibT9m7OM8pCJnU7d1jWD/0HnuVQxvLJGIby67fbsmkAPaclAxCe08hDGQGuZeQTSZ6ZhP0ku2Ggn0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4355.namprd12.prod.outlook.com (2603:10b6:5:2a3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 14:45:46 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 14:45:45 +0000 Message-ID: <3dd6afb1-6dec-f03d-02ae-7bc14c3936e3@amd.com> Date: Wed, 7 Dec 2022 14:45:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Peng Zhang References: <20221128023705.32671-1-chaoyong.he@corigine.com> From: Ferruh Yigit Subject: Re: [PATCH] net/nfp: using the correct PCI name to look for the firmware In-Reply-To: <20221128023705.32671-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0062.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::26) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4355:EE_ X-MS-Office365-Filtering-Correlation-Id: edd5af7b-7ad8-44f8-5eb4-08dad861b937 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NkL4B8XtDAGyeNJGjtNKWmV/RucFoSmlW/WEDcSrNGAFkM0NuMWE3ugdYVtKjxK1LlrM8z5KgrWeD7TTiyBhF1kE59CenuAbuOB5UNbcp+zQXLN7oImRLOplc32pzu4E7XQtFtNJ9v/80vnJC3a8OFEbDtu+cS08z1dvTIH9Q5/fomPnXKZOrjiwGWu8aWu726AuyoRqd94hSlV+mZAAKRfbUOl1FEPRD7bLkscgaNUqMbwztdU1Vu9uGgNDpvWwWjKHqN8OlJ5x7FP7g4n1OqcDwfw0JMDcWwUa0GBxoOI1LhbUSPkKIHxX/vJfk8eZREPEjisuibUGnUZCXDoqreEGJIJ9vdKUjeGfirqZxNorwS/JvQ9z72ERzHPs92ReXSqIlL/6sHRHgDTC9YCpzFHAfSbMi5Tqksco5MNtqhNSXPPVHYMlYQtBvJeG3/qKzk5GMTenKxUxYLZ/4zl2iEs7HyfDxFm3w4qyHtbNfhlw+SwsWLLEcSm+WdXaodPgFsfqfBsjGOEUJKMHmKh0CTr6AThecuAzXpO7+3E2yEwOrRqlulU6uMK2lg8jSI3WkYZcockFMMM06LQ+fTkCoqj0xjfG1oGJT3dukSHhDn7oFOzTuqaeN8/o14Y4E0CfGwuZmtqrKDDOeTxAxZzaip9e2c5kwF8a9dxq6uXctB/zoN/3b6TN042neCgAl/v/pNCNSpgzeVFc2VVDJ9u4xHMh84KCsCqVmEIMrA+SQc0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(136003)(366004)(39860400002)(376002)(451199015)(36756003)(86362001)(31696002)(478600001)(26005)(6486002)(53546011)(6506007)(6666004)(66476007)(38100700002)(5660300002)(44832011)(41300700001)(4326008)(8676002)(8936002)(2906002)(66556008)(66946007)(316002)(186003)(6512007)(2616005)(66574015)(31686004)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkZWbDVUcFJ2VHhvcFBsWUdNOFlNbVFFNjhVSnRqcVRQeTdkeTNCZExLRG1j?= =?utf-8?B?ZTQrc2tmMXpIemJyd09tVnRHNXlnQUF5UFk3TmlwbnpzUlAxbGRuVTI5UEhk?= =?utf-8?B?bzg3Mjg4c1FObXhKc1NtcWg5NXE5UkJFNVlXTmFOYVFzNStKMjhEZTUxY0hp?= =?utf-8?B?UVFkRkliSDVIeDFKRWtzWlJqR1JWM2VqYnhQL3N5ZllIaXVzT2R6bzJmUkZh?= =?utf-8?B?KzFGSWNZUXVrb255K0JVdFJSWkxudGIwY1htMzRuRisxVVpEYUhoK0pHbWZp?= =?utf-8?B?WW1MUTR5OUZLbXNYb1dEYjBTQmtkSzRtWUVLUlczYkhnMWNsZjNLT21EZVNF?= =?utf-8?B?K0RXSGtJczNFc05LL1o1elFmN2M1c05HTURCTldiYkxoTFNpemM1ODRsU0NK?= =?utf-8?B?aDRiUlY1QUxIWWF3aUpOaUJqNThrVUpxZzNmcGtEeGE4Wk1kVW84b3dDblEr?= =?utf-8?B?UllOdkdGQk94WitrTGZVV0hYa1RBSnhxTCtQSFNqRFJDb3BIeGRCVE11MVNl?= =?utf-8?B?a2JYMlU2aXI3U216VWtQTm9YR0YrYU1Vd2ZKUjZ3dUpDWHhpM0MvUEYzQXVv?= =?utf-8?B?K1BkNWtiZTRJVDNYWU9VTU1yOWIzbCttaG9TYUtTVU5zbmJEVEhBMWdlQ1Bk?= =?utf-8?B?U2Q1ejhkSTFqM3FMY25HNzU4Z3lBVHBwK1kzaUQxVmJjUDBzSExtQ1p4cXNH?= =?utf-8?B?Kzg1U2dkZEZiQWJaTXYrN3ZHUDZOQldZSEc2U3RIWXNCUHFYaEFiS2VRNXhQ?= =?utf-8?B?V082dlIrR2I2MWhnRWYyOEovY2VrK05KSTFaQVU5Y1RDOGNZV01rNWZpdjNz?= =?utf-8?B?cGg4Ly9rVmE1MG5oSVhjaTJuRmpLWGZKWnlwUXQzbGFlY0RXR1AyNnhHREJR?= =?utf-8?B?L29RcHhPMU9wRW9RSFgxR3FoR25uTzUzZmtqRjFGZ2NFdWJjaS9IbDR0MWRL?= =?utf-8?B?TzhIT1o5azR6cFJ3N2t2Tkp4Q0oxa0Q5YVFqbUNhdUpTV056RDBXZzJ1dHJB?= =?utf-8?B?WkZRSG9wUit5aW5tbWJpK3pnMXBlSWVrSUlLVWVQaHZtdlJNd094SzJ3N1kz?= =?utf-8?B?UmdRVTZTUEdudkJxN0E2RkNrYXM2eXk5bW8wTVh3Wno5RWgzVVVkZ21HRVVY?= =?utf-8?B?WGFQTWI0UGNaNTlTTHd5VVlkSVZ2RjZpaW04SnFoN1NybWR1a09FSTcvVm9E?= =?utf-8?B?NUs2UUg0S2lZTnlZZmJLd0lkNWFhS2hKejN6U1RIckl3L3hicUxqN293a3dq?= =?utf-8?B?Q3pSaDlCZVd2WWRvM1lWNjgzM0doWmpVckpaK3NmUDlHK21IZE1jRGUvazVS?= =?utf-8?B?Nnp2THdSSGRvYUhDSTIydDJDTGtmT3A2dnprMEk2S1V1UkV6L21XMHZYVjJU?= =?utf-8?B?VExhbzc3WnRPYzVZS1d2OXl4M2MwbEh2c2w2blBrdGdtb2VkRnlROUcxVEdy?= =?utf-8?B?V2FGN2FmZ3l1V0lvdTNwSHBEbTk3VG94cklsd2xibG5oY2VPM3NDYnRpV2tC?= =?utf-8?B?alEyL3NXcmJTWExPYTBpdndZNXU3L1VJUFR0ZU5xOE1QZFJ1QWlLZEdGZDgw?= =?utf-8?B?b09jOWoxZmxtRk4xVjh6MFdwOWE5c2RSUUloejVWajk2OTFQTE5idVcxQUZL?= =?utf-8?B?bTA1M0JpcTRSL0FZRXNURCtmeU9xSVZTdXJQcHdEd2hHVUFPRzdtb1c4Y3cx?= =?utf-8?B?SU4wVDZtZ3NwUEU2QzNGcXhkSXp0d2hEcCtFUHAzeGt2Wmd4Ynp2UU1neDlD?= =?utf-8?B?SFVSODZuMTZyRFh6eEt3dzA1clJ2dUEzMDRXZTZkZzNjVWtHdzJBUG1YRmd5?= =?utf-8?B?d1ByZWY3bEh1TVpydjRKMGF2SVJVTTFiN3dZQWRJaTlneG9ydjhNa1UxNXZz?= =?utf-8?B?WGEvR01tR2cwdHZSU3h3eG5KY3NCSTUzb3BpZXBCSm4yWTQvQzV1aTBFTWZh?= =?utf-8?B?TjQwZXdhNFZKUENNdTVGZis0M2dPcCtWdWNlZmdCbWtmMzk5NFB3czJtQlZl?= =?utf-8?B?Qlc5OGpZbWFiZndOMU05UGJOLzhDQmQ1Kzd6YVgrRnc3SHhaeUF2ZHlCbjQz?= =?utf-8?B?cjZkZGpYVi9VUFBiWkwrV0tiL1BZVDk1VFNjZGhySlFmS083RGRTZTR6cnls?= =?utf-8?Q?ydz7JnGSLmwdJYV5YgqvQQylh?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: edd5af7b-7ad8-44f8-5eb4-08dad861b937 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 14:45:45.9218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: apiKjPmvhfzdeVv6qXs29sLwBkPAjMDb0TCZU4dGmm4u+k/qmcHQ8UYqtiUgAKom X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4355 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/28/2022 2:37 AM, Chaoyong He wrote: > From: Peng Zhang > > In the description of nfp document, DPDK PMD supports that the PF > looks for a firmware file by the PCI name. > > After this commit, it will looks for the PCI name format such as > pci-0000:04:00.0.nffw rather than pci-04:00.0.nffw, which will > keep consistent with what is written in the nfp.rst. > Hi Chaoyong, The commit log mentions change is to be consistent with document, but I assume code is wrong, oterwise it would be easier to update the document. So, can you please update commit log as a fix to [1]? [1] 896c265ef954 ("net/nfp: use new CPP interface") > Signed-off-by: Peng Zhang > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/nfp_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c > index 0956ea81df..f22ae24b53 100644 > --- a/drivers/net/nfp/nfp_ethdev.c > +++ b/drivers/net/nfp/nfp_ethdev.c > @@ -724,7 +724,7 @@ nfp_fw_upload(struct rte_pci_device *dev, struct nfp_nsp *nsp, char *card) > goto load_fw; > /* Then try the PCI name */ > snprintf(fw_name, sizeof(fw_name), "%s/pci-%s.nffw", DEFAULT_FW_PATH, > - dev->device.name); > + dev->name); > > PMD_DRV_LOG(DEBUG, "Trying with fw file: %s", fw_name); > if (rte_firmware_read(fw_name, &fw_buf, &fsize) == 0)