DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: David Marchand <david.marchand@redhat.com>,
	"amr.mokhtar@intel.com" <amr.mokhtar@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"tredaelli@redhat.com" <tredaelli@redhat.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] bbdev: add missing experimental tags
Date: Tue, 18 Dec 2018 10:43:29 +0000	[thread overview]
Message-ID: <3dd7a64a-3435-312c-1ebf-fe278b529218@nxp.com> (raw)
In-Reply-To: <CAJFAV8wM6NksBF_+j_569oS78SEp_Vd9wr2gNJD7wL5CuDofSg@mail.gmail.com>


Hi David,

On 12/18/2018 4:07 PM, David Marchand wrote:
> Hello Akhil,
>
> On Fri, Dec 14, 2018 at 1:52 PM Mokhtar, Amr <amr.mokhtar@intel.com> wrote:
>
>>> -----Original Message-----
>>> From: Neil Horman [mailto:nhorman@tuxdriver.com]
>>> Sent: Friday 14 December 2018 12:36
>>> To: David Marchand <david.marchand@redhat.com>
>>> Cc: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; stable@dpdk.org;
>>> tredaelli@redhat.com; Yigit, Ferruh <ferruh.yigit@intel.com>; Mokhtar,
>>> Amr <amr.mokhtar@intel.com>
>>> Subject: Re: [dpdk-dev] [PATCH] bbdev: add missing experimental tags
>>>
>>> On Fri, Dec 14, 2018 at 11:00:17AM +0100, David Marchand wrote:
>>>> On Fri, Dec 14, 2018 at 10:54 AM Akhil Goyal <akhil.goyal@nxp.com>
>>> wrote:
>>>>> Hi David,
>>>>>
>>>>> I can see that there are other APIs as well which are not marked as
>>>>> experimental like rte_bbdev_dec_op_alloc_bulk
>>>>> rte_bbdev_dec_op_free_bulk, rte_bbdev_enqueue_enc_ops etc.
>>>>>
>> It seems that all APIs defined in rte_bbdev_op.h are missing their
>> experimental tags.
>>
>>>> Well, that's the problem with inlines...
>>>> I don't think we can detect these easily.
>>>>
>>> We can, if the symbols get added to the version map as they should.  But
>>> (as you
>>> note), because these functions are inlines, theres no error thrown for
>> not
>>> following that rule.
>>>
>> Right, there are some APIs missing in the map file.
>> I am submitting a patch of those functions missing.
>>
> Sorry, did not follow up on this.
> My patch has been marked as "Changes Requested" in pw but Amr volunteered
> to fix those issues.
>
> How do we proceed, do you want a single fix ? or you can already pick mine.
>
>
I believe a single patch should be enough to fix this, it can be either 
you or Amr. As of now, none of the patch is complete.

Thanks,
Akhil

  reply	other threads:[~2018-12-18 10:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 20:57 David Marchand
2018-12-05 12:23 ` Neil Horman
2018-12-05 16:46 ` Mokhtar, Amr
2018-12-14  9:54 ` Akhil Goyal
2018-12-14 10:00   ` David Marchand
2018-12-14 12:35     ` Neil Horman
2018-12-14 12:52       ` Mokhtar, Amr
2018-12-18 10:37         ` David Marchand
2018-12-18 10:43           ` Akhil Goyal [this message]
2018-12-18 10:48             ` David Marchand
2018-12-19  9:20               ` Mokhtar, Amr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3dd7a64a-3435-312c-1ebf-fe278b529218@nxp.com \
    --to=akhil.goyal@nxp.com \
    --cc=amr.mokhtar@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=nhorman@tuxdriver.com \
    --cc=stable@dpdk.org \
    --cc=tredaelli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).