From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1799AA0C41; Thu, 16 Sep 2021 14:57:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4CF640151; Thu, 16 Sep 2021 14:57:15 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 983A34003F; Thu, 16 Sep 2021 14:57:13 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="209646363" X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="209646363" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 05:57:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="452917500" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga002.jf.intel.com with ESMTP; 16 Sep 2021 05:57:12 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 05:57:12 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 05:57:11 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 16 Sep 2021 05:57:11 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 16 Sep 2021 05:57:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KlYqHyvDV36cWvMzFgONqAav0oRG40p2l6MtSxlepgFzzDGr10BCWbu3F7IYX0jSYXQV87s1+TomBBI4LjYonkB+3hCLeqHZW4+jYBP4+uvGOvcjJFAGY+Qz6lwvZBnjbzi2101Cuii+Dr5cCSpWI0elSl8v7+ZcL+J+Tz37jPF1M+ptnh9GWRQ+n0fII62wXlqFEmg7PRzHrft7WpXREzjnpgDsDG8cq1qtdVkfFyBMzur8qtdyP+wuMf6+OPxJwwqIH5jnDCeC4dPDKZyGk0ueB39jfyZqEA9RUGKmIb+ZJ8WuMBV1XS+vzMQmE0iRm7xB9qCET2s7x5ZfEcVQGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4m2A9/6k5izFOiicj0QzmQ5k+B/v2VW45CIM3aDY1rc=; b=dBoPeJFwGy8ZaikYmEyquHmmkjEwgwYcf5xQr9QjIbXXG0R2yPr5VgPwhk4yOWzUzjMvVfqn1ATsChbbyB3U0tCL4XtFnFDt6eX+BLVPBb0IgtkTR5CIU5qnFpeETeypEGUvjHcidgdWrGHFwFbOvjNBOfRg7191v2XuDNE6VCuP4iOZZx80n53vRVjtHDs9l7/ydyGZBi9cbk795tiBA6FEgbxCigPU82MsL7k+2VsTBByxuHgQMOmF89CDvHGAFFOggO+cPe4d1EdEAUP9pue2iaX65oXr7an67VGCYB8bpYeFK2wSCpmXyt5YcpDkaXOJMOMBi+qXn8riEEx9GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4m2A9/6k5izFOiicj0QzmQ5k+B/v2VW45CIM3aDY1rc=; b=qNZAYkhW2UnZPDy7/7hRphriQgTTgh3aqEuXCUSZLYbcJsVw7vM2SCdrtOYZp0hMNJMKSD872xpDjWiA9GCYc57V6EzJ5D01mCRqr2d9FnLBhChVpZbRT6ukcI9VD5W3zx1nBC2MUyxpQ36ppXkHhV0zY6Exvjvi76eRjMnvMzs= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5112.namprd11.prod.outlook.com (2603:10b6:510:3b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Thu, 16 Sep 2021 12:57:10 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 12:57:10 +0000 To: "Xia, Chenbo" , Maxime Coquelin , Gaoxiang Liu CC: "dev@dpdk.org" , "liugaoxiang@huawei.com" , "stable@dpdk.org" , "Thomas Monjalon" References: <20210904142805.791-1-gaoxiangliu0@163.com> <20210907005127.89-1-gaoxiangliu0@163.com> <0bfc1da8-8872-1f45-9455-d921aaa53302@redhat.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <3dd7d4fa-5eb8-04da-2798-4cb887f48ecf@intel.com> Date: Thu, 16 Sep 2021 13:57:04 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB8PR06CA0036.eurprd06.prod.outlook.com (2603:10a6:10:100::49) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR06CA0036.eurprd06.prod.outlook.com (2603:10a6:10:100::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 12:57:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62780f86-ced8-46c9-ea99-08d979117f2d X-MS-TrafficTypeDiagnostic: PH0PR11MB5112: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: axCRhNEgxMx8bx71ZK46oYTkh8vbJDJYnTTD+hjD+FEuyM/DxbGwLKogPRkr87MQbVzAODOGEwKL6lCo7T5qC0P19H45lMM0e87q63ME647+8MuEVK2wiUXbYTENoEanfU2fN/4qsBBUW2f2dj+ltaLgJEMGJgNgbtrB4WcNInO3BcTEmNnPnpYU2uWBXNC7/S+roufpFVGJ4wTUgRbg13FQsdzHcEM6b8B/ixD1cL6txvtWtMum6wFZhdjSEmjzXi8qyZONQt8m7CdSU6T4YTV6cttlWqL5NsZJ1SDz6z5CQxG1JgFjRziv2NgeyDH7E+hKUexzKrojYHi7/ZcVkIEMg/lNLOYz9zme+ZRZv5VBUerrJk+uVjW7aWAu8FL3MumZMvL/DmSy5G8KSEMvG4Jd5LnrMcqea/O0a24apFtXXh4Sbfo7WXrwCzVCwMwNBmve/+Uuni2/fUeiPB4j89IieVs7sc7+vOBBWj/eGws4xEZWF7O1DgzPwBYAS6DMq4wH8g2SlnA5mX6tcDIUblpAVvy4no3emAYgUrh0We99p/uBW2/o9kr9/f2iJSBAsp8veT3fvdFFbp/s9Hl8LOKsyTQ93TlhfpcTlKaX8XCDmVBjgpinzjwizFOjZ2Zskm2LOXvPjZ6AbcUD8LhQVR3T5/sK22hwSGMyJQXjPS6RQV0DToTQsx6pRoLLejyy5CLwJrRriv+83cP7WEjTeA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(44832011)(86362001)(6486002)(8676002)(31686004)(38100700002)(31696002)(186003)(316002)(26005)(4326008)(66946007)(110136005)(6666004)(54906003)(53546011)(36756003)(66556008)(16576012)(83380400001)(66476007)(508600001)(8936002)(5660300002)(956004)(2616005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVl4MC9yK3VGa3BzMXFLOWFjczA5OEZ4NnphSHlhUm1MODlyRkpDZllxOWRx?= =?utf-8?B?enNzeXBoc28xMGQ5ZjNBaG8vRnpTc2Vyb1ArL2RKdHBZYnZCQlJsYVZxZXJH?= =?utf-8?B?aDRsVzVOQWt5cnFEeWVDc2pJblI4RnFidmZ2OTJ2VTR0c2w2WnZPdWNiMFJl?= =?utf-8?B?UDhxZkxBYkNTeUQ1UmlKbnBUWmpWMk04YmQ4c3ZjMzR4MlBZQXJ2L1cwQzQv?= =?utf-8?B?aC9iYXY5bEpMVnZQSXJlS0dMM0FHeHFINnlSczhSdjNwaHdUajVnWkVvYmM4?= =?utf-8?B?ZUY3ZkRmWmlaWU5GalRlczhIbHYvZzlWd1VRR0hXNzlMdUN2WG01S3BtczNt?= =?utf-8?B?QldYYzQxVzFKQTdGMFZhazRyTG1MYXRuRTd3WUtid08xZ3QzVTBLZ2RZakdk?= =?utf-8?B?eGxhN0lWSWdFVGRjKzUrY1NybVpuUkg1MUVIajBOVjdhVitLZUxoalRkaUJI?= =?utf-8?B?TnRmUHlXYTZzMEw2WXkyUW9URmpOKzNibXp5dmVtaEI3K3kwQlRUZmpDZGt4?= =?utf-8?B?eVNhb2xqK0FYcEc5OGRqWm0vMlMzb0dvZnZkRkJEd0lsb3BSQnVRd3QwT1Q4?= =?utf-8?B?ZUZZamRFOVNERVFRc1EvZWtaQ1NpUDdSRnhaK3Y1eE5OMkFXTGN0Zmwwb3R0?= =?utf-8?B?Nnk3RVBOZzFoaTJTVzdhZnUwdDQ5cEFuL0N6UDQzeUgzM0JVbTdIZWFtZnVj?= =?utf-8?B?K3NTNUNzMmhBOWR0R2FZSFRKMDZEUWx2T0NQdUgrUE5TRmp4UlIzbExodnNX?= =?utf-8?B?WXJIdUl5dXIzbmNlUFUvc2pHN3MzbTF4THBYdGJhZjVJNDE4RkxPaXJibnhD?= =?utf-8?B?OWF6dkM5bFlsU0JRbk12ZElXdHp0eEl1Q1RWb3JZNTV0OUdsNG9aSlNuek1R?= =?utf-8?B?Y3A5NlNuSVB2ZnRHNVFOZXd0a2dPYW85b2FNblU0cyt0L3EzU2VyODFTNzh5?= =?utf-8?B?R0k0SHV4UzdtK2FaWnN1TThFRXppY0tvd2UrbEtsK090djRHZmVNNG9ScEcz?= =?utf-8?B?cFM1b2JabFRLU2RESHk1N00wNlFzT0dSZmQ3TThtZjhuOEJjNXhZcE0rSlph?= =?utf-8?B?NVpndjZocnV2a05qN2oxTjMzVXRXSkV0ZXVRSmJVaXNWc1lVbEtRcGRaSFMx?= =?utf-8?B?STA0WFFBZThET2JScEMvd09KbUFXenhKaFJZM3E3eUtTUW1PWklJN1A0QkNu?= =?utf-8?B?eWtCai8ySzNzc2w3ZHhJRjhSWVVmMGJRU0FWZTAwSzlmY2d5QmxNcFFpOWo3?= =?utf-8?B?ZkVzd0twRjBlZjQ0aC9KdjRlNmtlSTAxUDhxYW56dldlMnNFSWJoMWZxNm5U?= =?utf-8?B?Z2YxbkR6dENWV1VJWS9sWkxJS3BPUDFoSHNkeHNNR2FzOVE1QmtpL3ljNzdq?= =?utf-8?B?VTNiQmdVSFZIanFoaXVIN2QrZmNYQ0NmR0NneUw1RXA2YXRCTmhMQ2lxMUhU?= =?utf-8?B?MTBUVTE5TnV4TWZVM0hodDE1a2dudEVPRHNURmtCb3c1ditYSStJZE1EMVZ2?= =?utf-8?B?TThXaEVObGZPVHNEM255WWdwM2RuQXNLRGlsL3NjOVlPU3k2bUNRaFN6M2Jh?= =?utf-8?B?V0dUcm1JRkl3QjdtZk5rUit5eVY3d1NVeG1wVWFNM0NWZ2RWRi9Qbk1ZMXBi?= =?utf-8?B?VWQwcXRHY1czV0tYNkcyc3pIRVFBVTNiU0ROSVUvTldlWUJxS21aU2dBb0Yr?= =?utf-8?B?Z0dWQzc5NGN0cldtUDF3eHIwQ3ZKVTVCSHV6UnFrczNNdFRPYkhQUmFhWmFQ?= =?utf-8?Q?4VUbIwSBn0aA/6Gq7C2L2mT3dzgw+YostrlFiZp?= X-MS-Exchange-CrossTenant-Network-Message-Id: 62780f86-ced8-46c9-ea99-08d979117f2d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 12:57:10.5980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g6n8tPKRn6kcgdcbEUQI+JkT/AJ6J4al0e/AEsjMmyIZbwytb0hlxaF9tZkiWjGnr3VtOLESvwWDmIoTZDbybA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5112 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/16/2021 1:37 PM, Xia, Chenbo wrote: >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Thursday, September 16, 2021 8:33 PM >> To: Yigit, Ferruh ; Gaoxiang Liu >> ; Xia, Chenbo >> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas Monjalon >> >> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket path on >> adding connection >> >> >> >> On 9/16/21 14:28, Ferruh Yigit wrote: >>> On 9/14/2021 12:30 PM, Maxime Coquelin wrote: >>>> >>>> >>>> On 9/7/21 2:51 AM, Gaoxiang Liu wrote: >>>>> Add log print of socket path in vhost_user_add_connection. >>>>> It's useful when adding a mass of socket connections, >>>>> because the information of every connection is clearer. >>>>> >>>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Gaoxiang Liu >>>>> --- >>>>> lib/vhost/socket.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>> >>>> >>>> Applied to dpdk-next-virtio/main. >>>> >>> >>> >>> Hi Gaoxiang, >>> >>> I can see you are in the git history as: >>> "Gaoxiang Liu " >>> >>> Since we are trying to keep unique identity in the git history, I will use >> the >>> one in the git history. Please let us know if that is problem. >> >> I fixed up the Author field in my pull request to match the SoB. >> Did I miss something? > > History is Gaoxiang uses @163 email to send patches but signed-off with @huawei email, > So I told him to align and Maxime to fix when applying. Maybe it's my bad about not > being clear about which to use because it happens several times Gaoxiang uses two emails. > +1 to align SOB & author (I think checkpatch warns otherwise), but since in the git there are commits from 'Gaoxiang Liu ', I think we should align to that email address. > I notice people from Huawei sometimes use two emails for author and SOB tag. > So I have the same question :) > > /Chenbo > >> >> Thanks, >> Maxime >> >>> And is there any specific reason to use two different emails? >> >> >>> Thanks, >>> ferruh >>> >