From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36E98A0548; Thu, 1 Apr 2021 14:06:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0580914110E; Thu, 1 Apr 2021 14:06:12 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2041.outbound.protection.outlook.com [40.107.237.41]) by mails.dpdk.org (Postfix) with ESMTP id 9F5BC14110D; Thu, 1 Apr 2021 14:06:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RM1jUjwTsCOBR+zu/L6o41yEPsRH0ZTuNZZyIPvAQ0J3LwTElFgfxsUjBHDUUKMfUxdHrJoEBmw7D+zmek2JTmrlPTQGbSFjM4CD1bjYacPNXPpr4cu7ZJLtNwCuk0bljzZ3ARh6fDn44cFmgkoTk9+PUFO9aQSOJTaf71iA4LkkUWtCcjvXChw0BqkK85RxITvCtIzKjq+01AlBagwBzXLVW3pz6PzQJBKxotsUbhRWVgMgikG/dCZgoqjMiFvZCvdy3cL8PrVMhVBTPC4FrnpriR5wr3WhlwAHUFmCQylgDPgHkASEL99n8ADGYqi07XxG46tt9uqPWKVL094bgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dlvliDlOTvlLSg99uggbV+SZcwIG5pLB9xoCZDbZ2Es=; b=PvLWy7Z92XEC8/bZw05JzIg/6y8Abzk7qJsXsjbvYxv+Vd15ySfOAbnZ5enhHTBt7CrcQ7y4giDudqG1QU47DsqbPLxfWE7/ce9dDH6f/LfMvBY2FdSF3/MMt95jks6gJ/GLWl81bma3R4bVhy7WvMX/UVm1gVnaiPCelxL0NC+ZybYh4EYq6349V9Wrpfw+hw8YMFofUNZEYapBPnkmFonoFSVNqOZMaQqlP8hVDxq82AB0jhJf4msdk/j4UnK6vXw0ycyk+oRmnr/mdtGWT9mcBfcrqZB96LSYDhnGfKx8dZiblkPAYGcKA8sLCEOCzxXaY+zXFBeM8ub3s0J28Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dlvliDlOTvlLSg99uggbV+SZcwIG5pLB9xoCZDbZ2Es=; b=UDfti4wsqLvmCclBpu/64q0gZrDFfYhQ3ZHU5x8a0/7MFmRuG5aKprDSPyTAvcX/gxg/sgGAz3PviNZfBEiNnJiMhpPqOn6R3JD0Gno6/j+/muCkNgdiTq9FOQi0tOmGPJLwZn1IzzkJAB+4zslCHNDRFCq9Ox5ffAnkDjFN5Qd727HCmLGuy3M02/IBPUB8Ow+YMGznQBxf/AiFhEaVyeGK562I2hMVDGxjNPlR/yPvFqeBR2VIDWpZJ8IUCigLwyF8VhxRwLCtemAOMEuDSCbLc7Ewz1I87LyfCvNe9pc+XZhnLpAUZnaoJUGgESrPLeep+VUQfl/I5OFDzYrlrA== Received: from DM6PR07CA0044.namprd07.prod.outlook.com (2603:10b6:5:74::21) by BY5PR12MB4211.namprd12.prod.outlook.com (2603:10b6:a03:20f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Thu, 1 Apr 2021 12:06:09 +0000 Received: from DM6NAM11FT029.eop-nam11.prod.protection.outlook.com (2603:10b6:5:74:cafe::46) by DM6PR07CA0044.outlook.office365.com (2603:10b6:5:74::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.26 via Frontend Transport; Thu, 1 Apr 2021 12:06:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT029.mail.protection.outlook.com (10.13.173.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.3999.28 via Frontend Transport; Thu, 1 Apr 2021 12:06:08 +0000 Received: from [172.27.14.51] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 1 Apr 2021 12:06:05 +0000 To: Thomas Monjalon CC: , Gaetan Rivet , Asaf Penso , Ori Kam , , , References: <20210401074913.16563-1-elibr@nvidia.com> <7504044.RxHU5scrEf@thomas> From: Eli Britstein Message-ID: <3ded5f26-d1c7-0d87-0e5d-50ef183e29cc@nvidia.com> Date: Thu, 1 Apr 2021 15:06:02 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <7504044.RxHU5scrEf@thomas> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 05116738-b41c-4e72-f2f5-08d8f50688c9 X-MS-TrafficTypeDiagnostic: BY5PR12MB4211: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D+mHSRG1qgMNMnNyTXYjtGq6N8R2v00aOpQemd0CekUV7Bd3y1u2hlzjWksJG5pcTwylrXdwsRkrq4iqMuULJ4r5E4QzhcMK7F7DOr6j/yI+dKSQ3wHExX6x/Hb6Ocxubsn+DKx2cmG3DV/JSkqmr38M9/AgDY+lCX0jVKeB3uBrml8J/TOaZcD4lBTRYCG4jn/5i446Twd/EdvjVRLZ5KnId7PJF+i5KpSDHqlmkha5Izr031ZxYGKeh7jwn/0MsCXiwdmxFWHO1GrdD7hQ1Yq5S8OJ1q7F4RNF1janySA+wKqJHza1gKVnRyn5c8sNZUiBNm1O80nwePsQK1XhyOyQdxF2YT/NRPFd7c1y7YoVXds5U2aypbOL+Tkn/8BxPDe8gKB6tvU6OcqhHoZaSrzITjME/yNTao+T9086VVpxI2IP9lXTT+RSBOws975Z8Pk08VVbNXwEj/8Dwt+rXnECMxHSl+emeRVXTE2XVH7gRnY4v/qaPLC9faEsKY4pOP4+X9yv/JRTfBOTPLEyke1JALh3C+Se3+MwWdXjJDLtpqSDo4lIRIz/XNGpUikx9SCNazHnvDO+/m56xToTH8/L6A8LKT6mL0DV7qcYg40PWhlLYQOdQQuEduOW21VRyCes1o1KHkNPz/cRXl23AgXrlvgmsq+Mr5qqGxvdUV6rauN0/FoEU/qOH1LPdKVBiL0uZ2Ivwu3YJbM2XXVOsYnGtSSG3TzWaAQMILq/4uLjmBh+jrY6ifks4Zs9PP+GtxsqCQI+XUSlRPul3Pa0Kw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(136003)(396003)(376002)(39860400002)(36840700001)(46966006)(7636003)(82310400003)(53546011)(36756003)(16576012)(2616005)(426003)(36860700001)(336012)(16526019)(26005)(82740400003)(107886003)(70586007)(186003)(31686004)(8936002)(6916009)(54906003)(8676002)(70206006)(2906002)(356005)(478600001)(47076005)(5660300002)(966005)(36906005)(4326008)(83380400001)(86362001)(6666004)(31696002)(316002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 12:06:08.5371 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05116738-b41c-4e72-f2f5-08d8f50688c9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT029.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4211 Subject: Re: [dpdk-dev] [PATCH] doc: add Linux rawio capability requirement in mlx5 guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/1/2021 2:39 PM, Thomas Monjalon wrote: > External email: Use caution opening links or attachments > > > +Cc mlx5 maintainers > > About the title: "rawio" is not a word. > "raw IO" would be better. It was meant for cap_sys_rawio. As underscores are not allowed in the title, I used "rawio". I think "raw IO" misses that meaning. What do you think? > > 01/04/2021 09:49, Eli Britstein: >> For an application to be able to create "transfer" rte_flows for mlx5 > What is "tranfer" rule? https://doc.dpdk.org/guides/prog_guide/rte_flow.html#attribute-transfer How would you suggest to call it? > > rte_flows does not exist. You probably mean rte_flow rule. OK > >> devices, it should have cap_sys_rawio capability. >> Document it. >> >> Fixes: f772cc424c45 ("doc: add required Linux capabilities in mlx5 guide") >> Cc: stable@dpdk.org >> >> Signed-off-by: Eli Britstein >> Reviewed-by: Gaetan Rivet > [...] >> In order to run as a non-root user, >> -some capabilities must be granted to the application:: >> +some capabilities must be granted to the application, while others are > If you wish to show that all are not a must, > better to replace "must be granted" by "may be required". OK > >> +optional for some use cases. Capabilities can be set for example using > Please start new sentence on next line. OK > >> +the setcap utilitiy:: > typo: utility OK > >> - setcap cap_sys_admin,cap_net_admin,cap_net_raw,cap_ipc_lock+ep >> + setcap cap_net_admin,cap_net_raw,cap_ipc_lock,cap_sys_admin,cap_sys_rawio+ep >> >> Below are the reasons of the need for each capability: >> >> -``cap_sys_admin`` >> - When using physical addresses (PA mode), with Linux >= 4.0, >> - for access to ``/proc/self/pagemap``. >> - >> ``cap_net_admin`` >> For device configuration. >> >> @@ -477,6 +475,14 @@ Below are the reasons of the need for each capability: >> ``cap_ipc_lock`` >> For DMA memory pinning. >> >> +``cap_sys_admin`` optional >> + When using physical addresses (PA mode), with Linux >= 4.0, >> + for access to ``/proc/self/pagemap``. >> + >> +``cap_sys_rawio`` optional >> + For the application to be able to apply rte_flow flows in transfer >> + mode. > "For the application" looks useless. > We don't apply "rte_flow flows" but "flow rules". > What is "transfer mode"? It is not mentioned elsewhere in this doc. > How this capability is related to dv_esw_en? I think FDB flows are applicable only if dv_esw_en=1. Do you think need to mention it here? > Do we need it in case of trusted VF? I think a VF, even if trusted cannot apply FDB flows. Only the ESW manager. > > >