From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD90141DC8; Fri, 3 Mar 2023 14:39:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F21240687; Fri, 3 Mar 2023 14:39:08 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2077.outbound.protection.outlook.com [40.107.92.77]) by mails.dpdk.org (Postfix) with ESMTP id 522E6400D6 for ; Fri, 3 Mar 2023 14:39:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVPTzW9pLmd3JwxWrfnX1E8CQOKqxs2nOQ7X+gDP8zt7P7XtlyVodNJI5lfdLv2rMnerrxN9EgdARJNR4Ja4kwkmqARstEo/Ocnd5tvy1yGEH5Jyqgf4xB9XYFkUceySuoVgV1TLfpi6UF0JIxNPZqdh9TMrPgxc38nTQ/c8D9zwnhF/kp9WMzJ9XlyQwkmW4Kq4mWnwE/JVXCrWef/tXZtOEI/3/uaM2HTG6T2OgicQBWrFitPf9Y2QYXWjFr2qBvmRI/RbRdNZ+YOdSrShg+9UV3al7TjRDzEeaW8VGdABK6t66/+7YCDG/f1IXRT0PVvcnVPfm0BN4Eu0oDzPcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vREhUeTY+asapSEPKZUEXsQSTYrbSstQpyws/zDT/oo=; b=U4RoVD7jndq50GT8ETtvgKt+ka86czcNBgeOOb/91KKILgNJO71aeaUQQ+CrpyLY6U61a/iIsZwAWjta0PXjqmi4VN5lL00FMSgqbNhAaqMQo7FLit6gse1SfqfqekHtpxhjmGjY3IGoZtw5p0jxNrTx4gMKMIIGc6ogj5Hb9XyKdPwk4S8FhhzHwxFVIo274d3+/zxknhz1qmTZ7772et7JO5YEZpN89+b5wh3OUJ/uB932e3cRnRsXHBiJgW7apUuTv0SWE9kT69UhAxmCxhGy0KB+jWlYL+xkeMo+iWbDxqpSSJ8AO5Wu+uj89CAdY3pLABmSmZlyFdnhwyYwDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vREhUeTY+asapSEPKZUEXsQSTYrbSstQpyws/zDT/oo=; b=Im/FQl9L5A731cwBodRNXD2MQkDsEb10zgiHb1KgmE92JKVuK7FWkSbEo88aDHvKWnhANiHFgzh+Q73wvuMXVMGqV9J/537iWwaHQujtOfq7mKFNA9QXWnYEdWYuyB8HrH08JhxEaY4QboELa1KvKcfOZsVL8zFVu+5fGHZ7w+g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH0PR12MB7470.namprd12.prod.outlook.com (2603:10b6:510:1e9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.22; Fri, 3 Mar 2023 13:39:05 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%4]) with mapi id 15.20.6156.022; Fri, 3 Mar 2023 13:39:05 +0000 Message-ID: <3e0dbc57-6ef2-b3f9-93a5-eeb241f33c98@amd.com> Date: Fri, 3 Mar 2023 13:38:10 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/2] ethdev: fix null pointer dereference To: Ankur Dwivedi , dev@dpdk.org Cc: weiyuanx.li@intel.com, jerinj@marvell.com, david.marchand@redhat.com, thomas@monjalon.net, yux.jiang@intel.com, dukaix.yuan@intel.com References: <20230223123029.2117781-1-adwivedi@marvell.com> <20230303113137.2745570-1-adwivedi@marvell.com> <20230303113137.2745570-2-adwivedi@marvell.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20230303113137.2745570-2-adwivedi@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO0P123CA0003.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:354::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH0PR12MB7470:EE_ X-MS-Office365-Filtering-Correlation-Id: 73861180-5c0f-47a5-41d5-08db1beca7ec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nK1q2sDov3/qBQcWLn0BWif8TIB5zhclNC5XuyZh0SnL7J6Uwx/2KmdUvQXDM6kk86xwpU0jmhSei6ec42Y5rlFVMpJ3/vgJypESGxVQWTc54fsQEdHdXoxQ+GaD6e9nh3ld4NFekLxOCShgzayNbxTojgrHhgblKef9RIhJ+dgYL3XOirv4NF7h3v7U9nxLDVSh1MAmgW5B11BNiKqnY49zlbfHUBRBGcG6AbgKh2m5a83tzCyMZKPXFLrNNMU5jgumErF1c9Bg3jnU3VLm+8JQTwTp2aZ4XGKsAYB0JqradGyOgDcz1mlOVIezer+biDLiCKz1CfOCkuMXuop0IJxvjVooK4ORn0waJ/IQmuooD+1qpolkj6CbNI1QT5NZ7Gkq+dd5LYc9R2YbN4UUXH5BnnsZEDX22QG2XyD+sMax7DL+Kef/EZt6gG7hwePPzR/05QHh42aguGvPFrDZO8/doetuHT02qDDtzY1pMPcIK64TvSzLTg6lRx37WAFjZ4pbtf7ITfEjn5Qfp4ot/mxLTf1RXvaa9e/WKEAobF4Vw3jWosdfVZeglhyvCFJKUMtAP8btIuSKKHGH+TD0t9LNQiR7Vw8p+Jq5OVQRPn5JuA7+2HxXERz/VHXWSdglg37UMKuanMCV/Y0ar+quhN/lCpk8P5/s0gTUZ8FYiCm8IceiGwwWyhf0R8yIUmRZP1SkUwyyoBzVwxXN/70jJWSHjV5z8S92pvd+M07xmQA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199018)(4326008)(8676002)(66556008)(66946007)(31696002)(6506007)(86362001)(2616005)(38100700002)(186003)(36756003)(316002)(6666004)(53546011)(66476007)(26005)(478600001)(6512007)(6486002)(44832011)(4744005)(8936002)(5660300002)(2906002)(31686004)(41300700001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2Y5cEVybmtGcmh3Q2tnN1E5dHNjRjg0dzAyOEpHanZjTkJFQ0ViYlkyM0JE?= =?utf-8?B?alZkVTdTMEJycFJvQWJzbFN2TjlMcUNLc1pQZjhFZDcvTmpFVWdTWmRHTmN3?= =?utf-8?B?T0VLR21CakNwNUx1a2dWZnpaQ24vcjNEck5LRUE2dVU4a1E0R3RyOWg3UjBq?= =?utf-8?B?Y3NaWFdiNkRBNmJLcmpZTHBMVGhSRkRrZllXU09zVmxCTlp3SFl3Tis1dGVw?= =?utf-8?B?NlBscWpwUUR4Z2cxaGhUQlM0ZThOQXpnRkpETE1DYVJaNUgvSFo3aEE2cFhs?= =?utf-8?B?Mi8rQ2kxWjZKNlkvWGhXUzA5T3Q4NlU2UU9DanNBdUJlOWJ5UG1VWnZUTjdF?= =?utf-8?B?RUZkaFg0bkdHM2pneFhhRTBFaEYwNU1IYU8rZUpVRkJlZlMvU2h6aWRvYmhl?= =?utf-8?B?U3VqWGUvNmt2dUhkMG1PU2lTRW50MTQvN3VGbG5DS1huY1JHRFhGNktraHY0?= =?utf-8?B?V2xBN09pWWRnWVVvNmtaaEFoNTZ5d2pZQkthK3pUVEVVMXF5YUM2NHhhZXR2?= =?utf-8?B?d2ZPK1E5TDE3eUU4YncwQ1lkMkdwS3RiU1NUYm44V0tIdEJ6WXVjQ1lZcGdQ?= =?utf-8?B?RWpIM2VDZk5xdW5aeld2UjVxWUlneGlTM2licVV3RHlwN2N5SnhmaHVNZ0Iy?= =?utf-8?B?LzE0U25BbnhYc1NXYzFEZXAvbEY3TGQwRkMydEo2K2FIVFdhcnliT1V4OU5U?= =?utf-8?B?MW1VMjJpZWZKNERDQ0Zoc1YzczdHVVczMVpBeWNOeDArcDd6Ly82ejdSSHkr?= =?utf-8?B?UHRvQTQ1anU0c1ZmQ3RqYWdoQ2lBeVZnQTRvcEZ5blR3eUp4ZWtFd1FiQ01Y?= =?utf-8?B?TVd1OEZrWXV6TjhISWF1eEZPZ1czWW9IbWhGSklObUo0M290czJFRzkrZStX?= =?utf-8?B?TVlaTVczT0l0bHVHQW13NCtLY0t1VTNsOGlWNmtncjF3Zkk0SmlFOTdROWwv?= =?utf-8?B?bUJ3RnhnSzMxSzNZc2U1eEhUemVGeUhrN1NUQXJvb0Rvc0twTmxSMVZkdWda?= =?utf-8?B?bXBVS1plSVVDWEVmS1ltNUYxaHhqWkxnYkdZSnBhZkdYRjBFbXY5aVFHRFRa?= =?utf-8?B?SmNsSmhHeXdwdU8vSEZoVStBUXpWaVpPRi9Xeitsdk1ZTTViRjAwbHp1Q2RR?= =?utf-8?B?NUNFaEVObzRoTXpuVFdwOTNxOGp4Z0l3UnZuVGNFL2hSVm5YOFJwR3VFS0w2?= =?utf-8?B?ZHZVSGtsbktBUEZsM2NLN1FWcTBDVTRHcDFvNzZsSWRKTVRJWGNKYVAxU2VU?= =?utf-8?B?c0Z4WnJvVHlCNlNWbnpqVHluSXRIcGJNVGZ1Vm8remJsMSt0WG0yc1ZWNklK?= =?utf-8?B?S3d6Zkt5Y3FGQTlvekE5cmtEREJRbzRTK3FVVWt0OU85NW9ZTFJqQkxmTlVl?= =?utf-8?B?MHdVVWJ0UncwWUxBVWkrYVk1bkliK0Uvb1lweC85eW4xZXlhVEU2eU9oY2FO?= =?utf-8?B?MjlCMjl5dGZKRkc2OXplZFRhNHBZSkhVL1RibXBxclV1T1BUL3Ftblk3Tkdv?= =?utf-8?B?WlZTNWNyYk94dzd4NEdhbVNzZ0sweGh2RmpGSmxOa2RUNWJNNlRkOEFnWFp1?= =?utf-8?B?NDE1ZTBpWDgvYVhKeFllU2diNTlBNVMwbncxREpwa1dHMGFiSjFXVW1UL1BZ?= =?utf-8?B?SExGKzdyenFmTld0b1FwUHpFcXUycGtKQUxFZm84UC9tb2xyeGtBd0hEOWRu?= =?utf-8?B?QXpJZmh3alVQdDRFVEZoVEFyZmdoTXJEUEJUdTBUU05PdHdLRVd4SFVEd2c1?= =?utf-8?B?c25XMGt4Z05KNm9RNnU5RFVWeUttWTArMlJIaHRsYkdjcEY0MjR1NUZzRXM2?= =?utf-8?B?YytWZ3N3T1VpRlFCV0lHd3pTQlRpR25VOTJobmdCYTBYY00wQlhVOEt0T2RQ?= =?utf-8?B?dmROUllaOGxxQmxqNkcramNpRWRRQkE5N0NFd3IxcjVMOXBqREU1NGdyQWhm?= =?utf-8?B?MFRzZTQyTzNGdFM4eVRJQkVqYjdnNnVoRXF6Z2hjZjJDK3BpakNSdm0yYVlm?= =?utf-8?B?cGppRzhKcFV0WURLZ1laSmx2bjFGZkJQMW53OUdZM3lTWituZ0FFcGs0RTZm?= =?utf-8?B?Q3J0cW90dWh6S0c0OFNaaTF1NGdvRXBucHVMcHExQkttMzBRSU4xeXJldEFt?= =?utf-8?Q?1+kujlINI9PpuQWBcYCTjQtnK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73861180-5c0f-47a5-41d5-08db1beca7ec X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 13:39:04.9847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M1TIonFiykugQpbZHT4eCP1uw9rRK1v4O8mHXHkI4oakjgTJPCKTU2cAss5UptJX X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7470 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/3/2023 11:31 AM, Ankur Dwivedi wrote: > The speed_fec_capa pointer can be null. So dereferencing the pointer is > removed and only the pointer is captured in trace function. > Fixed few more trace functions in which null pointer can be dereferenced. > As a result of this fix the address sanitizer error observed with > rte_eth_trace_find_next_of() is also resolved. > > Coverity issue: 383238 > Bugzilla ID: 1162 > Fixes: 6679cf21d608 ("ethdev: add trace points") > Fixes: ed04fd4072e9 ("ethdev: add trace points for flow") > > Signed-off-by: Ankur Dwivedi Acked-by: Ferruh Yigit