From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2F2CA04DB; Thu, 15 Oct 2020 15:17:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 203011E936; Thu, 15 Oct 2020 15:16:51 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5E4B81E8C3 for ; Thu, 15 Oct 2020 15:16:48 +0200 (CEST) IronPort-SDR: z3uv2On3Lq+kOFiavbQXS7eFRJbD7Qg+cD/XeFwB+0TxoBd8wNaTR2mL20ouL610fmFxREX/ud LlEpILXimHlw== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="183884346" X-IronPort-AV: E=Sophos;i="5.77,379,1596524400"; d="scan'208";a="183884346" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 06:16:43 -0700 IronPort-SDR: JQHBOfsQM7vX0PotZDFSMRUtyGSqwkqV5kuIFQ9mtNXJ0nTpL+gVgSlqwm3m75MG/32NToh65K /5YgnV7VPtpw== X-IronPort-AV: E=Sophos;i="5.77,379,1596524400"; d="scan'208";a="464292273" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.84.112]) ([10.251.84.112]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 06:16:39 -0700 To: Anatoly Burakov , dev@dpdk.org, Ruifeng Wang Cc: Liang Ma , Jan Viktorin , David Christensen , Bruce Richardson , Konstantin Ananyev , david.hunt@intel.com, jerinjacobk@gmail.com, thomas@monjalon.net, timothy.mcdaniel@intel.com, gage.eads@intel.com, chris.macnamara@intel.com References: <7d5724730715ccfbf55baceae42b91a2351020f8.1602763439.git.anatoly.burakov@intel.com> From: Ferruh Yigit Message-ID: <3e1512f4-6f71-4c84-32fe-f66f1ba8ff5f@intel.com> Date: Thu, 15 Oct 2020 14:16:35 +0100 MIME-Version: 1.0 In-Reply-To: <7d5724730715ccfbf55baceae42b91a2351020f8.1602763439.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/15/2020 1:04 PM, Anatoly Burakov wrote: > From: Liang Ma > > Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as raw byte opcodes because there is not yet widespread > compiler support for these instructions. > > The power management instructions provide an architecture-specific > function to either wait until a specified TSC timestamp is reached, or > optionally wait until either a TSC timestamp is reached or a memory > location is written to. The monitor function also provides an optional > comparison, to avoid sleeping when the expected write has already > happened, and no more writes are expected. > > For more details, please refer to Intel(R) 64 and IA-32 Architectures > Software Developer's Manual, Volume 2. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov > Acked-by: David Christensen > --- > > Notes: > v7: > - Fix code style and other nitpicks (Konstantin) > v6: > - Add spinlock-enabled version to allow pthread-wait-like > constructs with umwait > - Clarify comments > - Added experimental tags to intrinsics > - Added endianness support > v5: > - Removed return values > - Simplified intrinsics and hardcoded C0.2 state > - Added other arch stubs > Hi Ruifeng, This is the patch we have talked in today's release status meeting, can you please check the patch from Arm perspective? Since the instructions are not supported by Arm I expect it should be OK but it would be good to get your ack to proceed. Thanks, ferruh