From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 112A343893; Thu, 11 Jan 2024 14:28:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B889D40266; Thu, 11 Jan 2024 14:28:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 060B74025E for ; Thu, 11 Jan 2024 14:28:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704979726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3cj3SsbAv1MczgQQTxXX8Py7w2sP9EAuNgA77aDcG8U=; b=QS8nZsLdGeju4EIvh8fwco0wJKUl2YjVIG33DDUSB61te2acrAMltrPMTRGuaqVEcvzLVC wyQNSXOwSwPfXYQZQG8JMskrW51SD8nkjs7AsMlYFHZNCOIvtfwA7pH+XfRRo+oc4teh4f UGr66cjohyUxi9KuET4jOwfl9QoDIDU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-ikXBqcXRNgm763TnJqFXQw-1; Thu, 11 Jan 2024 08:28:44 -0500 X-MC-Unique: ikXBqcXRNgm763TnJqFXQw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40e4576b7e6so33795245e9.0 for ; Thu, 11 Jan 2024 05:28:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704979723; x=1705584523; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3cj3SsbAv1MczgQQTxXX8Py7w2sP9EAuNgA77aDcG8U=; b=NF1lxbUG9ybyXvvNGZWcUXv9Ys/YfTemW3UOEnOcYy9147E/RxYGBtRLXRCQ/CJ4xk F2V2ExJ8FYBfYuTQkibhO7dEgHwIhDhey9VUeY2iuotVzZUux8tnyS17EL9jpCZaeN6e 5GVfSsm6fiLpz9vL/BDjJql91K50hjjN86jZj9DlmQR7ldIivhDPUQSh/WWQK96jHk8d wGORvakukJoKLd+xUlYhAJHIvtAzl0GJRBIdhF/oY543qVIKd7Dq+jJXXm/2jOAHfVHl MyZlkPWI5T1pruMMvPsTw5/YoALkttK4YME+yG2NTyK2ytu/LlnF0fEIcPgTqnxQZjSt f4Nw== X-Gm-Message-State: AOJu0YwBIiWjOgI/xJGR61RODUkw7lUcIkh1FiHGo2JoQqJWe6kqZfJR 9C+2I76liP5G2i7HNelMz2dKkXok8IavLxVPiV/f5arxCee32/htK0v8lQOYejBX481wulmTpEb L3oOuJ7XxDJw= X-Received: by 2002:a7b:c3d5:0:b0:40d:8fd0:ec8f with SMTP id t21-20020a7bc3d5000000b0040d8fd0ec8fmr279161wmj.102.1704979723305; Thu, 11 Jan 2024 05:28:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEt6FiDgkKA4YxRVPyX01xBE70fX/ZnOW+PmzuQyCXwEoaGP/FwcZ++hRI3IIduNI2H6on0ww== X-Received: by 2002:a7b:c3d5:0:b0:40d:8fd0:ec8f with SMTP id t21-20020a7bc3d5000000b0040d8fd0ec8fmr279151wmj.102.1704979722994; Thu, 11 Jan 2024 05:28:42 -0800 (PST) Received: from [192.168.0.36] ([78.18.19.36]) by smtp.gmail.com with ESMTPSA id je14-20020a05600c1f8e00b0040e3635ca65sm5821460wmb.2.2024.01.11.05.28.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 05:28:42 -0800 (PST) Message-ID: <3e1ac663-f86c-476b-836a-9db820ad9852@redhat.com> Date: Thu, 11 Jan 2024 13:28:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s To: Maryam Tahhan , Ferruh Yigit , stephen@networkplumber.org, lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com, david.marchand@redhat.com Cc: dev@dpdk.org, Ciara Loftus , Shibin Koikkara Reeny , Luca Boccassi References: <20231222110441.2507650-1-mtahhan@redhat.com> <6cd6ab2d-56ab-4afe-b0cd-05ab6b017469@amd.com> <89fd40d1-cc91-4390-9bc6-c60f24129ebb@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <89fd40d1-cc91-4390-9bc6-c60f24129ebb@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/01/2024 12:21, Maryam Tahhan wrote: > On 11/01/2024 11:35, Ferruh Yigit wrote: >> Devarg is user interface, changing it impacts the user. >> >> Assume that user of '22.11.3' using 'use_cni' dev_arg, it will be broken >> when user upgrades DPDK to '22.11.4', which is not expected. >> >> dev_arg is not API/ABI but as it impacts the user, it is in the gray >> area to backport to the LTS release. > Fair enough >> >> >> Current patch doesn't have Fixes tag or stable tag, so it doesn't >> request to be backported to LTS release. I took this as an improvement, >> more than a fix. > > This was overlooked by me apologies. It's been a while since I've > contributed to DPDK and I must've missed this detail in the contribution > guide. >> As far as I understand existing code (that use 'use_cni' dev_arg) >> supports only single netdev, this patch adds support for multiple netdevs. > > The use_cni implementation will no longer work with the AF_XDP DP as the > use_cni was originally implemented as it has hard coded what's now an > incorrect path for the UDS. > >> >> So what do you think keep LTS with 'use_cni' dev_arg, is there a >> requirement to update LTS release? >> If so, can it be an option to keep 'use_cni' for backward compatibility >> but add only add 'uds_path' and remove 'use_cni' in next LTS? > > > Yeah we can go back to the version of the patch that had the 'use_cni' > flag that was used in combination with the path argument. We can add > better documentation re the "use_cni" misnomer... What we can then do is > if no path argument is set by the user assume their intent and and > generate the path internally in the AF_XDP PMD (which was suggested by > Shibin at some stage). That way there should be no surprises to the End > User. > That plan sounds like it wouldn't impact a user upgrading from 23.11.0 to 23.11.X which is always the main concern. > Long term I would like to keep a (renamed) path argument (in case the > path does ever change from the AF_XDP DP POV) and use it also in > combination with another (maybe boolean) param for passing pinned bpf > maps rather than another separate path. > > WDYT? Would this work for the LTS release? > > Is it needed on LTS branch? If the current limitation was an oversight or it's not really usable as intended, then I'd say yes. If not, then please consider the questions in http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported Seems like it's for Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") so it would be only relevant for 23.11 only, so 23.11 maintainer (TBC) should ack. I suggest if you feel it should be backported, add the Fixes: and stable tags, and 23.11 maintainer can review at some point before backport. thanks, Kevin.