From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 483ADA00C3; Thu, 3 Feb 2022 14:16:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1095740143; Thu, 3 Feb 2022 14:16:08 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 568FC40140 for ; Thu, 3 Feb 2022 14:16:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643894165; x=1675430165; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=QQLgCJeHIhQjPlNt2UkaUf8ri/otX/ZkF6DDEmKmRbc=; b=WQ7UQ/VUCTaXkPzb6DnMAxhobjXb4fs2+nx+ypUuDOcpDKrzioaIaxOL Rg1VTrcmqyx1UPyhNjv0S7kC9nSHE5PdHwrOUmNwkZ/QPcmyJpW+EdNzK +hDmK/sdF6GiltJZKupC1unRLbxf9Qbe3NcDh0lsl9SGCeT4rYKp/mbag bwJjMrsws2kbdhG1SMlWhDiy15uDPtziO5+iHg4xE+bu/6QgSPgGWr7jg jqbuDNirYYLb89VDwrCDy+7i3jd4RfVHUsY2NDq75shyc3ikHKcz14oi+ mxsxMJf9HGnPxc0LdHUY/ca/W8Ymxu79E1gbws4E4sq5s80T4I+CzQdTn g==; X-IronPort-AV: E=McAfee;i="6200,9189,10246"; a="247906129" X-IronPort-AV: E=Sophos;i="5.88,340,1635231600"; d="scan'208";a="247906129" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2022 05:16:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,340,1635231600"; d="scan'208";a="631337591" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 03 Feb 2022 05:16:04 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 3 Feb 2022 05:16:04 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 3 Feb 2022 05:16:04 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 3 Feb 2022 05:16:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c52ZmEbuzI9BxvV9VFvrYdyu7MTZuuh+FTOuJCLIVXyiqyxW2XWaq+DGPo6R8IeJhY100k8g+Z9Nz0iVP7j6PxSsK97McUlNSCOWaYmJveZHpnmbB/eVz1R5mTmvVh0uga/x9sp0/COyMH8jkUcdUuXYPaOq7MxPScm64NlhPORz7fTGBUNfqFTZ/KrTLSnWc0uzA1p+5NhwYSGqPvcH9FaRahzOR57+44ajgryJMTNqXW6ayTBK3WDHW5ioOXo2lWMVeXEB9NZpG0SzcbpMr17mwrrBMcpEkmjKs3r4gQKsnL6OInUUSDHWM4qDDdbivknhHumE6La9CHQtEKeiEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UHslFNzMPb5Tss1ZW0TaQSe/9QikF3NjueF41k5lTu0=; b=SVNXSxP55tR825ymxTNXci9ztObM0jtnQEPTdH9in4NyuTyFM902djyxwmTKZOkTrzuoxW3EaivE2kGqkbQpymUUgHuhlE4zn8pHg4260/SRQQAm5exf5fO8FHLBoL5LzaRmxNaOdOZjw6anXMNa3Y7O6Ru28Sy4bgzExmg3cZ65OV1Sse+UV8cWPxMYR9JmPhoXeWYv3JLh8fNnvkIBqi6AC4w4HC2W30vFvItK3/c77EGRlvKEmmofCWzNgoeghQFGaFbauersfBiwahFRTFsSgbe2EdsF8GmsGkj8smOi4Xi3WPoJDK9PnboYfxbMvkyRr6JB428a6Vups7srbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BYAPR11MB2710.namprd11.prod.outlook.com (2603:10b6:a02:c7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Thu, 3 Feb 2022 13:16:00 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022 13:16:00 +0000 Message-ID: <3e27a961-a944-f3ea-e3cb-81880455e300@intel.com> Date: Thu, 3 Feb 2022 13:15:55 +0000 Subject: Re: [PATCH 2/2] app/testpmd: fix stack overflow for EEPROM display Content-Language: en-US To: "Singh, Aman Deep" , Steve Yang , CC: , , References: <20220120025931.574106-1-stevex.yang@intel.com> <20220120025931.574106-3-stevex.yang@intel.com> <261cd7e4-a166-bf48-98e0-8bf6e257a7b4@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <261cd7e4-a166-bf48-98e0-8bf6e257a7b4@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0086.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c9aae46-a5f3-46ec-636e-08d9e717524a X-MS-TrafficTypeDiagnostic: BYAPR11MB2710:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:751; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lSHH26+FonwPeHXHS31wPyWQ6qlNr8kSLWeTFGtR+v/RRwwbaOY9bU0alilz0R2armThIU3BkGfvVCFH+Jpk/IQ8PtTOgoBla3Lch8uqYjTq9O/e2Sjwn5lCCmWJcKvhNlhnGHfge5mTTTQ1OJp5jFYVeS7fCHeTYKC1QWJ+GYn2xUt0WyEgA6Xv/pXBOGfWZMlUndRzpkZI6hxqRaMK9+wIZGHc91PbK7sFMX8y7ezmMVy5Lxrs+looBD22YdHanjO/B1RhlRv3tHGOhQ/QZ3UvMrSRKtPuVmuWaozu7MyWm3bzmDksQIYHiQe02G2r8tAOlflLcpUidQmVX6Rb8ecHYBmEovK5c6aPnlW65WAo6tbnu7kaBKZCgZWQkMwgBvsjGB5Jbq9vs8e8hRmuGkiQ8X6uldOUeFvfX+Beyy+e9sp3+i9naIAGnnNzUT8WmEffhkzAeYM8bWpw7bVn4rwKg4C7SRZyAoBgRVnAWDu1O23c930kGqAT/5xi0LgOj5CrEYyB3bzCokx+ipWyDgVY5CjFBSlNdCJTvHXdHfaemRr3qL/GUh2+VURv4Q/+pqvowY/1bBdNP2fpCYrE7mRfojko7ep/ugmrRHQZ0jmBL7I2O7ZSUQ8Qc8QZKnutKY2eNKt7kEYQ4UxmX6msIg7lBjKDu8sijWMm8cR47Da2MW4eQC8ic4iAnQr46McHABew3ySSTCXOIXXpMXcvuA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(2906002)(4326008)(66556008)(66476007)(8676002)(6486002)(508600001)(2616005)(6512007)(55236004)(53546011)(66946007)(36756003)(5660300002)(6506007)(6666004)(110136005)(44832011)(4744005)(316002)(31686004)(82960400001)(31696002)(38100700002)(83380400001)(186003)(26005)(107886003)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmFmUGh3c2JWRFEwTS9xcWEvVVpJaDdDcmxHWWt2TStxWm9QT3JDYW5sRlZL?= =?utf-8?B?SVJlZ0JNbU1yVXBxMTIzUmpGZFU0ZUxwMXgrUkJzTlVBWnllU0poeTdUeDdI?= =?utf-8?B?Zmt5QnBjRDNxMGRuWEhVYTNUREtkVVNKOHdHd1BmcUZmeUlWWFpSRld2YmVU?= =?utf-8?B?TStLWHJ2WStqNmVLMjVkYnE4aDNNMkY1TjFFWTJzYmpqK3FzNy9oa3doVVFK?= =?utf-8?B?VlBIenBtdnRmR2ZBQkExUEFheTIwbmp4aFllN2JuVTNaWmZVSlYycVBhU2sr?= =?utf-8?B?c0l0eVZoTlVNM2N5VWQvdmdVTWJZaXIvUTFMaHVaWDk0aU9zWWpZcklpbGFs?= =?utf-8?B?VDlLSGF2S3ArR3JrV3dHMy8xcW1uQ0V3byt6ZWN2STduVkNxbTVwSW9lSVJl?= =?utf-8?B?THBYbk82cUFNQ2pFVnk2QW8wVWdrREJpUENFSDNMUkp1ZHlMVlh5N2xNcEtZ?= =?utf-8?B?T0tUQVB4OVlxVDAvNk5MajRlQXdoMzBpU1RjdVhjV0VnSU5QSGEycGlNUDRh?= =?utf-8?B?TCt0aC9zdHl6ODQ0elc3bnV5OXpISEFnUG0rSUtLWkJ1a0lUZU5xNEVRbmZE?= =?utf-8?B?V0MzNlIvRzljd3ZLYTJlZzVhOFdKaG1GaUoxeHE4bUU1ZEdqVTR4cE9vRWt1?= =?utf-8?B?aVBGTGlhUTNkQzhndUdkM3hzQ0wyQkJVczdWdCtxWVhON09SOCtjd0VYUjZC?= =?utf-8?B?dWQzT2gyZG9EdHc5ZUVRVk12ZnQrdTJxL1lDc0l5Z3JLYzNJVHdTOFlreVZn?= =?utf-8?B?SUxIY3VFVk51OHg4UEt3YzNqSVF5Rmwrc0VUM2hNZmlWcVIyNStHRElMZUhO?= =?utf-8?B?ZkNiRlhLTW16RExZcFNvQ0JrdmdJVDRUZ21BenlQZlNhYkdCRmVyQzlGWTJ0?= =?utf-8?B?SjhTWU9DTURlNkZISDFzdmRGV081bStCVlpDQWJiZDMvL3NBdVBjeUtXNmdm?= =?utf-8?B?L1VIcktkdWJZOVRqcHEzYmhuV1ZubkVpdHBXUzI3V00rRlZyU1oxeEhKWDJ3?= =?utf-8?B?eWZjcGdscDRTQzdrdTJMVGpOSEZnNFdta1I4cjhXbWNXckpMOThtd2pkTTNj?= =?utf-8?B?eEpRT3hkb0lqeERsdU5wZEIzcHhzeHQ3TXU3eWRMcUtaUVNrbkMrOXVwVEhG?= =?utf-8?B?blpNNGdZT1FJZ1FBdGRpSFU1VUV5U3VOeWh0VitBZXdGM3NET1JSVEszYmRP?= =?utf-8?B?Z0loYU11ZHhMS0lIY2dhc291OGVtNlVESnZHTHM0TlpjZDcvNWJhcGJYNFI3?= =?utf-8?B?enQzRWRCVWtadWx1ZTVtclAyeEl1VWNzSnJ1QlpBVEcyT2FSR3VKVmd5ZytF?= =?utf-8?B?cWJKMDZrUmYrS05CUThNcjV1MWU2emxIK2VPNXplY3ovczEzN0U2UnpUYzBJ?= =?utf-8?B?YWp2Nk5tOW5xakNzaEQxR05yd1N4MG85TEc3cDhRa1BDZEZCRkFzY3FuSVRE?= =?utf-8?B?OTJ3eUFHMS9JMjB2QS90dmwreS8xZms5WU5JclpkMFdHQnE5Nkkxc2xrSmtO?= =?utf-8?B?bHdidzVIQ0VLNXFTVXFrTng5NFFMU1lwUmk5TDkwaXgwQzNaMVRmekM4eU90?= =?utf-8?B?a0Z6eFhFd3NUREtHNUNUeTM0Z1FRdUtUaWFwWU1mVmxqWFlmQ1BWQ3pYbldo?= =?utf-8?B?cmw5a05PbHNEYVU5QVROd2d1NG5YTUhSUVVLVGt6RC9FbUI3L0tzS3Nqd3g5?= =?utf-8?B?QkREaG1FLy94QWYvUDRSTTlFVDZLdXZIcG5vQUVzbXMxNWVKRkc1bWw5blY2?= =?utf-8?B?eXQ3ZXdqaUhYYWRqVlRyQnBnaUsxQTNSZCt3UGQvRlNVSk11a0lwQlRCOHp3?= =?utf-8?B?VGhUb2hkRmxXVFhPNTU3Z0N4N0VRTldNSllPdGk2TkFHNUt0LzEvR21JL21X?= =?utf-8?B?a3I0QzNWMWRRcUgxV0lHcEpST1RTOGwzSjU4NjRNdHVVZ25rNmZTZ01EVkhn?= =?utf-8?B?UUlaTzZTczJzVU92enM1RFdtK1dhQWlKTVREK3B1dENmVk5JcnZZT2xrSFls?= =?utf-8?B?YzFPd0lRL21tRmloZW5EK1FsRjVCTnM5bGlJOWR6ck9vRWJ6ZEo4dXFIQUJs?= =?utf-8?B?OVEvd3FzZVIvalUzeGQ4bkJkZjU2RWt4STZST1UrRC9TTUszUkdROGNpSDBh?= =?utf-8?B?amJiU3AyV2NWaTFtYkd3TE0vSy91NXUvTk9Vek0wTWJSTGprSS9UblVVbWY4?= =?utf-8?Q?7yn1GYZXowNKIA+NIyEnZ/8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5c9aae46-a5f3-46ec-636e-08d9e717524a X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 13:16:00.3474 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KxZI2G0T6jmViOwy2xyNEZ4X83+4VSrq5sTKJtHpp5Ks/MFRU1Dk+oXgoc/0qzygGNj+Ew4SJif14Qqr+6H+xQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2710 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/2/2022 10:00 AM, Singh, Aman Deep wrote: > Hi Steve > The patch looks ok to me. > > On 1/20/2022 8:29 AM, Steve Yang wrote: >> When the size of EEPROM exceeds the default thread stack size(8MB), >> e.g.: 10Mb size, it will be cashed with stack overflow. > Just spelling: 10Mb/10MB, cashed/crashed > Can even rephrase, like: it will crash due to stack overflow fixed while merging >> Allocate the data of EPPROM information on the heap. >> >> Fixes: 6b67721dee2a ("app/testpmd: add EEPROM command") >> >> Signed-off-by: Steve Yang > > Acked-by: Aman Singh > Tested-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.