From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Yaron Illouz <yaroni@radcom.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] patch for dpdk-devbind.py support ipv6
Date: Mon, 25 Jun 2018 10:19:12 +0100 [thread overview]
Message-ID: <3e52a1e9-069d-124b-fd37-ea4c1bf2ef80@intel.com> (raw)
In-Reply-To: <AM4PR0501MB2355B83A8EE5A1B817D2E6E5A1760@AM4PR0501MB2355.eurprd05.prod.outlook.com>
On 21-Jun-18 3:51 PM, Yaron Illouz wrote:
> Hi
>
> dpdk-devbind.py support only ipv4 interface, when run with -s parameter which is status, it display all ipv6 interface as non Active
> It set interface as Active according to "ip -o route" output
> Here is a change that can support ipv6
>
> @@ -269,6 +269,18 @@
> # filter out all lines for 169.254 routes
> route = "\n".join(filter(lambda ln: not ln.startswith("169.254"),
> route.decode().splitlines()))
> +
> + routev6 = check_output(["ip", "-6", "-o", "route"])
> + # filter out all lines for 169.254 routes
> + routev6 = "\n".join(filter(lambda ln: not ln.startswith("unreachable") and not ln.startswith("fe80::/64"),
> + routev6.decode().splitlines()))
> +
> + if len(routev6):
> + if len(route):
> + route = route+"\n"+routev6
> + else:
> + route = routev6
> +
> rt_info = route.split()
> for i in range(len(rt_info) - 1):
> if rt_info[i] == "dev":
> @@ -654,3 +666,4 @@
>
>
> Yaron Illouz
>
Hi Yaron,
Thanks for your patch. Please see DPDK contribution guidelines[1] [2] on
how to properly send patches to DPDK community.
In short, the following three things will need to be fixed before we are
able to consider this patch for inclusion into DPDK codebase:
1) We will need developer certification of origin (a Sign-off) before we
can accept any code into DPDK
2) Patch will have to be properly formatted using git-format-patch and
preferably sent via git-send-email
3) Patch will have to have a descriptive commit message
[1] https://www.dpdk.org/contribute/
[2] https://doc.dpdk.org/guides/contributing/patches.html
--
Thanks,
Anatoly
prev parent reply other threads:[~2018-06-25 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 14:51 Yaron Illouz
2018-06-25 9:19 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e52a1e9-069d-124b-fd37-ea4c1bf2ef80@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=yaroni@radcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).