[dpdk-dev] patch for dpdk-devbind.py support ipv6

[dpdk-dev] patch for dpdk-devbind.py support ipv6

[Yaron Illouz]

Hi

dpdk-devbind.py support only ipv4 interface, when run with -s parameter which is  status, it display all ipv6 interface as non Active
It set interface as Active according to "ip -o route" output
Here is a change that can support ipv6

@@ -269,6 +269,18 @@
     # filter out all lines for 169.254 routes
     route = "\n".join(filter(lambda ln: not ln.startswith("169.254"),
                              route.decode().splitlines()))
+
+    routev6 = check_output(["ip", "-6", "-o", "route"])
+    # filter out all lines for 169.254 routes
+    routev6 = "\n".join(filter(lambda ln: not ln.startswith("unreachable") and not ln.startswith("fe80::/64"),
+                             routev6.decode().splitlines()))
+
+    if len(routev6):
+        if len(route):
+            route = route+"\n"+routev6
+        else:
+            route = routev6
+
     rt_info = route.split()
     for i in range(len(rt_info) - 1):
         if rt_info[i] == "dev":
@@ -654,3 +666,4 @@


Yaron Illouz

Re: [dpdk-dev] patch for dpdk-devbind.py support ipv6

[Burakov, Anatoly]

On 21-Jun-18 3:51 PM, Yaron Illouz wrote:
> Hi
> 
> dpdk-devbind.py support only ipv4 interface, when run with -s parameter which is  status, it display all ipv6 interface as non Active
> It set interface as Active according to "ip -o route" output
> Here is a change that can support ipv6
> 
> @@ -269,6 +269,18 @@
>       # filter out all lines for 169.254 routes
>       route = "\n".join(filter(lambda ln: not ln.startswith("169.254"),
>                                route.decode().splitlines()))
> +
> +    routev6 = check_output(["ip", "-6", "-o", "route"])
> +    # filter out all lines for 169.254 routes
> +    routev6 = "\n".join(filter(lambda ln: not ln.startswith("unreachable") and not ln.startswith("fe80::/64"),
> +                             routev6.decode().splitlines()))
> +
> +    if len(routev6):
> +        if len(route):
> +            route = route+"\n"+routev6
> +        else:
> +            route = routev6
> +
>       rt_info = route.split()
>       for i in range(len(rt_info) - 1):
>           if rt_info[i] == "dev":
> @@ -654,3 +666,4 @@
> 
> 
> Yaron Illouz
> 

Hi Yaron,

Thanks for your patch. Please see DPDK contribution guidelines[1] [2] on 
how to properly send patches to DPDK community.

In short, the following three things will need to be fixed before we are 
able to consider this patch for inclusion into DPDK codebase:

1) We will need developer certification of origin (a Sign-off) before we 
can accept any code into DPDK
2) Patch will have to be properly formatted using git-format-patch and 
preferably sent via git-send-email
3) Patch will have to have a descriptive commit message

[1] https://www.dpdk.org/contribute/
[2] https://doc.dpdk.org/guides/contributing/patches.html

-- 
Thanks,
Anatoly