From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 114572F7D for ; Mon, 25 Jun 2018 11:19:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2018 02:19:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,269,1526367600"; d="scan'208";a="240021065" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.28]) ([10.237.220.28]) by fmsmga005.fm.intel.com with ESMTP; 25 Jun 2018 02:19:13 -0700 To: Yaron Illouz , "dev@dpdk.org" References: From: "Burakov, Anatoly" Message-ID: <3e52a1e9-069d-124b-fd37-ea4c1bf2ef80@intel.com> Date: Mon, 25 Jun 2018 10:19:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] patch for dpdk-devbind.py support ipv6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 09:19:15 -0000 On 21-Jun-18 3:51 PM, Yaron Illouz wrote: > Hi > > dpdk-devbind.py support only ipv4 interface, when run with -s parameter which is status, it display all ipv6 interface as non Active > It set interface as Active according to "ip -o route" output > Here is a change that can support ipv6 > > @@ -269,6 +269,18 @@ > # filter out all lines for 169.254 routes > route = "\n".join(filter(lambda ln: not ln.startswith("169.254"), > route.decode().splitlines())) > + > + routev6 = check_output(["ip", "-6", "-o", "route"]) > + # filter out all lines for 169.254 routes > + routev6 = "\n".join(filter(lambda ln: not ln.startswith("unreachable") and not ln.startswith("fe80::/64"), > + routev6.decode().splitlines())) > + > + if len(routev6): > + if len(route): > + route = route+"\n"+routev6 > + else: > + route = routev6 > + > rt_info = route.split() > for i in range(len(rt_info) - 1): > if rt_info[i] == "dev": > @@ -654,3 +666,4 @@ > > > Yaron Illouz > Hi Yaron, Thanks for your patch. Please see DPDK contribution guidelines[1] [2] on how to properly send patches to DPDK community. In short, the following three things will need to be fixed before we are able to consider this patch for inclusion into DPDK codebase: 1) We will need developer certification of origin (a Sign-off) before we can accept any code into DPDK 2) Patch will have to be properly formatted using git-format-patch and preferably sent via git-send-email 3) Patch will have to have a descriptive commit message [1] https://www.dpdk.org/contribute/ [2] https://doc.dpdk.org/guides/contributing/patches.html -- Thanks, Anatoly