From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2659EA0A0C; Thu, 15 Jul 2021 11:06:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AA574014D; Thu, 15 Jul 2021 11:06:55 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 1913240143 for ; Thu, 15 Jul 2021 11:06:52 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10045"; a="197773927" X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="197773927" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2021 02:06:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="652727590" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 15 Jul 2021 02:06:51 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 15 Jul 2021 02:06:51 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 15 Jul 2021 02:06:51 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 15 Jul 2021 02:06:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YoR+XYBAqGIwzEPHrhbieZ3N7GP3gO2+c7O3s9Vn+uJ6ha3yGOThprwUGQXkTt4mAPVFxA91FJyadQdnkyH0WlFoNDlGr1q9yDcgJLyKLvHYQZTkTBYVjxlXmenF+tmSfq5CUDyadQW2uSYkAfyLzeH7OKJiCzLJ0bMijvhHdLFduof/1zRgheX6ry7XIcRgKQrs52fz785tH69SAFx+5RiCSvP+vlXSDIAdF6ko5h7Kc3ActWpUyFc+WUFj5nKvSLySaMfTe1AwbBO0KG1YSUqoNphp+co6pnAFedIZKFnkv5LeyhqHhskqjJEUynsH6Avj/uLytOBPDIKqAd4FFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3eS5BzRbGjKGWEuXRbWtNg9MDZHlbhL6qNis1HbWzgU=; b=OR/Y+XCuOoOYk6zq//3ZcUU6nBKDQGAFJo2m826aGAJCNO02EzhncRCK5///WxRd3xDQBsvo9wA01/Z0y4nG1ptGGMxULOTJIQMkMpUXSjaYKxUkDuoRw9K8qqhVmNVRirMUdNZ+AYcGXxEgNVMUAFIy0Na0JwUQ087M/BB9sI85aLynuD0pYDlJRt/oX5729yYW6QkYkgDDG0TMesD4hZvazDqro+pkqtq65I+jTKTvYm8s2Cv2wZJgZNJG0G5d9TRRwHnPXVXxhAI/BH22r87rs7iYtfOGkrPVbuvzxUfLnH/mXl07HF0/uq2xfmvyanGxvel+xPkEpSMVu4D0+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3eS5BzRbGjKGWEuXRbWtNg9MDZHlbhL6qNis1HbWzgU=; b=X5dLrWRp7dqRlRk44Yv8VG6jPl1ld/x3DBDHyWeag6nq9zQO/J/Hx0EVYa0ww+N+rXbTbhBHk03L3sKABFEqqR9Q9COwE/y2bVQQILJWJLK+BcQFm+icjLkc1Q5Vrp6EPim7ysJWSJ5P2g/jrqHj7IqNz70awWRAh3X/2UIVhSw= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4950.namprd11.prod.outlook.com (2603:10b6:510:33::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.23; Thu, 15 Jul 2021 09:06:48 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bde5:66de:e755:c5bb]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bde5:66de:e755:c5bb%4]) with mapi id 15.20.4331.021; Thu, 15 Jul 2021 09:06:48 +0000 To: Thomas Monjalon , Matan Azrad CC: "dev@dpdk.org" , Andrew Rybchenko References: <20210713131714.964500-1-thomas@monjalon.net> <2065780.Orf5z9Lfyc@thomas> <4457539.Pa9PMCDbyH@thomas> From: Ferruh Yigit X-User: ferruhy Message-ID: <3e53ea11-02c7-4137-917a-505ef0343740@intel.com> Date: Thu, 15 Jul 2021 11:06:42 +0200 In-Reply-To: <4457539.Pa9PMCDbyH@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR1P264CA0089.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3f::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by MR1P264CA0089.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Thu, 15 Jul 2021 09:06:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c8b158af-0885-41e6-5830-08d9476fe09f X-MS-TrafficTypeDiagnostic: PH0PR11MB4950: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L3oxZ1F2hUvB/QVK1UlcR1e3jVkPfgySKseRgt5IOvm02dpfhLIwoqLyzBU/dBvka8C3u4xuPNxSCJbIhTp5hYBFjhc3fJrLxgGkxostEc2INqEikjd4wHnw5Uc3aXuqBv/Pwp4/NIIW+pvfy3I2BFef5GCrVN1bs7iuETCBLbS0YC6IYHv4T4wqRwknwxKQ85fHNz9p9WC1Aal4/5N/3PpgyCL/I4IsiE5iRdRWBZS1kZpfkDhz9RFzFc2YTOgs7xf8XlcfHBJ8O+KuzcqKbaa3xQ590z+YpUO/Lcm45VLSmjjQwCESWbtQX76faxLgAURxtREvv1lQ0hlIvqbWeAVXNiO+oox8wZToYdbn2waBIBm+Y8zoDSrNlVVzgYZuURNr9WsgbcpSSdW7TuMk0FvLwzTepvJDYlhavBnt6f9Qbv5LAeB5iyBtpd9TSqFDNebNDx3iXOfbg2vX/zlCfeEXDkieb+oF9cDFNc1RqI74Btd/l0gWyJE6jxi78ZX4bKXcAj6T9KLoZT7pgOh9uaSpwPpjq+Ic9MXJ0jDMY9H0dYcBfkl8rgvm9xejsfEdgjTrCV/qJ4vgb/zlcC7ivSpEIU//msvkPZbV2IQGzKUFijHUTAkOiPfVbriTr9VzZP+PbuVbrNUuYwzVMqmBFzpK1+5wbjcZdz8P66tLuFVyRyVAn+6dn6xdYcvl6KSiYs3hKsRhkdOuTI9CRzrFNQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(31696002)(2616005)(44832011)(956004)(8676002)(4326008)(8936002)(6666004)(478600001)(86362001)(6486002)(66476007)(66556008)(5660300002)(26005)(83380400001)(53546011)(66946007)(54906003)(110136005)(2906002)(36756003)(316002)(31686004)(186003)(16576012)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czZ2MGpyVHNqdGd0TUE4enZ3U2JqR0VwS3dmUG44L2s1NHgrUVM4SUZHc3pR?= =?utf-8?B?b0RwM1N0ZWJkR1Q2M3I2YjU0eVRGUzVxeEhKMjFWRkRvbzJuZmlrUHlIcmZC?= =?utf-8?B?MmRDaGM2b1Jydno2a0cvdldDS1pkOHo5cm96M01YNy8ydWw4aVVObHNwNjlw?= =?utf-8?B?MEVja2pDMEpPV2lNMktZaHlRM25tWWJXVkZzaHJ2TGpMdS9KRXNtSEN2UU1R?= =?utf-8?B?T2FIT0JjRmFZK3YwZTd5VkhYbStIZnBoeE9IMjNSamZwRnhaTVQwSmRCOWR0?= =?utf-8?B?UEhiLzBKOWV4NzlaVVBpazF2RE1DcDZCVkZTTVEvd3FXNGluOFVvWmJGSjNI?= =?utf-8?B?N1g2TU5YV2NFdzQyZXU1MHdpUG00dStmRTBndGxvZVVKSnF5S1ZqWFZRWklr?= =?utf-8?B?N0MzdDBBZ0lZYy9naExWa3NGbEg1WWR3OC94ZDNsaW51UFpkQ0pLZk8zeDF5?= =?utf-8?B?cGZJbmlOT2tkNEF1Mm1meldENzRONnBCaTA0KzFTSlovOWZxOEdwVUlXNnNR?= =?utf-8?B?cUZyOVhMMmJGU3pGYzVyRHZtQTNVUk5rSzRxNWlqemNScDVvMkthTWlGSjJM?= =?utf-8?B?THVGNGhrSDU2aVRQaytnT1Jna3RkaXcxSVlnYTFjSnRiNGRDM2N0aFJXOGFM?= =?utf-8?B?R21BTVhNeDA5WDQ5SUVTelp3T0NuOHAwOGsyeGc2UVMwejFacGlDQXNteXp5?= =?utf-8?B?UFR1aSsrdyt5bHFpeTAyU3d5U0JubHNXeExDZFFlTUVPTElqRFRnc3BMYUVO?= =?utf-8?B?M0xla2czU0JsL1E2alh2TW4yVXBMQjlHajVuTVNWb0U0Z0ttR3lTcTlRT25y?= =?utf-8?B?NUNWWklyN2dWUnNpczBWRDhJV1NqcndqYXpaM0JsRDB2QmxVbnY4ZWxQV3Vp?= =?utf-8?B?QytTOGJkOU0xRXNldHkvTnplRlRMb1BZMEVNUkFSRWEzb2JqZHJkWGovZGpV?= =?utf-8?B?UHRWNEZNK3lsb2Y1V1gzQnJEL3czYThmZjlrTEk4YnB3aGNOcVZ4M1hSUkRk?= =?utf-8?B?QlIycnRaalhKQU85YmpMS2tIMFhKNHdJRkJmUTBxRlFCQVh6UnpWVEdRWnk2?= =?utf-8?B?a3QyeWZMaHE4NDljSzg3KzZ5bnJ4UXB4dDRTcW1PcjRpcTVUV3R1QWczM1Fy?= =?utf-8?B?MWpTOC9HcDBoT0g2K0VEcTZydDNRUitPOU9FUzNlV2pJY2RSNitMY1R4a3dq?= =?utf-8?B?TCtIZDZXWHB4elkxNEJxSXMrcHJBaWJWSzFvZitNWnFzcGo2WExjLzNPY0pk?= =?utf-8?B?RURUdGhrZTQ3a3ZhSlp5akc3ZUlra2VjR1ZxOElnYWpwcE5tSkF5dWt6WTk1?= =?utf-8?B?VlMvOEl3STNGWk9xemJBVE04dWh4OGhabDBIdVMwcG44dVZoTDVJV2krMXli?= =?utf-8?B?dk9abzlKNE5OQWkvS1F5N3NDZnZrdFlsdmdlZEhqQnAxSVluNDErd1JHRG1S?= =?utf-8?B?U1NjWmpMYmhMQzdibFNndEQyS2ppaC9BcE8vMmRsdng0emtYV1g2N0w0blYx?= =?utf-8?B?VHBhZjVnaGtzLzVXODFnMGdkRUxGbCtmSXlEdmZDTXg0R1NVa0VjS2pLci9x?= =?utf-8?B?ZExNd0JObnRnK0d1S1JXN251OWp4bjBoMndaWjBibEVUZUhPQ3V1QUJGbVdO?= =?utf-8?B?RzZLK0l6ellTTW1yK3ZNVjQyVytiWkozRFhndjlnai9kM1V4VHJGZFJscEhz?= =?utf-8?B?MDdGbFFUOEo4SVpWb3FsZ3cvSGpSYWhZdnc3eWUrdnRnaHVkNTlYWDM0UlFt?= =?utf-8?Q?qAVlapWBm3g9JJ2L9jTG1eFLCzIL+PqlDTdIFT1?= X-MS-Exchange-CrossTenant-Network-Message-Id: c8b158af-0885-41e6-5830-08d9476fe09f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2021 09:06:48.6251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NyzcgPdsqq9Skhlu0e0XV59ogtZQ7mBnjcP1l55Unb7X6vsQKLKE0RB9+0ZxoI7LxUq9bvWrpslWeVlm5ngotw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4950 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/14/2021 4:42 PM, Thomas Monjalon wrote: > 14/07/2021 16:16, Matan Azrad: >> From: Thomas Monjalon >>> 13/07/2021 15:42, Matan Azrad: >>>> From: Thomas Monjalon >>>>> When registering a new event callback, if allocation fails, there is >>>>> no need for unregistering the callback, because it is not registered. >>>>> >>>>> Fixes: 9ec0b3869d8d ("ethdev: allow event registration for all >>>>> ports") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Thomas Monjalon >>>>> --- >>>>> --- a/lib/ethdev/rte_ethdev.c >>>>> +++ b/lib/ethdev/rte_ethdev.c >>>>> @@ -4649,8 +4649,6 @@ rte_eth_dev_callback_register(uint16_t >>>>> } else { >>>>> rte_spinlock_unlock(ð_dev_cb_lock); >>>>> - rte_eth_dev_callback_unregister(port_id, event, >>>>> - cb_fn, cb_arg); >>>> >>>> Please pay attention to the case of port_id=RTE_ETH_ALL where the user >>> wants to register the event for all the ports. >>>> >>>> In this case, when a failure happens for one of the ports, this unregister call >>> cleans the callback from all the ports. >>> >>> Yes I missed it. Now I better understand the intent, thanks. >>> >>> Next question: do we really want to rollback already registered ports? >>> Anyway, if we are out of memory, I think it is better not doing more >>> operations. >>> There can be various opinions on this topic, please give yours. >> >> Sure, >> I understand that memory error is serious, >> Do you think it is a fatal error? If so, maybe we should use rte_exit? > > We don't call rte_exit in the lib, so the app can do whatever it wants. > +1 >> That way or others, I think the behavior should be a convention for all the file functions(at least). > > What do you mean "all the file functions"? > >> I tend to do cleanup on any error. > > I would like to hear opinions from others as well. > I also tend to do the cleanup, since API returns error I think application will be right to think that no callback registered, partially registered callbacks on error can be confusing.