From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89DC6A0351; Mon, 10 Jan 2022 09:15:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0235C411EB; Mon, 10 Jan 2022 09:15:47 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id A4C444013F; Mon, 10 Jan 2022 09:15:45 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 209NxZcH006780; Mon, 10 Jan 2022 00:15:44 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pfpt0220; bh=32s3Pa/G6BjVw7jGPUVvw/9HV5K4LOlRqlxIeTPbxC8=; b=gdmYKeMFyNAu3lEqlW8aRHg2GpVErVqczZ2VHnmilVIvZEmRXvtVTqOUm5kGSvotk0KA gI7fvk1xFLj0vNwvuevoFxF2z4JIidQjzYoeR4mvHwOGKGcDHrd7RM8iCPOrx2DXGOhq lhwS6LaLwDp0D0p4YqLK13/zBg9EUjADztBm5vHrk6FJp1bCu+tIIbaluBfdAhOeVrKk 4GlOH5c5wpNayfmh1g9BNe7cGdqOKfsG7T7nmsBYybIY8qvqAIzlNZtt6TD4pJd26mHS MpNM4MKe+0jo7osEwJIOkdo2NSZNvWVmWpuzL74+1RSkU8EL34tPAitWGgUiCxV5lF4m EQ== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3dg7nksgmp-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 10 Jan 2022 00:15:44 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 10 Jan 2022 00:15:42 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Mon, 10 Jan 2022 00:15:42 -0800 Received: from [10.193.32.69] (unknown [10.193.32.69]) by maili.marvell.com (Postfix) with ESMTP id A0DD85C690C; Mon, 10 Jan 2022 00:15:26 -0800 (PST) Message-ID: <3e8af38a-ded1-ebc1-8516-c497795c1715@marvell.com> Date: Mon, 10 Jan 2022 09:15:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Subject: Re: [EXT] Re: [PATCH v1 1/1] net/qede: fix redundant condition in debug code Content-Language: en-US To: Jerin Jacob , Anatoly Burakov CC: dpdk-dev , Rasesh Mody , "Devendra Singh Rawat" , dpdk stable References: <7105742b042a813a391466d6706bb809c1bd9569.1638291548.git.anatoly.burakov@intel.com> From: Igor Russkikh In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 7aNdxfE9zkMx1s_q5FoikY8KWZYNxc6k X-Proofpoint-ORIG-GUID: 7aNdxfE9zkMx1s_q5FoikY8KWZYNxc6k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-10_03,2022-01-07_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Tue, Nov 30, 2021 at 10:29 PM Anatoly Burakov > wrote: >> >> Expression "a && 1" is equivalent to just "a", so fix the accidental >> inclusion of a literal in code. >> >> Cc: stable@dpdk.org >> >> Fixes: ec55c118792b ("net/qede: add infrastructure for debug data >> collection") >> Cc: rmody@marvell.com > > Hi @Rasesh Mody @Devendra Singh Rawat @Igor Russkikh > > Please review this patch to merge. > > >> >> Signed-off-by: Anatoly Burakov Reviewed-by: Igor Russkikh Thanks!