From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15931A0C41; Thu, 16 Sep 2021 12:24:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C828F40151; Thu, 16 Sep 2021 12:24:24 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 3D6F44003F for ; Thu, 16 Sep 2021 12:24:23 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="283530409" X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="283530409" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 03:24:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="651507129" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 16 Sep 2021 03:24:21 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 03:24:21 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 16 Sep 2021 03:24:21 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 16 Sep 2021 03:24:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WcQyZ4UBd4SUk6QCqs6TLf8juL9iTiCQa7tCru4XSL9r81BTlCXdDQ+IzoWJuLENhztRDkJm1hodtO8T8fRubnsjzve2bEz8qEslvv6IodwZIZWTqqDI6kQAi5tReFDZZtKG+OJsAEGPWJEMnHPaIerTqDtpXmgeU3lxfXLeoOUwULUOxrW5sQbmVxV0K5W5flJmbtBcAwDum/CG8V6NDCelxqvxU5htUlCvw+7vK840Sr05ACN1p1UVJH2tlMg2LwBzDebU3TUbqu4D6nonWYGF/4chVVUhpCwskYtLtjpCWcr/ujN9BnogvJ3CeeyyAbQd7nO344osiP1hKqx/rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+CCoLGg5RAi0RjRjBnz1DDI1N9dGfmhce++HcsPjQao=; b=FRk1oxlluRZqrtmpAh6nbRoOH7Z52agVdLSkTH+B+XGDZMh+EKLO97mDsmBd2SllhxeXD/aQrWvE8moLAYQ6fUfA0Ksxg77pR4R9LrS/6Dtkc3FciaoAusbVsCwVvdeUpLOB2kEa4qxOAAIjxg3tcmhjSyHKJPKIoaUqa1aDjCDhcbl2eX6agF78YN79NMIlEqzWrIrMbpms522rk/wJ+rq95akOja+RGkEFuKbvOAIBieO14h+WJJcaebimGeAVUu1xISIaJHplGL9r8KVtgnMPbv00YIScBiCeA91Ay4h5Bmt/eC+gFSnjNP5GVypkgNG+pHs4kzMoztVysX2u1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+CCoLGg5RAi0RjRjBnz1DDI1N9dGfmhce++HcsPjQao=; b=bDGXdMAvB5gIRPHKbrKK4fdDRaDCQSFEOhX5Jh87HRcshT0YlZ6ccfn+rDnFoVcHXG1ZYe4v0i7MxrfIImtzakjOGOPP2lRuG8F42aZWq6quK2Po4nv5wrnXnmy/Ei/hVrBBDc7gZvmVLrlRRKNVBvliTdoaNSpRxVMyvqGuSaI= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by CO1PR11MB5123.namprd11.prod.outlook.com (2603:10b6:303:94::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Thu, 16 Sep 2021 10:24:19 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::4dcc:489e:1d86:47cb]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::4dcc:489e:1d86:47cb%9]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 10:24:18 +0000 To: Anoob Joseph CC: "dev@dpdk.org" , "declan.doherty@intel.com" , "hemant.agrawal@oss.nxp.com" , Akhil Goyal , "Ananyev, Konstantin" References: <20210903112257.303961-1-radu.nicolau@intel.com> <20210915134522.1311843-1-radu.nicolau@intel.com> <20210915134522.1311843-5-radu.nicolau@intel.com> From: "Nicolau, Radu" Message-ID: <3eade32e-42ad-b192-629c-3c6c536d4d6b@intel.com> Date: Thu, 16 Sep 2021 11:24:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: DB6P18901CA0022.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::32) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 Received: from [192.168.1.12] (109.255.186.106) by DB6P18901CA0022.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 10:24:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c56b48a6-3419-4b2e-9599-08d978fc244e X-MS-TrafficTypeDiagnostic: CO1PR11MB5123: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:201; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tXy99DD20eDEaIT8YdRg1M2sX7ZBCHhvfxXLv/EGaQVhHWT6A0onSuWjCF6fc3yBiGL7QM5h1qGrWWWC/7r8vppkwVJ04+8NXuOhDm0hk1PWRt++E2kFcO04Ar8+PI3XGVkxaXNveml4k6+i51gxVgUdTcUIQYU9E4p6ikQcDpFT1kxiPVrWKPPk3qOsIhyrpI20It3CHPETOc7i+0noKQG6Pe5AB9CSHueIKx5X4XFyNihJ7CHFJZHhifbXcZlpzdTyVKvqbsq8dF62gEaAL0fOIiaeouhQ1eTjX2pqIhHcnHTliNDsI7tbNSLATHinNSP1YtUqu0NDhMR/SYjaPuIdexbRl6iqdke4r3YPr8ERH433axPqtAb4lAm+xyGiDr9hcCKbw1ebNESRyU1DWTi8X4jXkkyRS8JhrF8xteavIbEpEAes6W9X16oQo6xHVQFldipH4zji1OCsP0yyATQJ990C+Etx23J2ab3R/OGtNNHnjiaF+p49xr/cWnJwkj3kMTOsylw3wpDxhfkehOUDJsS5+3dVjeFbgs4njqN2CrolYH7fsXv7dC661An+tdrxQGOST90XHm3hn/Kmt4UfFtWkoFmQvF7X+PrEdYFDYdeoJi1LI8RvQGu9x1YSommsQroBdo+KgiQFyPD0Y0mMFsmxGCNB047KFzV6czwGlQb2T0e19bUrDnoJwkYgIkk/9vWlMCPrV4EIhq+c39Pg4+FTrUSGG1jr+mXeaJQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(956004)(66556008)(2616005)(4326008)(36756003)(26005)(8936002)(16576012)(66476007)(66946007)(31686004)(55236004)(53546011)(508600001)(38100700002)(6666004)(186003)(83380400001)(8676002)(86362001)(316002)(5660300002)(31696002)(107886003)(6916009)(54906003)(2906002)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djJPOTUxdE5JWGNvQkdaQXFHOFZjbDFQRUdGbWU5SklJVXYzYUw0TWY0VFdO?= =?utf-8?B?NUZ2RDBxR005THBETnVZQUt3bWE2cGJzb0ZNZjVkVm9CaElURWdqYWVsS3NK?= =?utf-8?B?OCs1Tk5xa1ltZ1VBdXhwMTRFQzJwOGFzTEFDZ3lxR3ExdWl2YTdVM0lyVGNn?= =?utf-8?B?YXpMbGpwNmlRNmxhR1h3a29DVmNoUk1Ed3pIdEJNVGpBb3J5MFljejVhRTNZ?= =?utf-8?B?MEtxYUxueVVReWxoaFd6NDRrdjNFbFpacmNOWFpCQmZQcEdmYXZmVldxdFN3?= =?utf-8?B?MXFLMW4vZnBQYzQxbkduYkZSRk1iUDk5RHFldHFNMmpoZHlhTlV0K3V1cG54?= =?utf-8?B?SmpUa2NWdGF1ZEd6KytuSTdTYjVVaFA2c0dCMDNTWitBM293ZUM0WlhNeW1s?= =?utf-8?B?NmJOVjdUTjhGL0xzdFh5R0dBUE1HUDBlT2xpbWNOM096S0IzbDBqWmg3ekE1?= =?utf-8?B?TUdOUElTN1hHSWFybWR3dmN6S1NmMDZaSVlkb2V4YjRnZmNnb1ZoYk5XNExN?= =?utf-8?B?N0ZUclg4V1M4YmpLYjlOMmp5dEdhL3ZaMXVXZmlEMXFxZ0RxUEMrNVNBTnNo?= =?utf-8?B?THAwUXNvY3MwMW9KMFRta3lDWFhqb29NME1adG9KbjRUdU9zWjd6K1Z1U1RP?= =?utf-8?B?VVpoekdUTHBLZlRnbkR5ejhEU1NuWkQ0YVI1endaR0ZqbUF6OWJqOXRyaVN6?= =?utf-8?B?RG5SMElCZWpjZ01BQUpnVEhQWS9xRVdiZGt2TnZ4ejY5c0JsUmxPMlZlaU0w?= =?utf-8?B?NzRHM2l5V0llVGFjWkl6VjVFaW9DNDFjSkF3K0UxTVRCR2pZM3dsdnlUNm10?= =?utf-8?B?SmN0cklFSE16b1B1cXFiTGp4Qy9haENTc0pMUzlqeGVMUHVCMlE1TG0vazlP?= =?utf-8?B?QjhBRVpDaE1LcGJRanZaejZ6YXJCTHUwK2JGZkorbVI1VVBTellxSEtZNFJ0?= =?utf-8?B?U3lac3RNSkg1OW9kVGFvZE1JYStaYVByNHJGbGxpRWZHdDBweExHRUExdTN1?= =?utf-8?B?RThwNXpRTHBmNW1ZRzBKUExTZ1pmYWVsYSsyN1FVNmlKRHZhODRJcnZ0SjNu?= =?utf-8?B?dmpJMWZNVlZNL0llcHlqR2xFYVExeTRHQVpFeHJpK29ZaHJwYk5pOURhMmlW?= =?utf-8?B?Uy9HbTFOdDZhZmFhYThhL2pLQm9qVUo2MnZrc01XZGVwenBzRTh4amNLWWp3?= =?utf-8?B?OHRybk03dXppTUNmNWJJdlZvRWVFK2k2WXZaM3gwTTJmN3Y4T0U2WGkyYWto?= =?utf-8?B?R0trYmJQZ2llbE5hOXdhRjlCck1QS2xSdXg4Y0tIQVJWcjFpVEMxY1FBOE9Q?= =?utf-8?B?ZEpHS04vSXloMXI5WVpHLzZkS3ozM1paQjlUMC9BVExSWFVwWkxUMkszOHlE?= =?utf-8?B?VHZQcFNHcjdDeWVMMjdsUmlDb0wvVjExMzVrcE5EWG5jVXBta1NMYW5aQmpY?= =?utf-8?B?Y1VCYmpUR0VpTjhCVjhxaDdXQ3BFa1JVU0pIVW91N1F2OFN6cnlZa05NbVNx?= =?utf-8?B?bWY1dmNUWkRMVVE1dVVFaDhZVnJJdGpUZncrdXVPUHFBeDhFU1ZuM3gwN2k1?= =?utf-8?B?dHNvdGVJejg1S2NZRkRERk03K0FQaWhzZG1JSU1NUkxlU3JYemxSL1E5K3Bp?= =?utf-8?B?eTlnbXhoQ0sxeE5pejBISlFUalRDTG9Ed3lBODErcVc3VmE2WC9xRFc3U0xp?= =?utf-8?B?RWtTSHZKbVpIVE9hcG1ieFpIYmpieHZmUmpCUWJwZ3lISnFFVnpWcG9oVUJq?= =?utf-8?Q?gatbLn5a10y7QNlrcBv4TwC6UqRhF9R6QlkAdmK?= X-MS-Exchange-CrossTenant-Network-Message-Id: c56b48a6-3419-4b2e-9599-08d978fc244e X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 10:24:18.8505 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1n6SlEKSKkSQ8CIR3wWsM0HKLhJVaz0FdwNmonqdTQxQEi3M3lyRyCeDWhRxG3CmRPHVt+OWY+8xAPaIqIQymg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5123 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH v2 4/9] examples/ipsec-secgw: add stats interval argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, On 9/16/2021 10:30 AM, Anoob Joseph wrote: > Hi Radu, > > Making stats dynamic would have a perf cost. That was the reason it was introduced as a compile time option. Why do we need it changed? We changed it for two reasons, for a better UX and for the telemetry feature that is introduced with patch 3. > > Also, it looks like this patch is only disabling stats printing when timeout is 0. I don't see stats collection being conditional. Stats collection would also have perf impact, right? I don't think there is a measurable performance impact because these are per burst calls. Regards, Radu > > Thanks, > Anoob > >> -----Original Message----- >> From: dev On Behalf Of Radu Nicolau >> Sent: Wednesday, September 15, 2021 7:15 PM >> To: Radu Nicolau ; Akhil Goyal >> >> Cc: dev@dpdk.org; declan.doherty@intel.com; >> hemant.agrawal@oss.nxp.com >> Subject: [EXT] [dpdk-dev] [PATCH v2 4/9] examples/ipsec-secgw: add stats >> interval argument >> >> External Email >> >> ---------------------------------------------------------------------- >> Add -t for stats screen update interval, disabled by default. >> >> Signed-off-by: Radu Nicolau >> --- >> doc/guides/sample_app_ug/ipsec_secgw.rst | 5 ++++ >> examples/ipsec-secgw/ipsec-secgw.c | 29 ++++++++++++++++-------- >> examples/ipsec-secgw/ipsec-secgw.h | 15 ------------ >> 3 files changed, 25 insertions(+), 24 deletions(-) >> >> diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst >> b/doc/guides/sample_app_ug/ipsec_secgw.rst >> index 20bc1e6bc4..0d55e74022 100644 >> --- a/doc/guides/sample_app_ug/ipsec_secgw.rst >> +++ b/doc/guides/sample_app_ug/ipsec_secgw.rst >> @@ -127,6 +127,7 @@ The application has a number of command line >> options:: >> -p PORTMASK -P -u PORTMASK -j FRAMESIZE >> -l -w REPLAY_WINDOW_SIZE -e -a >> -c SAD_CACHE_SIZE >> + -t STATISTICS_INTERVAL >> -s NUMBER_OF_MBUFS_IN_PACKET_POOL >> -f CONFIG_FILE_PATH >> --config (port,queue,lcore)[,(port,queue,lcore)] >> @@ -176,6 +177,10 @@ Where: >> Zero value disables cache. >> Default value: 128. >> >> +* ``-t``: specifies the statistics screen update interval. If set to zero or >> + omitted statistics screen is disabled. >> + Default value: 0. >> + >> * ``-s``: sets number of mbufs in packet pool, if not provided number of >> mbufs >> will be calculated based on number of cores, eth ports and crypto queues. >> >> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- >> secgw/ipsec-secgw.c >> index 265fff4bef..60b25be872 100644 >> --- a/examples/ipsec-secgw/ipsec-secgw.c >> +++ b/examples/ipsec-secgw/ipsec-secgw.c >> @@ -181,6 +181,7 @@ static uint32_t frag_tbl_sz; static uint32_t >> frame_buf_size = RTE_MBUF_DEFAULT_BUF_SIZE; static uint32_t mtu_size >> = RTE_ETHER_MTU; static uint64_t frag_ttl_ns = MAX_FRAG_TTL_NS; >> +static uint32_t stats_interval; >> >> /* application wide librte_ipsec/SA parameters */ struct app_sa_prm >> app_sa_prm = { @@ -292,7 +293,6 @@ adjust_ipv6_pktlen(struct rte_mbuf >> *m, const struct rte_ipv6_hdr *iph, >> } >> } >> >> -#if (STATS_INTERVAL > 0) >> >> /* Print out statistics on packet distribution */ static void @@ -352,9 +352,8 >> @@ print_stats_cb(__rte_unused void *param) >> total_packets_dropped); >> >> printf("\n============================================= >> =======\n"); >> >> - rte_eal_alarm_set(STATS_INTERVAL * US_PER_S, print_stats_cb, >> NULL); >> + rte_eal_alarm_set(stats_interval * US_PER_S, print_stats_cb, NULL); >> } >> -#endif /* STATS_INTERVAL */ >> >> static inline void >> prepare_one_packet(struct rte_mbuf *pkt, struct ipsec_traffic *t) @@ - >> 1435,6 +1434,7 @@ print_usage(const char *prgname) >> " [-e]" >> " [-a]" >> " [-c]" >> + " [-t STATS_INTERVAL]" >> " [-s NUMBER_OF_MBUFS_IN_PKT_POOL]" >> " -f CONFIG_FILE" >> " --config (port,queue,lcore)[,(port,queue,lcore)]" >> @@ -1459,6 +1459,8 @@ print_usage(const char *prgname) >> " -a enables SA SQN atomic behaviour\n" >> " -c specifies inbound SAD cache size,\n" >> " zero value disables the cache (default value: 128)\n" >> + " -t specifies statistics screen update interval,\n" >> + " zero disables statistics screen (default value: 0)\n" >> " -s number of mbufs in packet pool, if not specified >> number\n" >> " of mbufs will be calculated based on number of cores,\n" >> " ports and crypto queues\n" >> @@ -1666,7 +1668,7 @@ parse_args(int32_t argc, char **argv, struct >> eh_conf *eh_conf) >> >> argvopt = argv; >> >> - while ((opt = getopt_long(argc, argvopt, "aelp:Pu:f:j:w:c:s:", >> + while ((opt = getopt_long(argc, argvopt, "aelp:Pu:f:j:w:c:t:s:", >> lgopts, &option_index)) != EOF) { >> >> switch (opt) { >> @@ -1747,6 +1749,15 @@ parse_args(int32_t argc, char **argv, struct >> eh_conf *eh_conf) >> } >> app_sa_prm.cache_sz = ret; >> break; >> + case 't': >> + ret = parse_decimal(optarg); >> + if (ret < 0) { >> + printf("Invalid interval value: %s\n", optarg); >> + print_usage(prgname); >> + return -1; >> + } >> + stats_interval = ret; >> + break; >> case CMD_LINE_OPT_CONFIG_NUM: >> ret = parse_config(optarg); >> if (ret) { >> @@ -3350,11 +3361,11 @@ main(int32_t argc, char **argv) >> >> check_all_ports_link_status(enabled_port_mask); >> >> -#if (STATS_INTERVAL > 0) >> - rte_eal_alarm_set(STATS_INTERVAL * US_PER_S, print_stats_cb, >> NULL); >> -#else >> - RTE_LOG(INFO, IPSEC, "Stats display disabled\n"); >> -#endif /* STATS_INTERVAL */ >> + if (stats_interval > 0) >> + rte_eal_alarm_set(stats_interval * US_PER_S, >> + print_stats_cb, NULL); >> + else >> + RTE_LOG(INFO, IPSEC, "Stats display disabled\n"); >> >> /* launch per-lcore init on every lcore */ >> rte_eal_mp_remote_launch(ipsec_launch_one_lcore, eh_conf, >> CALL_MAIN); diff --git a/examples/ipsec-secgw/ipsec-secgw.h >> b/examples/ipsec-secgw/ipsec-secgw.h >> index f3082a1037..de9f382742 100644 >> --- a/examples/ipsec-secgw/ipsec-secgw.h >> +++ b/examples/ipsec-secgw/ipsec-secgw.h >> @@ -6,9 +6,6 @@ >> >> #include >> >> -#ifndef STATS_INTERVAL >> -#define STATS_INTERVAL 0 >> -#endif >> >> #define NB_SOCKETS 4 >> >> @@ -144,38 +141,26 @@ is_unprotected_port(uint16_t port_id) static inline >> void core_stats_update_rx(int n) { -#if (STATS_INTERVAL > 0) >> int lcore_id = rte_lcore_id(); >> core_statistics[lcore_id].rx += n; >> core_statistics[lcore_id].rx_call++; >> if (n == MAX_PKT_BURST) >> core_statistics[lcore_id].burst_rx += n; -#else >> - RTE_SET_USED(n); >> -#endif /* STATS_INTERVAL */ >> } >> >> static inline void >> core_stats_update_tx(int n) >> { >> -#if (STATS_INTERVAL > 0) >> int lcore_id = rte_lcore_id(); >> core_statistics[lcore_id].tx += n; >> core_statistics[lcore_id].tx_call++; >> -#else >> - RTE_SET_USED(n); >> -#endif /* STATS_INTERVAL */ >> } >> >> static inline void >> core_stats_update_drop(int n) >> { >> -#if (STATS_INTERVAL > 0) >> int lcore_id = rte_lcore_id(); >> core_statistics[lcore_id].dropped += n; -#else >> - RTE_SET_USED(n); >> -#endif /* STATS_INTERVAL */ >> } >> >> /* helper routine to free bulk of packets */ >> -- >> 2.25.1