From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4DA4A0542; Wed, 5 Oct 2022 15:45:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4461A40694; Wed, 5 Oct 2022 15:45:03 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 8FFA140143 for ; Wed, 5 Oct 2022 15:45:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664977501; x=1696513501; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Q1I9Zm/8gMJNTlY6mPHfLZAcia2OLh0IO803OC4g7cc=; b=QRchsjqvODo/81Miq7TtPDZEAO7NTynkyNzKTaCyAuxdyJ92fe8HVB1H B91Gg41b8z6b+L7kF1jS8N53cIsqZIFg7g+Wb3XuDrrbbFChUw6L5tbWu E2G4AThnECBGpJGSDjgV/RT5kKn8P+wGOqzacTCIHO3y/TrDKT95uvU5a 57u4m+ZEcn/k7FpQclKEe47C3YxiUSV7X3RBzD7QJLR3JzDdqX11yfEKA G1HipK0FbA7Gw4hIzo98JjYwZdsqCshz9f6tPqIKdQM7DA0a6N0P61MSZ cgCOPtR4oIIOno6jKVwLGzKS1Ji+CxFZAKPcP+jzAGvkzyGKG6lJ0/fjz w==; X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="301878867" X-IronPort-AV: E=Sophos;i="5.95,159,1661842800"; d="scan'208";a="301878867" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2022 06:45:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="657508752" X-IronPort-AV: E=Sophos;i="5.95,159,1661842800"; d="scan'208";a="657508752" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 05 Oct 2022 06:44:59 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 5 Oct 2022 06:44:59 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 5 Oct 2022 06:44:58 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 5 Oct 2022 06:44:58 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 5 Oct 2022 06:44:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NDqKBBfoU7E79MZpmeZwBsAswOctolbACJtwI11VQ/o42fcIGJP0M98ZrjwRGM+En8B9ZEEeeu/plaac2Em03sqEtwscY/Oi5y5W4xzszD4O7m124ia+hbaZbG52mWvwevIok96Qop+0x0nZ3lJMKBU6k5cOKAQ2StIz7IJv85ZXSSpoVI8tFPRhyqaGHL/jsEwE7sON+aHCnQPTwtMilZExKydrh2q4NG3cM57Yf+JfQyUTwgtsXQ2QR85t2xlqbpOfHJbmxbWAKep2z/HWi9T2V3QX3TiKsEi2c+w4AfMPaMuZEAdQt1bj56ctdiEcbECNfC6v9sWLt7MN4c+0Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JrgBQ3szc2f7gVOMmAdRplJUduLVgX8mF2BYxInSthI=; b=RrZ3fzIp3Ey6Puz+IQ5ZR4b70W2prQkS6ev6KLSI/w1gR5F1XhmCRgWIRTvygzCjtF1FDiLhBunxe2rQ23FAoTp7148paJBH81i+dD/EA6J9AaO3I0QHn8pyAwfTIk24Q7Gw6S1qa+t26aMK9+1GmFcKmbqmoLe951PFPFbwhQ8o4Lb9MGtGg0VpFq1bQHTUxruw0n/rBKs/cX4Cbt1xP2u9JjGtRutZrId1ekF2DpY750pby+vU5nj1HmSXHHho0UhVShAhaaK50w8uzL1R5ShCBjbtJzduuPkoeuL+r1pe/YAlFP3poZePUXWlyQYOF5+IAxZfsa4DHUMcrYWV/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SJ0PR11MB5166.namprd11.prod.outlook.com (2603:10b6:a03:2d8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Wed, 5 Oct 2022 13:44:53 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%8]) with mapi id 15.20.5676.032; Wed, 5 Oct 2022 13:44:53 +0000 Message-ID: <3ec04d77-43e2-6eed-53b5-723ca5058911@intel.com> Date: Wed, 5 Oct 2022 14:44:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v7 0/4] Add lcore poll busyness telemetry Content-Language: en-US To: CC: , Bruce Richardson , =?UTF-8?Q?Morten_Br=c3=b8rup?= , =?UTF-8?Q?Mattias_R=c3=b6nnblom?= , Konstantin Ananyev , Conor Walsh , David Hunt , Nicolas Chautru , Fan Zhang , Ashish Gupta , "Akhil Goyal" , Chengwen Feng , "Ray Kinsella" , Thomas Monjalon , "Ferruh Yigit" , Andrew Rybchenko , Jerin Jacob , "Sachin Saxena" , Hemant Agrawal , Ori Kam , Honnappa Nagarahalli , , "David Marchand" References: <24c49429394294cfbf0d9c506b205029bac77c8b.1657890378.git.anatoly.burakov@intel.com> <20220914092929.1159773-1-kevin.laatz@intel.com> From: Kevin Laatz In-Reply-To: <20220914092929.1159773-1-kevin.laatz@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0035.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::22) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB5872:EE_|SJ0PR11MB5166:EE_ X-MS-Office365-Filtering-Correlation-Id: 272b2df7-48fd-4ff2-a4f9-08daa6d7c841 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: URVZfmG0A/DqpxAx1xcyVpOTwY/flMfu03v34v1/MYV0wKUv9AelWWBBNPssmYkaPqYMH9gTAeglq4EVJVhGWvFVR+6yVETbVixWnkDua0oPq8szbXjECEkKqgX8EC4zvY/9M7QEyW5XdlPOh8yjFlxlsMPXtSnyd8JK8lAXR4f4yR62DkUQf5ug+hcu3Cd9XNR79pYFG22sVtw/px9xJAiXwgebOF+nSVlMWFG/DmhpAH4hmT81JVxCQJt5JTkICcUQuBwdKVpyDEAPggL34CM5/dnqd2kd53NC5ES1D8PL23O7r+q/04IUj31YGgKBtpnDorycijluz022iiAugh8CfgCyJ1FtyVX966Z4swpHBevTTAXN0jvQ22iD0x8BL2She8ZHI/3AcBNquuawU9Z+wMVCpOWrbrhI98553Lyy8GqSP/V9/8kgGMjn6iSWtPK/WH3F6qFC/wMkNXC0qbACYVwLZVHedMzgXhntjZI80AxJWJO0f3LaCbY1343X8u4yWslF98ZuH0FwuCoTxjDEZQqLrTJMz2qx2dK1MZXg06XeK55pWNR26rUodcwUIb/R3jHJalTUjygxq60pyEyspaD9O1/sR7YATfMwh7ued7rQ8/kwIZHzW4CrTxEnMqGwzz2xLWSTu21FiOYnsw/7IfQy85S4seh5uAzkdTL01Xqn1PFm8HDZhSgnoRmXW/6pjcE4uUVJWg72Y4YhFqVJmAIYcR6aLDcm/iumajsnNZvm+fWFqY1nbNeAwsYyf8gQriGNCgAoNf6NdZ82+8ua7oU8nNKG2SK1p3A0/og= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(136003)(396003)(376002)(366004)(346002)(451199015)(6506007)(66476007)(66556008)(6512007)(6666004)(4326008)(2616005)(6916009)(53546011)(6486002)(316002)(478600001)(36756003)(8676002)(31696002)(86362001)(82960400001)(38100700002)(186003)(83380400001)(26005)(54906003)(66946007)(31686004)(7416002)(8936002)(2906002)(41300700001)(5660300002)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vkh3b2c3eWVlU2xhc3VWWERyNkRUVlQ1Q3ZVUzJ6RXZBaDBwOGxRWVBHNzI3?= =?utf-8?B?ejRpenMvclVXZ0ZzWDVaVmFCSVo5STZDc0VXZHNPYXI1cnRzNWtrWDRUS2Nv?= =?utf-8?B?KzBMaFN5aWNrRzQ0U0I4TW53OCtvSWJaM2tzNFhFY1VIQk1pK054Z2d3bERu?= =?utf-8?B?UXdtcUI5WVFSZUdJYW5yM0R3ckdLV0o3V2UxZjh2cXdVYXVMZGZuKzROOWx6?= =?utf-8?B?NkJpalh3cjVTRnk4WTlzVFBnMDhzdW5FdlMvckQ3eXNzMGVMWjFIK3BWOHAv?= =?utf-8?B?d1lZc0k2ZmdaQlE5ZW8rMDRDQi9NS2ttcE9JZTV5L0tKY0d5N29ZK3dCVXJG?= =?utf-8?B?VHVDQ09YdlJneFEvZXhwTG05L0pHN21mWmFXM3c0eUlGQlpaNi9IazZlaWtW?= =?utf-8?B?UUdCZVU4SHRuMHc3SWc2ZjZscTdVSHBqQjlTN1BDcTJ5SFcvUGR6NkN1cU16?= =?utf-8?B?SkoxeGN6T29qdTgrdUhOdmY1SFBLSDNUVHl1SGdHNjlNS0srZXR3cDVBbTdQ?= =?utf-8?B?WmJ0bTNzZmZhT3BJbzRreWNQTHRiWGdLSzArTVJvdHRFb2hCL0Z5dkNUWVRt?= =?utf-8?B?SThrTFB5aFU1RTJNZ0YzbmtyTnAyQ2s3SjFHaEo1clVOTFUwc0xuc0tDVmd0?= =?utf-8?B?cTZIOCtXSjZCVmYvZnBWamVoYlduVDNZd3JHOFIrZUF1MThlMlZBQUU2Tkoy?= =?utf-8?B?WUhDR0NBZURRdC9HSjFWMTllWUhqYkJKck40S0xXVzhPTzJiL3BmcjJHZXFm?= =?utf-8?B?cnF4Z2J2S3I1bTc5TjdJQ2NBakxuVWlVd2EyN1Ara0dqMktWczZLWG01ekdG?= =?utf-8?B?M3hkaXdvRXRNeGxQaTUyYXBCS1NJT2oxS29TdFZCZGs5ZVpTOTUvUkdHRFJL?= =?utf-8?B?TC9qKzhlQUF1c1NGVXQ5bktRNWZLd2R0enNSVHZwK3FWZGdCQnJEU0hwczBQ?= =?utf-8?B?cmFPMEV0SWw0djZCMjQ0bk1MVWw3QnR3Q2xFcTZybDFkTVI5cU54Q3QvdGwz?= =?utf-8?B?MndxdDJJVDYrRHFCR0RaTkVYLzVwQncrQldYMkRvWnFPV2Q0QTB3MHg2N1lW?= =?utf-8?B?b3diWDBFWnQwU2h6eVE1allUYlQyaWtmT0VISjVBK054aXRBWGMzbHViVitr?= =?utf-8?B?b012SjJsKzdEUGRRWmg4ZE9KNm9rR0Ric2pIS3Jac2Jsc3h3TUoxL05TSHZn?= =?utf-8?B?WDNybTI3dnNwVGF0NjFLL3R2dmM5cE9ncTc0blRKYS9MNkpKMmxJdEQwT3ho?= =?utf-8?B?SGFIcTdlSFcrZERza0t2Q2ZVT25SVzQ4eGRDVGtjZzJCQTEvOTYxVDBOTXhk?= =?utf-8?B?dFY2T24xdmtYd2FlN29jd1hSNGhVZVNiYytXNmxEQm9VUnRpeEo5Q0hOOXkz?= =?utf-8?B?TmRJS0pTckNzSjJDTXRId29CT0NsejFTQktXSk10MnJyeUhhVVRPNlVNa1RD?= =?utf-8?B?TVFPa3VhNDRwcE03Z29RMUx2QmdtL29jNzdlcUUvd3RGVjI4ckx4UkR1ZVIz?= =?utf-8?B?cDNTTVA1aTg0aGNqTE0vVDAyUjhmTENhZmRxOGdYWGx1SnNFVlg4SEhMbVNK?= =?utf-8?B?QjczejhYdXJPbjVVN3pvNVNvdW9QeWlqc2swTGE5aWZ6dGMzU0NseWtYT1VC?= =?utf-8?B?T0U2cTMrQitwbUQ4OHpCeGRJOEFpTzRDcFZvNHJBNHZud0pvM0ZBV2tsbUdR?= =?utf-8?B?eVhNQzhxQ0FQOWNIczdBT3cvRWFHVVNZbUdjQWlBWnpDVEFPVDVVc1Vjc2dZ?= =?utf-8?B?Qk9VVjJnRVkrMDRQeW5wT0wzVGVPK0FVWDNjNFFuY0xOZmZmVVc0WlZmVUc2?= =?utf-8?B?UHcxVzllVVg3KzBpSG9HdFh0UmlXZWxtVkxTUEkvaXVDMDhFZG5IUkxrOE9j?= =?utf-8?B?U1FCa3lqaGxkY1pMQTVENC8vWlNrendVYlRKZ2JMbHV1QXdVMXpXNlI4NVMr?= =?utf-8?B?RllLbDgzcllyTXJiNGdxeDNYZEsvbTR3aGpOYUJxV3BpR3RaUHdUVXJIbjYv?= =?utf-8?B?QzFaMU5PTlhmMUxzOWtKRm1DWm5WSjhiWFZCM0oxU2VFSlJyQmN5T05GRGZW?= =?utf-8?B?OEVVaTBRbVUwdUZiN2NMdDFxQlNWQkV1Q3p2cnhvMDAydGozMk1FMEwvY1cr?= =?utf-8?B?YThKQUZSbFl5U2M0VUhxTjhLSGt3d0tyY05XZFEvV3NxOG9YbzJIUUR3amEx?= =?utf-8?B?L1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 272b2df7-48fd-4ff2-a4f9-08daa6d7c841 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 13:44:53.7230 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aa8cLUQDwIlquGcRcnXgece9GGErbbvgrFKtUMfkbHVu4qheoXPC7OIydvFkBEG7xaLV/8SNh5rLokdqRangqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5166 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 14/09/2022 10:29, Kevin Laatz wrote: > Currently, there is no way to measure lcore polling busyness in a passive > way, without any modifications to the application. This patchset adds a new > EAL API that will be able to passively track core polling busyness. As part > of the set, new telemetry endpoints are added to read the generate metrics. > > --- > v7: > * Rename funcs, vars, files to include "poll" where missing. > > v6: > * Add API and perf unit tests > > v5: > * Fix Windows build > * Make lcore_telemetry_free() an internal interface > * Minor cleanup > > v4: > * Fix doc build > * Rename timestamp macro to RTE_LCORE_POLL_BUSYNESS_TIMESTAMP > * Make enable/disable read and write atomic > * Change rte_lcore_poll_busyness_enabled_set() param to bool > * Move mem alloc from enable/disable to init/cleanup > * Other minor fixes > > v3: > * Fix missing renaming to poll busyness > * Fix clang compilation > * Fix arm compilation > > v2: > * Use rte_get_tsc_hz() to adjust the telemetry period > * Rename to reflect polling busyness vs general busyness > * Fix segfault when calling telemetry timestamp from an unregistered > non-EAL thread. > * Minor cleanup > > Anatoly Burakov (2): > eal: add lcore poll busyness telemetry > eal: add cpuset lcore telemetry entries > > Kevin Laatz (2): > app/test: add unit tests for lcore poll busyness > doc: add howto guide for lcore poll busyness > > app/test/meson.build | 4 + > app/test/test_lcore_poll_busyness_api.c | 134 +++++++ > app/test/test_lcore_poll_busyness_perf.c | 72 ++++ > config/meson.build | 1 + > config/rte_config.h | 1 + > doc/guides/howto/index.rst | 1 + > doc/guides/howto/lcore_poll_busyness.rst | 93 +++++ > lib/bbdev/rte_bbdev.h | 17 +- > lib/compressdev/rte_compressdev.c | 2 + > lib/cryptodev/rte_cryptodev.h | 2 + > lib/distributor/rte_distributor.c | 21 +- > lib/distributor/rte_distributor_single.c | 14 +- > lib/dmadev/rte_dmadev.h | 15 +- > .../common/eal_common_lcore_poll_telemetry.c | 350 ++++++++++++++++++ > lib/eal/common/meson.build | 1 + > lib/eal/freebsd/eal.c | 1 + > lib/eal/include/rte_lcore.h | 85 ++++- > lib/eal/linux/eal.c | 1 + > lib/eal/meson.build | 3 + > lib/eal/version.map | 7 + > lib/ethdev/rte_ethdev.h | 2 + > lib/eventdev/rte_eventdev.h | 10 +- > lib/rawdev/rte_rawdev.c | 6 +- > lib/regexdev/rte_regexdev.h | 5 +- > lib/ring/rte_ring_elem_pvt.h | 1 + > meson_options.txt | 2 + > 26 files changed, 826 insertions(+), 25 deletions(-) > create mode 100644 app/test/test_lcore_poll_busyness_api.c > create mode 100644 app/test/test_lcore_poll_busyness_perf.c > create mode 100644 doc/guides/howto/lcore_poll_busyness.rst > create mode 100644 lib/eal/common/eal_common_lcore_poll_telemetry.c Based on the feedback in the discussions on this patchset, we have decided to revoke the submission of this patchset for the 22.11 release. We will re-evaluate the design with the aim to provide a more acceptable solution in a future release. --- Kevin