From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ktraynor@redhat.com>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 74DD87CA3
 for <dev@dpdk.org>; Fri, 27 Apr 2018 12:08:23 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id B89E2406C744;
 Fri, 27 Apr 2018 10:08:22 +0000 (UTC)
Received: from ktraynor.remote.csb (unknown [10.36.118.53])
 by smtp.corp.redhat.com (Postfix) with ESMTP id BEF242023227;
 Fri, 27 Apr 2018 10:08:20 +0000 (UTC)
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
 "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Doherty, Declan" <declan.doherty@intel.com>,
 jerin.jacob@caviumnetworks.com, Bruce Richardson
 <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 dev@dpdk.org
References: <1524608213-2080-1-git-send-email-arnon@qwilt.com>
 <1524608213-2080-2-git-send-email-arnon@qwilt.com>
 <07170182-8293-8347-b0ff-9a77885b637f@redhat.com>
 <CAKy9EB1B2ocxm=icH5pPx10BMA+TRk7hD=PMcGMDs_skrg3cDA@mail.gmail.com>
From: Kevin Traynor <ktraynor@redhat.com>
Organization: Red Hat
Message-ID: <3ece9b04-46d9-bf46-2e01-45be76af5047@redhat.com>
Date: Fri, 27 Apr 2018 11:08:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <CAKy9EB1B2ocxm=icH5pPx10BMA+TRk7hD=PMcGMDs_skrg3cDA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.5]); Fri, 27 Apr 2018 10:08:22 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]);
 Fri, 27 Apr 2018 10:08:22 +0000 (UTC) for IP:'10.11.54.4'
 DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'ktraynor@redhat.com' RCPT:''
Subject: Re: [dpdk-dev] [PATCH v7 01/11] crypto/dpaa: replace rte_panic
 instances in crypto/dpaa driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2018 10:08:23 -0000

On 04/26/2018 10:28 PM, Arnon Warshavsky wrote:
> 
>     > -             if (cryptodev->data->dev_private == NULL)
>     > -                     rte_panic("Cannot allocate memzone for private "
>     > -                               "device data");
>     > +             if (cryptodev->data->dev_private == NULL) {
>     > +                     DPAA_SEC_ERR("%s() Cannot allocate memzone for private device data",
>     > +                     __func__);
>     > +                     return -ENOMEM;
> 
>     I'm not familiar with the code but there was a successful allocate
>     already, so it seems you should jump to the cleanup section at the end
>     of the function before returning.
> 
> Hi Kevin,
> The purpose of this patchset is not to offer a recoverable alternative
> for panic,
> rather allow the process to abort in an orderly manner.
> It does not cover in this version all the panic instances on the init
> sequence.
> Other than in places where it seemed straight forward I tend not to
> perform in this patchset
> partial resource release where panic was before.
> 

Ok, I understand the intention better now.

> Thanks
> /Arnon
> 
> 
>