From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10FD0A0C40; Thu, 5 Aug 2021 15:15:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAF5641268; Thu, 5 Aug 2021 15:15:54 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 6C88040040 for ; Thu, 5 Aug 2021 15:15:52 +0200 (CEST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GgTXR26msz83fl; Thu, 5 Aug 2021 21:11:51 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 5 Aug 2021 21:15:43 +0800 Received: from [10.40.190.165] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 5 Aug 2021 21:15:43 +0800 To: Jerin Jacob CC: Thomas Monjalon , Ferruh Yigit , "Richardson, Bruce" , Jerin Jacob , Andrew Rybchenko , dpdk-dev , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Nipun Gupta , Hemant Agrawal , "Maxime Coquelin" , Honnappa Nagarahalli , David Marchand , Satananda Burla , Prasun Kapoor , "Ananyev, Konstantin" References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <1627990189-36531-1-git-send-email-fengchengwen@huawei.com> <1627990189-36531-6-git-send-email-fengchengwen@huawei.com> From: fengchengwen Message-ID: <3ed15ae7-7cbf-4b38-70f0-2105ef5af995@huawei.com> Date: Thu, 5 Aug 2021 21:15:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v13 5/6] doc: add DMA device library guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/8/3 22:55, Jerin Jacob wrote: > On Tue, Aug 3, 2021 at 5:03 PM Chengwen Feng wrote: >> >> This patch adds dmadev library guide. >> >> Signed-off-by: Chengwen Feng >> --- >> doc/guides/prog_guide/dmadev.rst | 126 +++++++++++++++ > > > doc build has following warning in my machine > > ninja: Entering directory `build' > [2789/2813] Generating html_guides with a custom command > /export/dpdk.org/doc/guides/prog_guide/dmadev.rst:24: WARNING: Figure > caption must be a paragraph or empty comment. will fix in v14 > > .. figure:: img/dmadev_i1.* > > The model of the DMA framework built on > > * The DMA controller could have multiple hardware DMA channels (aka. hardware > DMA queues), each hardware DMA channel should be represented by a dmadev. > * The dmadev could create multiple virtual DMA channels, each virtual DMA > channel represents a different transfer context. The DMA operation request > must be submitted to the virtual DMA channel. e.g. Application could create > virtual DMA channel 0 for memory-to-memory transfer scenario, and create > virtual DMA channel 1 for memory-to-device transfer scenario. > [2813/2813] Linking target app/dpdk-test-pipeline > >> new file mode 100644 >> index 0000000..b305beb >> --- /dev/null >> +++ b/doc/guides/prog_guide/img/dmadev_i1.svg > > why _i1 in the name? OK, maybe dmadev.svg is enough. > > >> @@ -0,0 +1,278 @@ >> + >> + > > You could add an SPDX license and your company copyright as well. > See other .svg files. OK > > > Rest looks good to me. > > >> + [snip] >> > . >