From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98DBEA04DC; Mon, 19 Oct 2020 05:03:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F1BD3BE57; Mon, 19 Oct 2020 05:03:45 +0200 (CEST) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id DCD9ABE55 for ; Mon, 19 Oct 2020 05:03:44 +0200 (CEST) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id AB73A29413A9B8A0F25C; Mon, 19 Oct 2020 11:03:40 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Mon, 19 Oct 2020 11:03:33 +0800 To: Ferruh Yigit , Thomas Monjalon , Andrew Rybchenko CC: , "Wei Hu (Xavier" References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <20201014022649.2165524-1-ferruh.yigit@intel.com> <0d8f6cf8-66e0-8754-f700-aa7dfbff9aba@intel.com> From: "Min Hu (Connor)" Message-ID: <3eff91b3-e175-3cad-a98e-5ddb39132672@huawei.com> Date: Mon, 19 Oct 2020 11:03:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <0d8f6cf8-66e0-8754-f700-aa7dfbff9aba@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2020/10/16 20:16, Ferruh Yigit 写道: > On 10/14/2020 3:26 AM, Ferruh Yigit wrote: >> Queue stats are stored in 'struct rte_eth_stats' as array and array size >> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. >> >> As a result of technical board discussion, decided to remove the queue >> statistics from 'struct rte_eth_stats' in the long term. >> >> Instead PMDs should represent the queue statistics via xstats, this >> gives more flexibility on the number of the queues supported. >> >> Currently queue stats in the xstats are filled by ethdev layer, using >> some basic stats, when queue stats removed from basic stats the >> responsibility to fill the relevant xstats will be pushed to the PMDs. >> >> During the switch period, temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' >> device flag is created. Initially all PMDs using xstats set this flag. >> The PMDs implemented queue stats in the xstats should clear the flag. >> >> When all PMDs switch to the xstats for the queue stats, queue stats >> related fields from 'struct rte_eth_stats' will be removed, as well as >> 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. >> Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be >> removed. >> >> Signed-off-by: Ferruh Yigit > > Hi Thomas, Andrew, > > What do you think having the patch for this release? > > > Connor, Xavier, > > Are you OK to superseded your existing patch [1] with this approach? > [1] https://patches.dpdk.org/patch/78886/ Hi, Ferruh, it is ok, we will continue the work with your solution. Thanks. > .