From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 649714C93 for ; Fri, 21 Sep 2018 01:55:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2018 16:55:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,282,1534834800"; d="scan'208";a="71681263" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.22.231]) ([10.252.22.231]) by fmsmga007.fm.intel.com with ESMTP; 20 Sep 2018 16:55:19 -0700 To: Xiao Wang , tiwei.bie@intel.com Cc: dev@dpdk.org, xiaolong.ye@intel.com, zhihong.wang@intel.com, Chao Zhu References: <20180910110123.138273-1-xiao.w.wang@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <3f10edab-be6d-9e48-d022-e569ae79adc7@intel.com> Date: Fri, 21 Sep 2018 00:55:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180910110123.138273-1-xiao.w.wang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/ifc: add live migration support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 23:55:23 -0000 On 9/10/2018 12:01 PM, Xiao Wang wrote: > IFCVF can help to log dirty page in live migration stage, > each queue's index can be read and configured to support > VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_VRING_BASE. > > Signed-off-by: Xiao Wang <...> > +static void > +ifcvf_used_ring_log(struct ifcvf_hw *hw, uint32_t queue, uint8_t *log_buf) > +{ > + uint32_t i, size; > + uint64_t pfn; > + > + pfn = hw->vring[queue].used / PAGE_SIZE; > + size = hw->vring[queue].size * sizeof(struct vring_used_elem) + > + sizeof(__virtio16) * 3; Getting a build error for PowerPC [1], can someone from PPC side confirm it please? [1] .../drivers/net/ifc/ifcvf_vdpa.c: In function ‘ifcvf_used_ring_log’: .../drivers/net/ifc/ifcvf_vdpa.c:288:11: error: ‘__virtio16’ undeclared (first use in this function) sizeof(__virtio16) * 3; ^~~~~~~~~~