From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F254EA00BE; Tue, 28 Apr 2020 16:06:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB6FF1D5E0; Tue, 28 Apr 2020 16:06:27 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 380161D5B6 for <dev@dpdk.org>; Tue, 28 Apr 2020 16:06:26 +0200 (CEST) IronPort-SDR: cEoVxo/RJ0uEmaHbWnweYTfbWGPJGAYFfQ0kaPijbRztVSumqEuko3wj/bHo6oCggo/Ukxrkz7 3w7hvnEhezfA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 07:06:25 -0700 IronPort-SDR: tYvnkG3fUx133GZlfDhSvY+VncDj5I5JYz9Vi3sXLJ54YrJD6X6uDua2sDCn6Ciqv1wLfW3FHE i3vGVbTT3N3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="275848600" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.243.142]) ([10.213.243.142]) by orsmga002.jf.intel.com with ESMTP; 28 Apr 2020 07:06:21 -0700 To: Jerin Jacob <jerinjacobk@gmail.com> Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, Nithin Dabilpuram <nithind1988@gmail.com>, "Singh, Jasvinder" <jasvinder.singh@intel.com>, Thomas Monjalon <thomas@monjalon.net>, Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>, "kkanas@marvell.com" <kkanas@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, "Kinsella, Ray" <ray.kinsella@intel.com>, Neil Horman <nhorman@tuxdriver.com>, Luca Boccassi <bluca@debian.org>, Kevin Traynor <ktraynor@redhat.com>, David Marchand <david.marchand@redhat.com>, Bruce Richardson <bruce.richardson@intel.com> References: <20200330160019.29674-1-ndabilpuram@marvell.com> <20200422172104.23099-1-nithind1988@gmail.com> <BYAPR11MB293504C79C2F3EBF9C4387D4EBD00@BYAPR11MB2935.namprd11.prod.outlook.com> <f278bf50-7cfa-f9b2-8d20-6ea5d5e81401@intel.com> <BYAPR11MB2935DC611ACE2CEF8238B040EBAF0@BYAPR11MB2935.namprd11.prod.outlook.com> <bd72bb76-62a2-46fb-244f-96527a439089@intel.com> <CALBAE1Mrs1cA_L8bwsK85RJq=h9Dd7nO5+f328XP5XJRtGKyOA@mail.gmail.com> <e83dfb22-7db0-26ff-5b39-cedd8106dcb4@intel.com> <CALBAE1Nd_i8SD0+F2Pz2Vci=Zg8D78mHFE5Aon2iYits-jPGMg@mail.gmail.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <3f14bb70-b963-437d-9451-ccee3b100915@intel.com> Date: Tue, 28 Apr 2020 15:06:20 +0100 MIME-Version: 1.0 In-Reply-To: <CALBAE1Nd_i8SD0+F2Pz2Vci=Zg8D78mHFE5Aon2iYits-jPGMg@mail.gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 4/27/2020 5:59 PM, Jerin Jacob wrote: > On Mon, Apr 27, 2020 at 10:19 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote: >> >> On 4/27/2020 5:29 PM, Jerin Jacob wrote: >>> On Mon, Apr 27, 2020 at 9:42 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote: >>>> >>>> On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote: >>>>> >>>>> >>>>>> -----Original Message----- >>>>>> From: Yigit, Ferruh <ferruh.yigit@intel.com> >>>>>> Sent: Saturday, April 25, 2020 9:09 PM >>>>>> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Nithin Dabilpuram >>>>>> <nithind1988@gmail.com>; Singh, Jasvinder <jasvinder.singh@intel.com>; >>>>>> Thomas Monjalon <thomas@monjalon.net>; Andrew Rybchenko >>>>>> <arybchenko@solarflare.com> >>>>>> Cc: dev@dpdk.org; jerinj@marvell.com; kkanas@marvell.com; Nithin >>>>>> Dabilpuram <ndabilpuram@marvell.com> >>>>>> Subject: Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt >>>>>> mode >>>>>> >>>>>> On 4/24/2020 11:28 AM, Dumitrescu, Cristian wrote: >>>>>>> >>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Nithin Dabilpuram <nithind1988@gmail.com> >>>>>>>> Sent: Wednesday, April 22, 2020 6:21 PM >>>>>>>> To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian >>>>>>>> <cristian.dumitrescu@intel.com>; Thomas Monjalon >>>>>>>> <thomas@monjalon.net>; Yigit, Ferruh <ferruh.yigit@intel.com>; Andrew >>>>>>>> Rybchenko <arybchenko@solarflare.com> >>>>>>>> Cc: dev@dpdk.org; jerinj@marvell.com; kkanas@marvell.com; Nithin >>>>>>>> Dabilpuram <ndabilpuram@marvell.com> >>>>>>>> Subject: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt >>>>>>>> mode >>>>>>>> >>>>>>>> From: Nithin Dabilpuram <ndabilpuram@marvell.com> >>>>>>>> >>>>>>>> Some NIC hardware support shaper to work in packet mode i.e >>>>>>>> shaping or ratelimiting traffic is in packets per second (PPS) as >>>>>>>> opposed to default bytes per second (BPS). Hence this patch >>>>>>>> adds support to configure shared or private shaper in packet mode, >>>>>>>> provide rate in PPS and add related tm capabilities in port/level/node >>>>>>>> capability structures. >>>>>>>> >>>>>>>> This patch also updates tm port/level/node capability structures with >>>>>>>> exiting features of scheduler wfq packet mode, scheduler wfq byte mode >>>>>>>> and private/shared shaper byte mode. >>>>>>>> >>>>>>>> SoftNIC PMD is also updated with new capabilities. >>>>>>>> >>>>>>>> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com> >>>>>>>> --- >>>>>>>> v3..v4: >>>>>>>> - Update text under packet_mode as per Cristian. >>>>>>>> - Update rte_eth_softnic_tm.c based on Jasvinder's comments. >>>>>>>> - Add error enum >>>>>> RTE_TM_ERROR_TYPE_SHAPER_PROFILE_PACKET_MODE >>>>>>>> - Fix shaper_profile_check() with packet mode check >>>>>>>> - Fix typo's >>>>>>>> >>>>>>> >>>>>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> >>>>>>> >>>>>> >>>>>> Hi Nithin, >>>>>> >>>>>> It looks like patch is causing ABI break, I am getting following warning [1], >>>>>> can you please check? >>>>>> >>>>>> [1] >>>>>> https://pastebin.com/XYNFg14u >>>>> >>>>> >>>>> Hi Ferruh, >>>>> >>>>> The RTE_TM API is marked as experimental, but it looks that this was not correctly marked when __rte_experimental ABI checker was introduced. >>>>> >>>>> It is marked as experimental at the top of the rte_tm.h, similarly to other APIs introduced around same time, but it was not correctly picked up by the ABI check procedure when later introduced, so __rte_experimental was not added to every function. >>>>> >>>> >>>> :( >>>> >>>> Is it time to mature them? >>>> >>>> As you said they are not marked as experimental both in header file (function >>>> declarations) and .map file. >>>> >>>> The problem is, they are not marked as experimental in DPDK_20.0 ABI (v19.11), >>>> so marking them as experimental now will break the ABI. Not sure what to do, >>>> cc'ed a few ABI related names for comment. >>>> >>>> For me, we need to proceed as the experimental tag removed and APIs become >>>> mature starting from v19.11, since this is what happened in practice, and remove >>>> a few existing being experimental references in the doxygen comments. >>> >>> I think, accidentally we can not make a library as NON-experimental. >>> TM never went through experimental to mature transition(see git log >>> lib/librte_ethdev/rte_tm.h) >>> It was a bug to not mark as experimental in each function in the ABI process. >>> Some of the features like packet marking are not even implemented by any HW. >>> I think, we can make API stable only all the features are implemented >>> by one or two HW. >> >> Fair enough, specially if the API is not ready yet. >> >> But they were part of stable ABI, and marking them as experimental now will >> break the old applications using these APIs. > > it is still marked as EXPERIMENTAL everywhere and API is not ready yet. Existing experimental marks are text only for human parsing. The compiler attribute and build time checks are missing, and the symbol in the binary doesn't have experimental tag. Our scripts and automated checks won't detect it as experimental. My point is just having experimental comment in header file is not enough to qualify the APIs as experimental. > Anyway, we need to break the ABI to make it work on various HW. > I am not sure what to do? > IMO, We need to send a patch as Fixes: for the bug of not adding > __rte_experimental in each function. Yes, this is where we are, both you and Cristian suggest API is not ready and should be experimental, but they were part of stable ABI, making them experimental will break the ABI. It looks like there is no good option but we should select one of the bad ones. > > Traffic Management API - EXPERIMENTAL > M: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > T: git://dpdk.org/next/dpdk-next-qos > F: lib/librte_ethdev/rte_tm* >> >>> >>>> >>>> Ray, Neil, David, Luca, Kevin, what do you think? >>