From: Kevin Laatz <kevin.laatz@intel.com>
To: "Volodymyr Fialko" <vfialko@marvell.com>,
dev@dpdk.org, "Bruce Richardson" <bruce.richardson@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Cc: <jerinj@marvell.com>
Subject: Re: [PATCH] bus: fix leak for devices without driver
Date: Wed, 8 Feb 2023 11:30:30 +0000 [thread overview]
Message-ID: <3f3e804a-0903-5090-b36d-1c915f7d30b4@intel.com> (raw)
In-Reply-To: <20230107151230.2539470-1-vfialko@marvell.com>
Hi Volodymyr,
On 07/01/2023 15:12, Volodymyr Fialko wrote:
> For devices not assigned to any driver, we leak a pci device object since
> it is never freed from the PCI bus device list, reported by ASAN.
>
> Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> ---
> drivers/bus/pci/pci_common.c | 3 ++-
> drivers/bus/vdev/vdev.c | 5 +++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
This fix LGTM, but its tricky to reproduce so I have not been able to
test this.
Could you add some more text to the commit message describing the issue
and fix, please?
/Kevin
next prev parent reply other threads:[~2023-02-08 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 15:12 Volodymyr Fialko
2023-02-07 13:48 ` David Marchand
2023-02-08 11:30 ` Kevin Laatz [this message]
2023-02-09 13:22 ` [PATCH v2] " Volodymyr Fialko
2023-02-10 9:28 ` Kevin Laatz
2023-02-10 11:55 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f3e804a-0903-5090-b36d-1c915f7d30b4@intel.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mb@smartsharesystems.com \
--cc=vfialko@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).