From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0525341C3F; Wed, 8 Feb 2023 12:31:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D50704014F; Wed, 8 Feb 2023 12:31:00 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id CA11240141 for ; Wed, 8 Feb 2023 12:30:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675855860; x=1707391860; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=7ZmvqBeyW4bnS4A2nBfEffub3IbDXrwai4JzxrOTCrs=; b=eT74d4BKE0IuUYry/VZLUTnVpNtj/iPLqVDAxfVak95LY3TYZX629vxu v3599Or/+n04qzVT+6vRLQ0riJ9LUu0YyUQ2xqN7418oUgMaq3zr5Bkk1 5RmTirAoV8I04sa9atcPH9KWO7xFKRoBjMn1bgu7W4MIolfOAkau3fLug sSEETIyVWhOPMgZTXZI31RU/i+Vpti3VLK9uYJ6pst/3ClS+dop0nZVfH mxZD71CZCiFX4JyYTwNwmFCiQQhuh2aCRWCQhP6H5QFUlejAiGnaYt40C LlvlRzXxujarVLXIheqHeRYx8VCW/bLoXlv2BmHIHPllTITlUO/m9+BAV Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="313413197" X-IronPort-AV: E=Sophos;i="5.97,280,1669104000"; d="scan'208";a="313413197" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 03:30:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="644830012" X-IronPort-AV: E=Sophos;i="5.97,280,1669104000"; d="scan'208";a="644830012" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 08 Feb 2023 03:30:39 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 8 Feb 2023 03:30:38 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 8 Feb 2023 03:30:38 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 8 Feb 2023 03:30:38 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 8 Feb 2023 03:30:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RPXIYSP/CbrNh6n4+iQCxPc6vwyIPWUKF0sJGyWWUiBEumkXcTpwcxDyNxrl7WLYQMOqeq0nLujgQxhhBdW4IlqBj0WtJxEYWrdtXf/0SDO7pzpilOUKokububGyB9G4z0CF0qWRwD70+/F9i7cyx7Ag/E/QJdOqKsnuWcxn+5zrRvhKKdy4hEpy4ftA9NO3Nln7qzZwhePMWO901rdi2Xm4JbpIYwjrjP3VB/y4M7+81Fw9tTYhvWIqk04MdmT0vMHJ6+7J+0BC7G8sHah7rOr+cVKhCCmkfD6UF4mUAPGlZNBaZ/kTaGFRchX+OuK7nCNDbHD5D3lHcQ8Ar/HhIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Un4T2cyl8ad+sVEUuwS/6H2swxVcePmXCWZoPgb7lI=; b=GGXEt3IJCTyLD1Yc2fl+Fjm91+wfk6ctyBOaDhlRf7zenw1iGDWqdD4eyLWjUATA8HfwJj2q62rV8IYOzmKibW5KsLGHTVvzT1Fk4tqslB6+eCwytm4ps+nqx8km06gPPbw0w21pQMoDqSNEzwFVeBs7ilqTUqvmWCZKv0QLIUJC5lrcs2L1TIrsMOq4A2QFeBJpf/L7k7p/4L90Af7cSlLB44LfeeBh8aAMqTEv8bkYBfZ+v0vncFb6iTaXNZ1fO2SPYhejpB2MOBfVwT9QOH96PbTEhoCu/MgR6oYyxSTh9FJoDNVklXA+PSvex1eNVDXs1/RRnF9yY5xniFsa5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SJ0PR11MB5868.namprd11.prod.outlook.com (2603:10b6:a03:42b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.29; Wed, 8 Feb 2023 11:30:36 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::96f4:ad8:3fb9:b60d]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::96f4:ad8:3fb9:b60d%7]) with mapi id 15.20.6064.032; Wed, 8 Feb 2023 11:30:36 +0000 Message-ID: <3f3e804a-0903-5090-b36d-1c915f7d30b4@intel.com> Date: Wed, 8 Feb 2023 11:30:30 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] bus: fix leak for devices without driver Content-Language: en-US To: Volodymyr Fialko , , Bruce Richardson , =?UTF-8?Q?Morten_Br=c3=b8rup?= CC: References: <20230107151230.2539470-1-vfialko@marvell.com> From: Kevin Laatz In-Reply-To: <20230107151230.2539470-1-vfialko@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0306.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::23) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB5872:EE_|SJ0PR11MB5868:EE_ X-MS-Office365-Filtering-Correlation-Id: e7bdfdb7-fa30-45e4-210b-08db09c7e555 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AySaMaaxBkEf7WDfR97HO5VcpQBtKdxb8Fw356MZONhYZOEU5ubXaVRaCgyp2UHED5nIafEKrQfpRETQtH71fTUg27TqrRDkqbltFRqVHpbeEu8BxqVX0lpS35+WLRRtDoebLk3A9kLvW0AbfrrKCLfe9iPxhCTk6bRz2UWAT/mVWDASkfiy2UuDdZso4NKkiDc+l+5gZFqzxChNy/PDojkxNMp6boRTFA3hTABiKvUMPabqvlTPEZH95ttnfxsbnbRfmfGIxigOorIZ1ex3LY5B6tWGAY4YhvQ/IVZAJZFFPlhTQmmb3koOEiI53yLXFu3zohAyxpSoyAY0B0aV9opcZCtYMy6Po/Ndz0Mhpb9aa5WJpcsVyBzGW2tC9ZWRRssHaVYepAu0vJ6E+ijSM4EjnZQHH4QiMxahuinoo1nKpu72+RZ2arTiWZXWyp1b2oBMhGgyDlzfzLYQEViSXn7GM94cloH4Q92bT729O9ZlcCOeRKAAsWh1qpfQIXoacxEOMTLB+bIN9xsh/1myabsqgpxtAr2+VmdROBVtbKDPJ1qUvMVju/b76gAhzdedP4lPwTVGr3C2EGVVfP5AqZlk/tZOzWTsu37De+tk4VTWbMmL0+TNqqtzacp/hW8sPrs8iWZgJpYBiNOqz893MIPqPwVTas8wVj/1do9I8ARCLWvi+P8bmWq8ebPy4cgDfXOdHRqNOUQDVc/zrw9IaRMPjwIIlgoqOThOjEYS0ao= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(39860400002)(136003)(346002)(366004)(376002)(451199018)(31686004)(66476007)(66556008)(6486002)(82960400001)(66946007)(41300700001)(316002)(478600001)(31696002)(110136005)(83380400001)(38100700002)(44832011)(4744005)(8676002)(186003)(2906002)(6512007)(86362001)(2616005)(26005)(8936002)(6666004)(5660300002)(53546011)(6506007)(36756003)(4326008)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dCs5ZS9hV2pvdmhVWk94UExQUm13eWt2RUFRdEJJWUZqRUw1WCtRNllHZUxB?= =?utf-8?B?Z0FRY25iUmZMODF0b0EvbmtWWVQ4b0Fta3diWFFWZHdHTlpMckViWlNLUTZU?= =?utf-8?B?SWludWpVR0lVSGd3eVgxYy9CUTdmTEdRTGRkRkZ4ajQ4SWRTZlYwYmtqQUtD?= =?utf-8?B?TXp6ZjZiSWJiMnBRVmtPQmVWdXFBNTNvZGFGUEg2eDZMc21zUklxeVFnamQx?= =?utf-8?B?WmFHUEwrMVJKV1lOd01qMkdNN0VTeUpGMEw5N3AvczRwZXBWcGxlWC9qOEpZ?= =?utf-8?B?MTQydXlYWFhXOEtpeXVHeEpOS0VDbHg5M3JyZHZyWmFOaGVTR29DUm1Pd2hp?= =?utf-8?B?SHBtQStyeVVoOHJVVlVMNDYyMEx6ZDBRZ1llcXpLWHBJOUVzZ2gvbHM3clZ6?= =?utf-8?B?NjUybk84bnc4UmRQQ3ZnbEVnTS9KaDRMdUNTZjJrT3V2WCtFM3E4NUR5TXEw?= =?utf-8?B?S2hWMW41bjRGS3NmR2RxKzVzN0FUNnZCRkZwZGYxd2xucVFWVUU0MTlzVWlD?= =?utf-8?B?NVJvOFlTM1lhbTBtbmhwSTFoVWluWFBxMjdOTkJlM3BLQmJJYUNYVlQzNXBE?= =?utf-8?B?QytBeStMQzRkS1pWZk9sUXc2RzJRdnI3aTFXOUxDWlkwdU5qL2htcWp1OVZn?= =?utf-8?B?Z3Fsd1MvT2lESWtON012dlJudFdvU05zY3YxUXNqd1hoUVhwYitSM1k4bmNT?= =?utf-8?B?SUV6dDZMamxjUllDM2xUUndmOURKakhuQzVNaTZ0Z2ZMeXllUm14UkVFRVBk?= =?utf-8?B?dGgvWDJGend2SHFpMzF3eFBySTYyWEVWL3l0MDNSeWcxWlhFQkJ3bEZ0T0ZU?= =?utf-8?B?SmZGTFRiLzlNNy9yOGtqZ3RSWmJDd3VRa2J3RnhMZ3RUcndqQXgrUEwvbXpJ?= =?utf-8?B?dUdsREdQaUpiWTlqZVJlNU9KZXh5YWJwWG84d1lNVWVKMzkzZ3MwOFVOcTky?= =?utf-8?B?OGMwOVVTbEtoajE0SzhDYlZBYWpJRXJvV3U3cVVsbDVsWTRvME9WRkdvWWNP?= =?utf-8?B?RWkyZVRNRTV0WVFJY2pZUk8xN2J0SzJRVkdoMGVxYWZQc053a2JaRitOS0NR?= =?utf-8?B?eENqVmtUQnRKdWw1bEk0bmNVRHFwQU5kNFlWdnBoZ0JjZGNFSnBYZVlPRkV5?= =?utf-8?B?bXc1SVNrMGVEVzQ2eG9qNXhLeCtJZjNNWnVuc2p0WFFIRFdic3dTdTJlRjNv?= =?utf-8?B?cHgxUU1ITUZuVEZjak9adTZSVnQ2bFRVQ3FhQlVFVC93MlU3MWE3MGZhWVBH?= =?utf-8?B?NFNzbVZFS0g2RWozTXE1NjEzSkRmV3NVclViMHpvbzVNdUZkTjVFYlc4TkVh?= =?utf-8?B?WUNCTGh1WmhzS1RiTElRTmh6T0J0dkk4aXNleHdnRGFQZlFmcm9qU2dXZHJr?= =?utf-8?B?aUpmUG53VFA0ZklaN0xTNFdOM3ZZOU0ram5JQjkvVStETHFobm1SOFJZQmpC?= =?utf-8?B?QU1Kc2F5ek9xeDdwWnU0RVc0N2dRZ0kycjZvZ2pXNFhaTjdGR3VmUmJKRTJC?= =?utf-8?B?ZndVQ2lMaEJQdkNGZ3FPcG5BVkxnU0xRVjlpMEFTSE13Y0lvV2o3dnZyR1ZN?= =?utf-8?B?RnVVY3ZFa29YZC8zN3NUT1BDQ2l3SlhEdzVNTm4wTGtOSjBIbldCTlRBWjRQ?= =?utf-8?B?M3BJbEZJdG1SemtqMHowa3hPbWRyZlovNllxUUorV3JDNXE5VzBjMUg1MG80?= =?utf-8?B?NHZoVng3TUVOeXUvQUNEMThhVzdlTHZMRDVsdHFCYVcvbEtjUWk3OFpFajlw?= =?utf-8?B?ekRWazlVcVFDWTBuRk9RV1dMb3dOSjZvRHBadmF0M214TW84Rm1DY0ZGRXdn?= =?utf-8?B?Z3lPU2pGZTdUK2swU3pCeEVac2NlTHFIRXNWS2lMOWtmS1J4OFBpc0VuNmpU?= =?utf-8?B?WS9CckVCK0p4dENxdVV0ZGhiSFJEVG9GNnhTVGpBVThGS09MTHk0ZmtVQUVD?= =?utf-8?B?U0NPK0tuUFdoeW9PN2UzNmhUeURTczMveXMwTVJUcnFVVDVsR1g0eERiNmow?= =?utf-8?B?Q2lXcEt1cnRrZ2l5MVd2S0RXNTRhSEw3dlREUWdSaUJxelFtK2Z0YW12UzF0?= =?utf-8?B?c2NMMk1kVWp1Q2Q4UTdxaWN5RE9mK2V4ZW9sR2NIR1VBa3FTN3p5NXU3Q3Vu?= =?utf-8?B?SVRPM0VPS1BFWDlidDR2ekIwWU83dG9DTDQ5d2tEWExhbGplTHFSdURmWjFS?= =?utf-8?B?dGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e7bdfdb7-fa30-45e4-210b-08db09c7e555 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 11:30:35.6572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WKtP/WusJX6Y+boaFy85vSCYeEw4c4Gan8h0ro4nMlslwM+i1yvEP/qTi55klbiPMBykxXVdIyAhs2Rr8dRZow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5868 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Volodymyr, On 07/01/2023 15:12, Volodymyr Fialko wrote: > For devices not assigned to any driver, we leak a pci device object since > it is never freed from the PCI bus device list, reported by ASAN. > > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") > > Signed-off-by: Volodymyr Fialko > --- > drivers/bus/pci/pci_common.c | 3 ++- > drivers/bus/vdev/vdev.c | 5 +++-- > 2 files changed, 5 insertions(+), 3 deletions(-) > This fix LGTM, but its tricky to reproduce so I have not been able to test this. Could you add some more text to the commit message describing the issue and fix, please? /Kevin