From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20082.outbound.protection.outlook.com [40.107.2.82]) by dpdk.org (Postfix) with ESMTP id 86EA2AAF3 for ; Mon, 16 Apr 2018 16:48:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4eD9OQJBKIddFAdFQaMxrvtgyJAIvbBhd9TNjXznc/s=; b=MPb0BgTpQ2i491rtADYyWCSKqk+CJpYdX6POdgVV4Fcm6qQP3WhseJKPe7mL8rsaE3ADtIQzu48Ssg9xWVKJC9hAfs0jJsSI/5yah6XAkBV5QNA6pauRu8TxpjhDareQGKzgswSP30d2TvLYyRDWtVEyr3nxG6sw9DkAp8q5UiA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [IPv6:2402:3a80:9cd:1644:617a:d41f:77f2:1b2e] (2402:3a80:9cd:1644:617a:d41f:77f2:1b2e) by VI1PR04MB1389.eurprd04.prod.outlook.com (2a01:111:e400:5348::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.11; Mon, 16 Apr 2018 14:48:36 +0000 To: Abhinandan Gujjar , jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, dev@dpdk.org References: <1522825047-61743-1-git-send-email-abhinandan.gujjar@intel.com> Cc: pablo.de.lara.guarch@intel.com, declan.doherty@intel.com, narender.vangati@intel.com, nikhil.rao@intel.com From: Akhil Goyal Message-ID: <3f456621-ff31-ced8-f399-7e19e01ffdf3@nxp.com> Date: Mon, 16 Apr 2018 20:18:24 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1522825047-61743-1-git-send-email-abhinandan.gujjar@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2402:3a80:9cd:1644:617a:d41f:77f2:1b2e] X-ClientProxiedBy: BMXPR01CA0047.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::33) To VI1PR04MB1389.eurprd04.prod.outlook.com (2a01:111:e400:5348::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB1389; X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1389; 3:Q7puFkFe6jzk3iMufYZd4nQXiG92hxrL3mdrdt0seUmrjs/rzZ16nG1bXRqv1qyu/xtmlILcpI8nKRng7yzzDm93StquFUe7v5TTDYC54iGZhqmdw/P/QCWDU8a3n9eC40rkUpYLvV9OS2hVAkDpQv5IrZdJzP38r0j2tJTv7zM9I2CYfLeapZPPtgvIg87e2jK/+dSESHUQVLOB4By1YXmaPEjey/eSfUoPtKEUNsVAsBQEzqtAo9p5DnZMgFNa; 25:pRkWkDrKkSWb2K/olzkMF6qscDN8KIP4T/uRtsE7GfhFtaws7Ef5D+bREzARwvg68Y8dz+Qlh5W6/DrToF9+t0IfCsimI4XH379F+0ezoG7e3zc2BsishKsm9oJW4RxDqs0qIzxFUhJqG5pb6zxcJoUd1jClnNGa+d90gw6mH9YAsVyzSmTGFbjgjKiS+MDjTk/2jra50u7eW4Re/IELMEOGPF8DPdKuuVwbkUMH2k8rcd9etMwk5kBvD3uPjFXoRKwagogzTm/ES81S5WZocL+SsFesLR1dh/mAFSf94eivJFi8EoB5p4c6tShTBEglPxmbXqcMAM4fz7xIihApSg==; 31:3Y6nYAvWQHPjGW8TT/zxf7fLOwZrAB6e3zFN2/wV4sXZSEHa2vjMdc4yrzx7NF66wi4Q5Myi5Bl1c5cRtgHSo/pa0ZZi9F32sW5CyLJgDe7cF+yZ2qXF+bw1/UpD3p5LTjdqH2RQ3EHtAR+KJsMicdIB2xjRxcgUB019sQLbPjgU0mm/W3khMPGUcVoEo+Y0sj8lJKAOImiyOYckpGJgjPHYbvcU96iYYogbtHLH1T0= X-MS-TrafficTypeDiagnostic: VI1PR04MB1389: X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1389; 20:YbwkHfHxi74tQSXnr7zlqYg5xGCnDDjVF6btzxlRrTL2pIsUCp2fV19hu02sz9hXeqHgOPUd1TWq1ShNWdofECqCypLcdI3vaGcdMb0U60GXhZXeBac9JZdPV5WbF5ghROKyKJ3NUFRWzfZ9xy/kD77Mw+lU8kpvv+YAQz7Uz+J4YyjqUg+9YsLkJ9/N+tldi65LXB38FwSxZ5wdfhiTXIMyN5VH5yg50ATb3V5fbIZMTRYrErbjLtZqU6pLVrYa6hHJU74qfETUHbr/FXFFm8m9FZ4GBL87KKvbnJCu1fZVk8GM8QpyMbRJ6RXzzducUtH5oV1e3tpgbO1L5FOqo8XqckRW+uZjZTOlQHDpEJSk8ezCqb0auk+p/+S6joFEYqdP9+Z7aryAhfPmj+6/Rr5LaRiVjELZ95rEfQ1zk4Qnvn4DZ5HHFFbC6gGkdWbTUtUStT4fO0T00X8qqH69JlLQBtY5AVTmM/GQ034CYVIcOpT8UNPajgQI336s1e0E; 4:dokpKmwv0+l7f4BnxhBm74pp2M6bmYfG0F3Cdrky3UneQUlnd5iLoN2upwP+kSKUh7oq87QgXrRNzEnN555cjeESzzCowdBUGWIRaEJt2JTknLa1Ajxrdji8j3YLvvGlWKN87tflHRpduNsl55R0WmY3iLY4328TRAWshDTbHjga3ElcAE52b3mxBdB6+xG1PV82bdmBBlwVK7Yl9OoovAwO4xM0skD8NvpCLXeloXLPxHkhU/GIA7Z3S/ro7/j01rGrlxU47uSZzpo1CvgsPRFrsZ7xUkgRK6TR9nr6oiZNQ+Xlf+ol67EsiIMMTq/2zF0bdg05fKnYpdjpI1VXu4RCuLZCEk6nrYEbYESaFT0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231232)(944501327)(52105095)(6055026)(6041310)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR04MB1389; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB1389; X-Forefront-PRVS: 0644578634 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(39380400002)(396003)(346002)(366004)(199004)(189003)(6486002)(2906002)(476003)(16526019)(2616005)(11346002)(81166006)(81156014)(8676002)(316002)(23746002)(8936002)(6666003)(486006)(46003)(76176011)(64126003)(44832011)(52116002)(186003)(59450400001)(386003)(58126008)(446003)(86362001)(67846002)(50466002)(5660300001)(31696002)(65826007)(53936002)(4326008)(305945005)(106356001)(47776003)(31686004)(65956001)(65806001)(7736002)(3260700006)(25786009)(6246003)(68736007)(105586002)(97736004)(53546011)(52396003)(478600001)(36756003)(230700001)(229853002)(6116002)(1706002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1389; H:[IPv6:2402:3a80:9cd:1644:617a:d41f:77f2:1b2e]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; VI1PR04MB1389; 23:Y1NU0bPvknsfSvJ1aNXJ4yiwwEflbSL9PBUb9?= =?Windows-1252?Q?Z4//dOUFLTjMO+JyCxJiy/MqcasFHfhI7SQhzrYOO5/HrZwe6lnNBXFJ?= =?Windows-1252?Q?IhFhKXVOCowefkz/A4GYn6hLcIVM1UEEpOG8uEObX5n30D8/34hhHjvR?= =?Windows-1252?Q?NeQx5zf6bt9ZwAhYk+2rF+rFRw5NLPOoC3LppJ29PcLPDKAcPkBTxPt+?= =?Windows-1252?Q?VpIEE52HYExU9xVXZ+ElI9hIc91YWS03O0lGKVnDtq3OynEOHuEmLXTI?= =?Windows-1252?Q?JcrVIj3XSyLlN0uBaqmejyAVUObvP5DUeiDOp/3rLLeBs/MRbb4B4Vh1?= =?Windows-1252?Q?PxDlzfspPvAuvlyVAfwNLLbKH0WFw2sfQCAGNggPWoaVLbpxCVBTvP99?= =?Windows-1252?Q?RV4exQpkRKF4aYkgOFAOKqk3ZKyqKWPofvABfnd/5w2vnL3A5EQuWv4D?= =?Windows-1252?Q?ZHodNZtnJeO5yMxeoJcI0acxeu7T4nYXC3bzfkWRMka8H6pPQXj7fhs5?= =?Windows-1252?Q?xx/Z3mHFooznepYqgffkWPiRhh2yA/U99zVBO8hpp/mmrycjLSS42WW6?= =?Windows-1252?Q?4PzQWZYUr+7MqEZOWemwFLl4dQjyfDEb1H/9hVzLaQIKbejQBXVYHDj3?= =?Windows-1252?Q?2lD7n7RKIchW/POIeCRTaHeLdaSRaeVEXByE8kz+1ZQWZTWARdvOdWT5?= =?Windows-1252?Q?OEBC8rqq5zvPXLvStA5qLKS4K2KBGMi8KYm+T4+RIZKOXVRMgVrgHXE8?= =?Windows-1252?Q?nuMljuaS76TxIP20GLxXjpw6+a+8RW5fCOg/e+58+x/5jCXQT9qjgUtP?= =?Windows-1252?Q?MRxqyp6wv4edcaQIFVhAnQ3yQ9CHM19uKTYSJYYFSP7Y79B14KTbMKT0?= =?Windows-1252?Q?ClzbMXGT4V2Ke8ybM5PYlfe/iL9M4ll18/lqs20nz+IH+nLTz9lRkaap?= =?Windows-1252?Q?+Xar+ko+zUIbTSjyXYn1kUbUNvElCaoVjQQ1EK6Z70QA+G/MnM+DNYbr?= =?Windows-1252?Q?CJk6GaepjWsfxr2HQ9vHXDS0cYctx4EzDmpgNQC+MmS9iDFvFxVSfI2Q?= =?Windows-1252?Q?rb8oWA+65XMBtxr7V45TnLpfQ+8t7izIuZa++64fou+V2cJ1Nvg4JhNa?= =?Windows-1252?Q?p+gOI1fjnpv3sFf3Z93nFwsoEo63llv72gGQTshlSCQ5bcHLiiPxZt83?= =?Windows-1252?Q?PuI73GIps6FxnoxXbjkGLCgr8w6EARRUIh+mmfXeoP6feZx4icETo739?= =?Windows-1252?Q?RRNk3Dj00ZBY0mgg3j6RHZNW2ATtWRfX4rxxX4JTiOSuNZVORH1CNjWl?= =?Windows-1252?Q?VyRBkvKyvcu/70aYj96ETyctGkVv390pVLwRC/mac1Q9CgI+erajY/D+?= =?Windows-1252?Q?6QZ+PjbZac9Zu76Itsw7oo2aVH+P59gAnoUHS26I7mMrB0jz+2ZWbANh?= =?Windows-1252?Q?AJO6vMGIvGDT9DwsdMhMK0ddu2f5ExG7wgI7KVivOv659LkCBpx7ZYvU?= =?Windows-1252?Q?qB/8Os=3D?= X-Microsoft-Antispam-Message-Info: 5ZOS7rtlAfOOn4u/NJ/BvEpOYS9HdFC5oPmKJ2Xq2EGKIkdI5c+P+J8mx6h4r2DsfpwNYjUFWZOPTN/jTA5EYa0G75YuO7+FNNGqOtAUKezTe8u7i1H7B+Eml3CsOAp/0oKLsqRMEpvGeoNmZBsVnzm82xc5Z/52BI+AhyuXqUwPwGx4QarEBj15hnHzcQxK X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1389; 6:mseh9458B5WJuxm8kBjQ1d6avB4RJJ8PMmRjR+wksEjXvRWCnxaziehko0nAJqhoFU5euGwe/yFrktasaKIDJpC8BR8K2X/y0zJzpeUh8qqILWxbqyB/IxA2Vfb86tdUG5vDLwg8hPH1fdjwYub00a2CsUb4R8/fnALbWC18SaTvyQOXsMvWI+mVj5rd1FpnH2g3cwLlrMdAf+UiRjDFTILhwFz71BDUVtyULZWIy/n7RRu3PNJzktGE6SrF7w5puk/aSOiK7TDGjggXTgGWfYQjbbU/A9sMMQ+HEsl4X16pIrFAUm2ZPGgsQhhK6Q5raKRAOIk2VQCLrh01d6E2k8H68RAzqogYvZWbqP95sHMQcT3BGnTsMqVC4sw7LjrB9CPjEo5WUDbzA85azmS3g65UFRItUUXUj4fQwF/gzLJd36f3+YyQ/H0dhISnabb+B4GwyP0OaDvkziqoB5iFNg==; 5:eGfitIKh5f9avgNlier2HyO6RA0qhh6oBudWjzwHURiflQHNorLEH8N79wHT+GnfBBe98cCYxlA77KhJkJWiIRm4oAIMQQ7mFJRHX+W1DUTBm5CJWidP1XJVNVC3zMyg4UPF+BAKKdyw3p64xQgn9aUxtMH88dVSGiXPSmS+PE0=; 24:shG7q8uca+DxkhbuLh8oqsOIPuppsZLukfCs+1ICFt1L8tfiV5xt5qnkY1tLT5YBXpQdqT6vprHLggWEE9M5axgOiLQjyXJWUsRNTpEUGWI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1389; 7:Tf5lislTSmUORvwGQvCDeSVAHEo7CkmmjO0sz45J8551dvah+JjM6YMvMnsS5/VbuuqAcJiM4NVPBo3Uu+RvCP6ellr0f0H0Isth3hSHeWMjkZm2GR9ZXUDd7knXxcBGAHAzNVDPMXslQ7b6Lo5wVHQ75h5L7rJUCvZUNfMi4WXonF9XgcJHLmjyVFdDkup9duDpsbMNEtL/PaEPK9t/UQThPMNSumLgCmUV7s4BAtLtN3w0QgkM33+1+7N0To1u X-MS-Office365-Filtering-Correlation-Id: 7524cd9d-b4de-47bc-d9ef-08d5a3a923c4 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2018 14:48:36.6758 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7524cd9d-b4de-47bc-d9ef-08d5a3a923c4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1389 Subject: Re: [dpdk-dev] [dpdk-dev, v1, 5/5] doc: add event crypto adapter documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 14:48:40 -0000 Hi Abhinandan, On 4/4/2018 12:27 PM, Abhinandan Gujjar wrote: > Add entries in the programmer's guide, API index, maintainer's file > and release notes for the event crypto adapter. > > Signed-off-by: Abhinandan Gujjar > --- [.snip.] > + > +Set event request/response information > +-------------------------------------- > + > +In the ENQ_DEQ mode, the application needs to specify the cryptodev ID > +and queue pair ID (request information) in addition to the event > +information (response information) needed to enqueue an event after > +the crypto operation has completed. The request and response information > +are specified in the ``struct rte_crypto_op`` private data or session's > +private data. > + > +In the DEQ mode, the application is required to provide only the > +response information. > + > +The SW adapter or HW PMD uses ``rte_crypto_op::sess_type`` to > +decide whether request/response data is located in the crypto session/ > +crypto security session or at an offset in the ``struct rte_crypto_op``. > +The ``rte_crypto_op::private_data_offset`` is used to locate the request/ > +response in the ``rte_crypto_op``. > + > +For crypto session, ``rte_cryptodev_sym_session_set_private_data()`` API > +will be used to set request/response data. The same data will be obtained > +by ``rte_cryptodev_sym_session_get_private_data()`` API. > + > +For security session, ``rte_security_session_set_private_data()`` API > +will be used to set request/response data. The same data will be obtained > +by ``rte_security_session_get_private_data()`` API. I think you have missed this security API in your patches. Also I don't think this methodology for adding the private data in session will work in case of security sessions. As we have only one API for creating/configuring the security session. However, we can add a parameter in the rte_security_session_create(). Since this API is still experimental, we can change the parameters. What Say? -Akhil