From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12454A0524; Mon, 19 Apr 2021 17:40:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE8CC4130F; Mon, 19 Apr 2021 17:40:25 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 3689A412E6 for ; Mon, 19 Apr 2021 17:40:24 +0200 (CEST) IronPort-SDR: sZ+t7++Qt+MA2rI5gSVeJ1gkWrHQ4Tb+D92ovaN8x+cXXFCcfn6EmVcrb4UdF4m3sDyJQ//gNi fU8Kl1GoxTbA== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="182844539" X-IronPort-AV: E=Sophos;i="5.82,234,1613462400"; d="scan'208";a="182844539" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 08:40:23 -0700 IronPort-SDR: N1vwuubQBwNuN8lwStl4A0mgLFTUeuEwgowwJzWwlOLojravHQquzH3IJYCdsRiNfhtvhqalEd ja8xnJesdu6g== X-IronPort-AV: E=Sophos;i="5.82,234,1613462400"; d="scan'208";a="462779183" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.220.224]) ([10.213.220.224]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 08:40:21 -0700 To: Jack Min , Jeff Guo Cc: Ori Kam , "qi.z.zhang@intel.com" , "beilei.xing@intel.com" , "xiaoyun.li@intel.com" , "jingjing.wu@intel.com" , "dev@dpdk.org" , "ting.xu@intel.com" References: <20210324134844.60410-1-jia.guo@intel.com> <20210413081032.60509-1-jia.guo@intel.com> <20210413081032.60509-2-jia.guo@intel.com> <20210419074344.tpjzwc5xisjykgzd@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <3f464ec1-f6c3-1969-611d-c000b1172d16@intel.com> Date: Mon, 19 Apr 2021 16:40:19 +0100 MIME-Version: 1.0 In-Reply-To: <20210419074344.tpjzwc5xisjykgzd@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/19/2021 8:43 AM, Jack Min wrote: > On Tue, 21-04-13, 16:10, Jeff Guo wrote: >> Add the new items to support the flow configuration for IP fragment >> packets. >> >> Signed-off-by: Ting Xu >> Signed-off-by: Jeff Guo >> --- >> app/test-pmd/cmdline_flow.c | 21 ++++++++++++++++++++- >> 1 file changed, 20 insertions(+), 1 deletion(-) > > [...snip...] > >> + [ITEM_IPV4_ID] = { >> + .name = "packet_id", >> + .help = "fragment packet id", >> + .next = NEXT(item_ipv4, NEXT_ENTRY(UNSIGNED), item_param), >> + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ipv4, >> + hdr.packet_id)), >> + }, >> [ITEM_IPV4_FRAGMENT_OFFSET] = { >> .name = "fragment_offset", >> .help = "fragmentation flags and fragment offset", >> @@ -2969,12 +2980,20 @@ static const struct token token_list[] = { >> }, >> [ITEM_IPV6_FRAG_EXT_FRAG_DATA] = { >> .name = "frag_data", >> - .help = "Fragment flags and offset", >> + .help = "fragment flags and offset", > Will it be better to have a seperate fix patch for this ? > You refer the case update of the help string, 'F' -> 'f', right? If so this is so small, and cosmetic, update, I think no need to have its own patch, and while this patch is touching related area, acceptable to fix it here.