From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13A60A0567; Tue, 9 Mar 2021 18:36:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC75022A257; Tue, 9 Mar 2021 18:36:38 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 9DD8F4069D for ; Tue, 9 Mar 2021 18:36:36 +0100 (CET) IronPort-SDR: dfrluiRXTQGeO/Vegp0kUFukf4cWe8xdU2zK517hUYUfpOWWMr5frmEKXtfx/OaCyxl6DoVOEA 9+zaOE1Y5heA== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="185904879" X-IronPort-AV: E=Sophos;i="5.81,236,1610438400"; d="scan'208";a="185904879" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 09:36:35 -0800 IronPort-SDR: rnPDeMruFIRZnLYXa7zncJbDRH6voI/xj0YTjJStM3iNRACL/E91+sd7bwpuXPmn/P7W9hudWV 0psKDNgRvtbw== X-IronPort-AV: E=Sophos;i="5.81,236,1610438400"; d="scan'208";a="409827652" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.196.3]) ([10.213.196.3]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 09:36:33 -0800 To: Ed Czeck , dev@dpdk.org Cc: shepard.siegel@atomicrules.com, john.miller@atomicrules.com, Bruce Richardson References: <20210304165637.24658-1-ed.czeck@atomicrules.com> <20210309160818.3553-1-ed.czeck@atomicrules.com> <20210309160818.3553-5-ed.czeck@atomicrules.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <3f558b98-66d1-ce63-9ee0-90364cd51146@intel.com> Date: Tue, 9 Mar 2021 17:36:30 +0000 MIME-Version: 1.0 In-Reply-To: <20210309160818.3553-5-ed.czeck@atomicrules.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/9/2021 4:08 PM, Ed Czeck wrote: > In this commit we generalize the movement of user-specified > meta data between mbufs and FPGA AXIS tuser fields using > user-defined hook functions. > > - Previous use of PMD dynfields are removed > - Hook function added to ark_user_ext > - Add hook function calls in Rx and Tx paths > - Update guide with example of hook function use > - Add release notes > > Signed-off-by: Ed Czeck > --- > v3: > - split function rename to separate commit > > v4: > - reorder patches renaming before adding <...> > diff --git a/drivers/net/ark/version.map b/drivers/net/ark/version.map > index 954bea679..4a76d1d52 100644 > --- a/drivers/net/ark/version.map > +++ b/drivers/net/ark/version.map > @@ -1,10 +1,3 @@ > DPDK_21 { > local: *; > }; > - > -EXPERIMENTAL { > - global: > - > - rte_pmd_ark_tx_userdata_dynfield_offset; > - rte_pmd_ark_rx_userdata_dynfield_offset; > -}; > Since there is no more public APIs by driver, I think it should stop installing the header, and remove it from 'meson.build' file, and remove the header from API documentation, 'doc/api/doxy-api-index.md'. I can see the header needs to be used by the extension developer, but that is still kind of PMD, the public headers are installed for the application developers. Still there is a desire to install the required headers for PMD developers, as far as I know Bruce is working on it, cc'ed. This header can be installed as part of that effort. Thanks, ferruh