From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D51DF2C36 for ; Tue, 3 Jan 2017 04:25:21 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 02 Jan 2017 19:25:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,451,1477983600"; d="scan'208";a="804450934" Received: from jguo15x-mobl3.ccr.corp.intel.com (HELO [10.239.205.249]) ([10.239.205.249]) by FMSMGA003.fm.intel.com with ESMTP; 02 Jan 2017 19:25:19 -0800 To: Beilei Xing , jingjing.wu@intel.com, helin.zhang@intel.com References: <1483027473-89042-1-git-send-email-beilei.xing@intel.com> <1483068352-32272-1-git-send-email-beilei.xing@intel.com> <1483068352-32272-18-git-send-email-beilei.xing@intel.com> Cc: dev@dpdk.org From: "Guo, Jia" Message-ID: <3f58d1aa-a688-0281-6ffe-db37124c3680@intel.com> Date: Tue, 3 Jan 2017 11:25:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1483068352-32272-18-git-send-email-beilei.xing@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 17/17] net/i40e: flush tunnel filters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 03:25:22 -0000 On 12/30/2016 11:25 AM, Beilei Xing wrote: > This patch adds i40e_tunnel_filter_flush function > to flush all tunnel filters, including filters in > SW and HW. > > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_flow.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c > index 5c16fb8..fd0f0ec 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -105,6 +105,7 @@ static int i40e_dev_destroy_tunnel_filter(struct i40e_pf *pf, > struct i40e_tunnel_filter *filter); > static int i40e_fdir_filter_flush(struct i40e_pf *pf); > static int i40e_ethertype_filter_flush(struct i40e_pf *pf); > +static int i40e_tunnel_filter_flush(struct i40e_pf *pf); > > const struct rte_flow_ops i40e_flow_ops = { > .validate = i40e_flow_validate, > @@ -1671,6 +1672,14 @@ i40e_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error) > return -rte_errno; > } > > + ret = i40e_tunnel_filter_flush(pf); > + if (ret) { > + rte_flow_error_set(error, -ret, > + RTE_FLOW_ERROR_TYPE_HANDLE, NULL, > + "Failed to flush tunnel flows."); > + return -rte_errno; > + } > + > return ret; > } > > @@ -1733,3 +1742,31 @@ i40e_ethertype_filter_flush(struct i40e_pf *pf) > > return ret; > } > + > +/* Flush all tunnel filters */ > +static int > +i40e_tunnel_filter_flush(struct i40e_pf *pf) > +{ > + struct i40e_tunnel_filter_list > + *tunnel_list = &pf->tunnel.tunnel_list; > + struct i40e_tunnel_filter *f; Just a mini comment, could you replace the variables name from "f" to any other obvious name , to let code to be more readable. > > + struct i40e_flow *flow; > + void *temp; > + int ret = 0; > + > + while ((f = TAILQ_FIRST(tunnel_list))) { > + ret = i40e_dev_destroy_tunnel_filter(pf, f); > + if (ret) > + return ret; > + } > + > + /* Delete tunnel flows in flow list. */ > + TAILQ_FOREACH_SAFE(flow, &pf->flow_list, node, temp) { > + if (flow->filter_type == RTE_ETH_FILTER_TUNNEL) { > + TAILQ_REMOVE(&pf->flow_list, flow, node); > + rte_free(flow); > + } > + } > + > + return ret; > +}