From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DDC2A2EDB for ; Tue, 1 Oct 2019 09:10:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 179EB5B32; Tue, 1 Oct 2019 09:10:41 +0200 (CEST) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by dpdk.org (Postfix) with ESMTP id CD0B25681 for ; Tue, 1 Oct 2019 09:10:39 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 915FA940054; Tue, 1 Oct 2019 07:10:37 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 1 Oct 2019 08:10:12 +0100 To: , , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , "Viacheslav Ovsiienko" , Stephen Hemminger , "K. Y. Srinivasan" , "Haiyang Zhang" , Alejandro Lucero , Nithin Dabilpuram , Kiran Kumar K , "Rasesh Mody" , Shahed Shaikh , "Maciej Czekaj" , Yong Wang CC: References: <20191001063453.7138-1-pbhagavatula@marvell.com> <20191001064139.9325-1-pbhagavatula@marvell.com> <20191001064139.9325-5-pbhagavatula@marvell.com> From: Andrew Rybchenko Message-ID: <3f69d6e4-72ed-1d3e-1df1-fb58bc833e08@solarflare.com> Date: Tue, 1 Oct 2019 10:10:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191001064139.9325-5-pbhagavatula@marvell.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24946.003 X-TM-AS-Result: No-5.692700-8.000000-10 X-TMASE-MatchedRID: L8tZF6zWW2oeimh1YYHcKKfOxh7hvX71iKQhvNyRXGHk1kyQDpEj8IP+ YDa/Dhu96dlqnF4gOVm0TL1wHXdwVZsyCEgzfA2XSvQm6xqmCPJ5GpkA2em4X2MunwKby/AXPo+ GPoN9kISt2gtuWr1LmoTeRjSdsNiCajCF67OIrSpf/qVBvaz1YXFHqsgruohZQW6eCaGxKwJ9aW vTi9VKSvPjth3y27H9FhPKDJYuPN5LN0omgI25H836paW7ZnFoPz+fM/byAtmbKItl61J/ycnjL TA/UDoAoTCA5Efyn8CNo+PRbWqfRMZW5ai5WKlyRnvQ1vi6cej732bO97sGq0Z3F/CFgdCIhyet 8aA0AidI7jnzEigJLxl0HbALjH8YKOj4po8qkpcmdI3TAIybYsxrXgysrHE0hXICXPkDTMLvGya LyWJvBWLqcdF40kDywzhVZiqhieFqbamnjuWv4A== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.692700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24946.003 X-MDID: 1569913839-Oi-MwKSRfpiV Subject: Re: [dpdk-dev] [PATCH v5 4/7] drivers/net: update Rx RSS hash offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/1/19 9:41 AM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash > delivery. > > Signed-off-by: Pavan Nikhilesh [snip] > diff --git a/drivers/net/sfc/sfc_ef10_essb_rx.c b/drivers/net/sfc/sfc_ef10_essb_rx.c > index 63da807ea..220ef0e47 100644 > --- a/drivers/net/sfc/sfc_ef10_essb_rx.c > +++ b/drivers/net/sfc/sfc_ef10_essb_rx.c > @@ -716,7 +716,7 @@ struct sfc_dp_rx sfc_ef10_essb_rx = { > .features = SFC_DP_RX_FEAT_FLOW_FLAG | > SFC_DP_RX_FEAT_FLOW_MARK, > .dev_offload_capa = DEV_RX_OFFLOAD_CHECKSUM, > - .queue_offload_capa = 0, > + .queue_offload_capa = DEV_RX_OFFLOAD_RSS_HASH, > .get_dev_info = sfc_ef10_essb_rx_get_dev_info, > .pool_ops_supported = sfc_ef10_essb_rx_pool_ops_supported, > .qsize_up_rings = sfc_ef10_essb_rx_qsize_up_rings, > diff --git a/drivers/net/sfc/sfc_ef10_rx.c b/drivers/net/sfc/sfc_ef10_rx.c > index f2fc6e70a..85b5df466 100644 > --- a/drivers/net/sfc/sfc_ef10_rx.c > +++ b/drivers/net/sfc/sfc_ef10_rx.c > @@ -797,7 +797,8 @@ struct sfc_dp_rx sfc_ef10_rx = { > SFC_DP_RX_FEAT_INTR, > .dev_offload_capa = DEV_RX_OFFLOAD_CHECKSUM | > DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM, > - .queue_offload_capa = DEV_RX_OFFLOAD_SCATTER, > + .queue_offload_capa = DEV_RX_OFFLOAD_SCATTER | > + DEV_RX_OFFLOAD_RSS_HASH, > .get_dev_info = sfc_ef10_rx_get_dev_info, > .qsize_up_rings = sfc_ef10_rx_qsize_up_rings, > .qcreate = sfc_ef10_rx_qcreate, > diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c > index e6809bb64..695580b22 100644 > --- a/drivers/net/sfc/sfc_rx.c > +++ b/drivers/net/sfc/sfc_rx.c > @@ -618,7 +618,8 @@ struct sfc_dp_rx sfc_efx_rx = { > }, > .features = SFC_DP_RX_FEAT_INTR, > .dev_offload_capa = DEV_RX_OFFLOAD_CHECKSUM, > - .queue_offload_capa = DEV_RX_OFFLOAD_SCATTER, > + .queue_offload_capa = DEV_RX_OFFLOAD_SCATTER | > + DEV_RX_OFFLOAD_RSS_HASH, > .qsize_up_rings = sfc_efx_rx_qsize_up_rings, > .qcreate = sfc_efx_rx_qcreate, > .qdestroy = sfc_efx_rx_qdestroy, > diff --git a/drivers/net/thunderx/nicvf_ethdev.h b/drivers/net/thunderx/nicvf_ethdev.h > index c0bfbf848..391411799 100644 > --- a/drivers/net/thunderx/nicvf_ethdev.h > +++ b/drivers/net/thunderx/nicvf_ethdev.h > @@ -41,7 +41,8 @@ > DEV_RX_OFFLOAD_CHECKSUM | \ > DEV_RX_OFFLOAD_VLAN_STRIP | \ > DEV_RX_OFFLOAD_JUMBO_FRAME | \ > - DEV_RX_OFFLOAD_SCATTER) > + DEV_RX_OFFLOAD_SCATTER | \ > + DEV_RX_OFFLOAD_RSS_HASH) > > #define NICVF_DEFAULT_RX_FREE_THRESH 224 > #define NICVF_DEFAULT_TX_FREE_THRESH 224 For net/sfc: Reviewed-by: Andrew Rybchenko