From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 44EC01B839
 for <dev@dpdk.org>; Tue, 24 Oct 2017 20:18:52 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 24 Oct 2017 11:18:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,428,1503385200"; d="scan'208";a="166550878"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.60])
 ([10.241.225.60])
 by fmsmga005.fm.intel.com with ESMTP; 24 Oct 2017 11:18:51 -0700
To: Matan Azrad <matan@mellanox.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: dev@dpdk.org
References: <1508834730-30271-1-git-send-email-matan@mellanox.com>
 <1508839559-1568-1-git-send-email-matan@mellanox.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <3f6d4ae7-eed8-9e7c-d332-282799fac7c1@intel.com>
Date: Tue, 24 Oct 2017 11:18:51 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1508839559-1568-1-git-send-email-matan@mellanox.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx4: fix targetless internal rule
 creation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Oct 2017 18:18:53 -0000

On 10/24/2017 3:05 AM, Matan Azrad wrote:
> The corrupted code allowed to create internal rule with no any target queue
> in case the rule creation occurred before queues creation.
> 
> For example, when user calls rte_eth_dev_default_mac_addr_set after probe
> and before dev_configure, mlx4 fails because the RSS queue number was 0.
> 
> The fix prevents internal rules creation before queues creation based on
> future creation before traffic start.
> 
> Fixes: 7d8675956f57 ("net/mlx4: add RSS support outside flow API")
> Fixes: bdcad2f4843a ("net/mlx4: refactor internal flow rules")
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied to dpdk-next-net/master, thanks.