DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Guo, Jia" <jia.guo@intel.com>
To: Prateek Agarwal <pratekag@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header directly to us
Date: Mon, 9 Nov 2020 06:24:07 +0000
Message-ID: <3f94d598668b4279a2f5fb834124f3e2@intel.com> (raw)

Hi, Agarwal

> -----Original Message-----
> From: Prateek Agarwal <pratekag@gmail.com>
> Sent: Saturday, November 7, 2020 5:01 PM
> To: Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Prateek Agarwal <pratekag@gmail.com>
> Subject: [PATCH] Made i40 header CPP compatible using extern "C". Library
> headers work directly in cpp code. Linking errors thrown due to the absence
> of this change in i40e pmd header does not help in resolving the problem. I
> needed this header directly to use...
> 

Obviously that is not you want to merge the title and the commit log. Please separate it and update one new version. 

> Signed-off-by: Prateek Agarwal <pratekag@gmail.com>
> ---
>  drivers/net/i40e/rte_pmd_i40e.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/net/i40e/rte_pmd_i40e.h
> b/drivers/net/i40e/rte_pmd_i40e.h index fc3560c28..4cb21c371 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.h
> +++ b/drivers/net/i40e/rte_pmd_i40e.h
> @@ -14,6 +14,10 @@
>   *
>   */
> 
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  #include <rte_compat.h>
>  #include <rte_ethdev.h>
>  #include <rte_ether.h>
> @@ -1130,4 +1134,8 @@ __rte_experimental  int
> rte_pmd_i40e_set_switch_dev(uint16_t port_id, struct rte_eth_dev
> *switch_dev);
> 
> +#ifdef __cplusplus
> +}
> +#endif
> +
>  #endif /* _PMD_I40E_H_ */
> --
> 2.25.1


             reply	other threads:[~2020-11-09  6:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09  6:24 Guo, Jia [this message]
2020-11-09  9:49 ` [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d Zhang, Qi Z
2020-11-09 17:44   ` Ferruh Yigit
2020-11-10 12:44     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f94d598668b4279a2f5fb834124f3e2@intel.com \
    --to=jia.guo@intel.com \
    --cc=dev@dpdk.org \
    --cc=pratekag@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git