From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0086.outbound.protection.outlook.com [104.47.40.86]) by dpdk.org (Postfix) with ESMTP id 6FA54E5D for ; Mon, 11 Dec 2017 13:26:18 +0100 (CET) Received: from BN3PR03CA0074.namprd03.prod.outlook.com (10.167.1.162) by BN6PR03MB2689.namprd03.prod.outlook.com (10.173.144.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Mon, 11 Dec 2017 12:26:17 +0000 Received: from BN1BFFO11FD013.protection.gbl (2a01:111:f400:7c10::1:115) by BN3PR03CA0074.outlook.office365.com (2a01:111:e400:7a4d::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Mon, 11 Dec 2017 12:26:16 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD013.mail.protection.outlook.com (10.58.144.76) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.282.5 via Frontend Transport; Mon, 11 Dec 2017 12:26:11 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vBBCQEiu010810; Mon, 11 Dec 2017 05:26:15 -0700 To: Gaetan Rivet References: From: Shreyansh Jain CC: Message-ID: <3f96d5f0-30d0-3e71-98f6-283d8bd05238@nxp.com> Date: Mon, 11 Dec 2017 18:09:50 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131574687716169608; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(336005)(39860400002)(346002)(39380400002)(376002)(2980300002)(1109001)(1110001)(339900001)(24454002)(199004)(189003)(104016004)(76176011)(97736004)(85426001)(356003)(316002)(86362001)(4326008)(8936002)(6666003)(31696002)(31686004)(106466001)(65826007)(5660300001)(64126003)(50466002)(33646002)(6916009)(2950100002)(81156014)(53936002)(8676002)(68736007)(58126008)(6246003)(36756003)(498600001)(81166006)(2906002)(67846002)(229853002)(305945005)(47776003)(23676004)(83506002)(105606002)(65806001)(65956001)(2486003)(230700001)(77096006); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2689; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD013; 1:luqUHI6OAwf/w4cD+TQLL/QXSYy1pZ1xKdo6Fwz6JJvVPXt6n9m/e6hihHD6M15DbZO9CxJDrR7sU85PzegMmKIYQLp0i6KZFLL1qeklGKWBww59r4iqUqJJSPKzImmA X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2d485f46-d36b-4541-5788-08d540925d38 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4628075)(201703131517081)(2017052603307); SRVR:BN6PR03MB2689; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2689; 3:xCQm8ZJFpgAUYE8BJLLl0v4CvR768SrLKlu1+unA3EpPtAoZSzB4t24G9QAl9aAcH83l6HZOpuSXsihoH3K0kr1uoW4ynjKs4ffEW2QX9mQvAx5XQPNYbNjFChxJU98ulQxe9GpNPuNbzHl3PDc7FP69xFDDAOg1VxlunPWMm/3+A0AprzinaW75EUx/BkjoAmayocUqEh2AxLILUsJFy/+aQ4YB8SGiTHGTdfMLUfz+1HxPDooz+7frv1Te4+LjGQybXH0z+Cn9EmOd+lDSdKcqohf/yWbNvQ0i3/X0RQzaacGodGOlMoOMPoBMImMr6BXkuU6AhgOSQvH4yDEktu+9ccwZBA5dHSIFEXClehY=; 25:miM3qknX77Q9SwcKO9GXT9mBZVDd8qQWDKRg0BGNEMqXC0UdLi9nDkXJ+q8GPo4jya1R4qDI1Na+WKmJmXis8I/lh7wVL0jxvgwm5afb/ZQECpMtxaOwOM/SEo8xxW4HhemXNUkopNfq4sgxqOmUbLELRm8wqecM00/AjFGRhvY0ReBarnnRElERcTxzXpXA3SsOHfNEpU2ktG2FDrE2DEuXzP6EnsstD+pnaW1TPk8F8CACwLYew+FCmEpfNFCdYsKcCagVknMLcmaTSGnSTfaXgGe3pSZbrkoKB8vQv3iiPLuuHZDPqSS9fVqm8VMMEetmBJYYNXztW0TL4rbsTg== X-MS-TrafficTypeDiagnostic: BN6PR03MB2689: X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2689; 31:m84CeNr4PWOigEE38pq7WGrfxgCgMn+fvwR5MmJmK5TagtBznFVlKPZT1pKX8umPMVES5/9I+2eXehV9z1VqXEilDPAcc+qqo9wyHSUBX0zChZwqQJ/tvtUi0TIzYJjhRMicg5mYIpVxAAg/RBl9nRJI5ae1BqJ8i6bueukfnczc2JHsiF9JdAmqjLXGswooGjeKhZ0VcGJ/WA1Q6SZmTniyt0y+Wj4gSxGowplTBV8=; 4:IYMDn6IM1XXnYEbXUFG5Coka9bITI2HQCURHxxv00Jh6AXQ6BhVU+1zttjo2qN9pN065+pWGDIyvk62lK8adTKPHJytK3RJsEerIJ0DCss0P1p/yko461IqgR7i4Gn2ZzQUgyE8KNQUzXkHrBuEceS4Yh3s7rDPLdn80cyXedZpd0DcHxoG6l4xEtEHXc8R/0sEomFdlz6o2UL1K1McThtdJEHQYQe9c++RX/Zxr/kDsBQH/J8a1UwIfjF9LOtwbx5hVCATt1EHxIKfcxTagqw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231022)(3002001)(6055026)(6096035)(20161123561025)(20161123556025)(20161123565025)(20161123563025)(20161123559100)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(201708071742011); SRVR:BN6PR03MB2689; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:BN6PR03MB2689; X-Forefront-PRVS: 0518EEFB48 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIyNjg5OzIzOlU1QUorZzFyaDJVaklaOFdhRDhKUFpmUmxY?= =?utf-8?B?R1IrbHpEdXNXTEowN2NFTmhPcXFyaVNGakVtL3RiWENlOWRNdlBkYkdyL1lB?= =?utf-8?B?YU9McVMwZFhNaVNOTzVLWGhxWS90NDJ2WlcrY3llcXJ0NUt6Wk5sVUNiTkhi?= =?utf-8?B?WE1iTGtqNWwrNU5VeUdwTkdWTnIwUTc2VExUdnBzdjVneWMrSzlSMDk4ajFm?= =?utf-8?B?N2J1b2tjK1cvWXJHQ0s3Tmx6RWgwalppTFJXNjdjMmRFL2s0dFZON1JUMTRV?= =?utf-8?B?U082dEEvbnlFRmh2bEJQU3FLUU4wd2FlTmhQK2M2TEpnTER4bEV5NldjKzgr?= =?utf-8?B?eC9vZDZKUWFYdGxuYStXVy9FemNDUGJHc2VsNGpzQjZ6VXJMYVJnWXBTMmdj?= =?utf-8?B?TGpjazFhYmhmNDhQM2dMUDdKcXBURlpsdFhkeFk0QmFjL1B5SlZOZTFKM05Q?= =?utf-8?B?WmtwV3FzcnBMN0NVYXVqMXdwQkVaT2pGeHNnb1ZZV0FZcXpFQmFaMzNaSjZv?= =?utf-8?B?UU81S1NwdFJsQVp6NjdRYkkrNlREckRJWnFuZmR6Tkw1djZGQk1ubXBBZFVn?= =?utf-8?B?OEwzZnYyNlpiTkh5MHAzY1VhcmhVOUp5YmgwaksxVC80dU4zOHltcUJoNGFQ?= =?utf-8?B?OFJVN0F3V1V6UExJeE9vbHJYcHB2VmRzVjAzcWJKMHVHd0hZQ3RINXJZdUxF?= =?utf-8?B?R1BCYXN4dnlza1hGKzRHVFZKS1VpTkFVbU5CSFhCVVF6TUdlUFNxN1ZNbDFH?= =?utf-8?B?ejN2UUI4T2VlMG5kbkVsazBHY0FlbDRBTTE5cGhVZm9GNi9rNElEMmxTMEgv?= =?utf-8?B?RkpOMkFDTHRyZ3pMTENJWWxLUy9TeWhjL0lmTnJUNGhBbzNqMHM1NmdINDAx?= =?utf-8?B?T2JFRHBTZGg1ZWtvYzNxRjFoelE1ZVlRSUZlbGJob1loYWxzZHoxeDlac093?= =?utf-8?B?VkpzZHdnZVg4WTY1dDdGeXdFeGU2cTl5bU9EV056SFNoYnltdlBla2Nya2VE?= =?utf-8?B?YWdsK0tsb0lWTTYwTU1HaGtXQnJpMmNwVnp3UUt0ajltSVVwUmlLTW5vUm05?= =?utf-8?B?SWowMCtpQThrdHl0anl3QWFJaWlUa21QZ1ZRdTEzNjJ4YUJFVHdXUE1ZVnNz?= =?utf-8?B?YnAyNVZoSS85MEV3OVduQUVrK0RML0d3bXJVbEErQ3ptVzB6M0FZOUFVUVVh?= =?utf-8?B?dm5oMGRVdEdVa09PczRYNVNaOVB0VFVoVmlyTTR0T0Q3VUNsQXJRUWdya0hO?= =?utf-8?B?bzJuRTE4WG1JcklkZWhINGJTMWIrdWYvWHl3WWsvVFVodDRxWXBtMXBpRmdU?= =?utf-8?B?UTV6TktLV3cveWFOeTZXajY2VEVHMUJYdisyTUhnYk1samNZVWd5Mi96dUhN?= =?utf-8?B?cm1PdlJJK1hrcDRlVmQzNWhJeWpmMk1PeDRiOGRaVnhiQWNDUFRXaTF2UFYy?= =?utf-8?B?RHVmeUY4RFFuVGkvSTFwM3Zlc0RGQlVVeC9kaXNBdWxxcUg5cS9rYjNOTDMz?= =?utf-8?B?SDl2U1FTaGtuNkpsVW96eVQ1S2FveFBPMHdQb1U2NGQwTWlFUFNJZzFBamNt?= =?utf-8?B?S1FUeFFNSStldFRjUFFUZ1ZJaW9ML0t0VWpKUmQxeVk5eFhGZXB2czFuWHFo?= =?utf-8?B?UFltTmZ3OUNHekZYTDZHL0ZreEkrQ1dqTFFVVnpBV3Z4dUo0Nmt3cFBBVkN2?= =?utf-8?Q?hESV0bqJ8WDC7MuJNic/3Ej73NO7PsTwSIbZGIh?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2689; 6:rxW1FPSD0EbGDxhutQ8IDPsggeXITbX6xJ8Dh7H4Uu6OUAIxrS8EiBFOQd4Cuu/AZ+d/vuPHSSeTZfFlnRzy/slsHrk3TAp4PZ8qHj/mY98X89vHEFObJD0McwO8NjLfpYtNQu8WFX/a0VZTUMJ2jRi6aQkr8H/4d6DJSB5SFL9j4kaZG4CbYsAlV3+AfUpIrNB8a3nGoqXNqgBsvFM4B4l+pbCvnD5z9zPGPb+xxaKKrqniKGf+baP9MoR5cUX1z9+FkJ9P425sKSZaB4/DBLGw+sE4b7pK4WAtbts43U/xQ81SckIkdcA3NyCvo2R/kslVKXMD0Ld7xwV9v2lHTW+MhAECSzS5mA3+TSU+c9Y=; 5:/UuarfdAhS94KmiQ0Xox2XQPFiRBwR0a9qWoaKQb5lA32KYC6ESNSBOJtMzUWlWCBRF610KeSX5416qQSJzHZTMdZ44z8bCzfnVyIZ6uYXYybRy1L4hKnoHS8AlWEHH6d1YHqVUCvt6h87/7xqRF29+Z27L8YSjzVx4T55D+4FA=; 24:AZdXmXTyavm+hHRk/JbnwpdbQikpQIZNeRXa22fs/LAPFvZcn/o/0jwyriDEc4iDqgYjtNtxvKXmZXL0BOI7QkO++JQBnPBlwNDdoV7ctOw=; 7:MONSBMTzbZGn7dkDZEvxZCiAS6Ua2dXJdKDuaAHnA5HNKnHezpkpCpOLm6TDFc7vV+KCEUAFxG2W3q3XPGg7b1ufpzwRq/1ANsjiSv/t5Cxe8fQyb/JEAHdujESiXEJUdDKv0PvV1+iYDBWY4GAoPkhtLr4+CExvebPbaEeaDzl7PQKR+eHIxTg8VYBZ20BHmaiF6A+A1VizCz/IdRwu2fcEI1XrmEEoTs+xvw+RPSLVVqGBWpYJTnRtAIb3vYI/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2017 12:26:11.4453 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d485f46-d36b-4541-5788-08d540925d38 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2689 Subject: Re: [dpdk-dev] [PATCH v1 4/8] bus: add probe mode setter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 12:26:19 -0000 On Thursday 12 October 2017 01:48 PM, Gaetan Rivet wrote: > Introduce new rte_bus operation to configure the probe policy. > > Implementation is required from buses interested in supporting > this configuration element. > [...] > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index e40c049..630c9d2 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -997,29 +997,24 @@ int > eal_parse_common_option(int opt, const char *optarg, > struct internal_config *conf) > { > - static int b_used; > - static int w_used; > - > switch (opt) { > /* blacklist */ > case 'b': > - if (w_used) > - goto bw_used; > + if (rte_bus_probe_mode_set("pci", RTE_BUS_PROBE_BLACKLIST) < 0) > + return -1; Generic layer shouldn't be concerned about "pci" or other bus. Problem would be to find which bus this option needs to be set. What I can think of as options is: 1. Storing this configuration until we can parse the argument for which the argument has been created. That would mean changing the way the "-b" and "-w" are passed and to allow non-PCI device identifier to be passed. 2. Call each bus bus->ctrl and let it decide what to do based on the args. - so, have a wrapper over rte_bus_probe_mode_set for all buses rather than taking any one bus as option. (2) sounds most plausible for now as the application will not send the bus name as argument. And if brute force is not required, we need to split the argument to know the bus - after making the device naming standardized (:<...>) Even before that, we need to agree that "-w' and "-b" are not more valid only for PCIs. Above is more of loud thinging - I don't have concrete thought on this for now. I'll revisit this after reviewing the patches in this series. > if (eal_option_device_add(RTE_DEVTYPE_BLACKLISTED_PCI, > optarg) < 0) { > return -1; > } > - b_used = 1; > break; > /* whitelist */ > case 'w': > - if (b_used) > - goto bw_used; > + if (rte_bus_probe_mode_set("pci", RTE_BUS_PROBE_WHITELIST) < 0) > + return -1; > if (eal_option_device_add(RTE_DEVTYPE_WHITELISTED_PCI, > optarg) < 0) { > return -1; > } > - w_used = 1; > break; > /* coremask */ > case 'c': > @@ -1165,10 +1160,6 @@ eal_parse_common_option(int opt, const char *optarg, [...]