From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 79090A00C2;
Tue, 8 Mar 2022 12:17:13 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 276DA406A2;
Tue, 8 Mar 2022 12:17:13 +0100 (CET)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by mails.dpdk.org (Postfix) with ESMTP id AAF114068B
for <dev@dpdk.org>; Tue, 8 Mar 2022 12:17:11 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1646738231; x=1678274231;
h=message-id:date:to:cc:references:from:subject:
in-reply-to:content-transfer-encoding:mime-version;
bh=iDhqRoXmE61Ds8x5GSZFpW9/UYVNT9u+y7oyreqZMCY=;
b=m/nvmG05AAKGPIql5A5O3MbuvxtRojD/w159JF/V70ITHnNTKinvW4sG
OIwFHF6ex6JZlCAsQ2l9Y9aDNZgpx9KWyuB5HR/y03PmG8fdkfjpLpEPe
Kok23Gu0kKJreYVSipDjIO8g2of2ANHpAvk2wGGwAEZwzLO3ZfF5OoojP
zUrZ+CzdqehHSOQLOlaQLQ4uUoqIIjnUh2kciAF1/7tnUC03xsnxdpSx4
AY/uf7nO9+HTYoz1LSISBJbg3p2R+iZUNV7lBaDLSgLMyCIipfTcoQ+Sl
2QOaTlhap37275xtYgTDz0pG91XLXnPNekSZzZFPybCCATQ/g+dLM/VF4 g==;
X-IronPort-AV: E=McAfee;i="6200,9189,10279"; a="254599411"
X-IronPort-AV: E=Sophos;i="5.90,164,1643702400"; d="scan'208";a="254599411"
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
08 Mar 2022 03:16:47 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,164,1643702400"; d="scan'208";a="495417732"
Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85])
by orsmga003.jf.intel.com with ESMTP; 08 Mar 2022 03:16:46 -0800
Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by
fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.21; Tue, 8 Mar 2022 03:16:46 -0800
Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by
fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.21; Tue, 8 Mar 2022 03:16:46 -0800
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.21 via Frontend Transport; Tue, 8 Mar 2022 03:16:46 -0800
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172)
by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2308.21; Tue, 8 Mar 2022 03:16:45 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=JXBdolp59TZc152K9rl24ciDy7cqCX60lXONEr7yxnd6qiY9Ba5/y7K3CnimmLI3ggthvsTMactvUAxzatjgcxXDbaYFYOiJcWtvr3ryaz3ZxqJh9IgkKVn476PTM6VreKqTA9d+PZYLCA/5ixvDHZlGJ3h5lqybbV7xMpo/lUFQAwzGZ+SPxSTHIEqj59it2qMMwcfSSxuw2sdTYSuVrd96TPN5VtHE/2gxOZ0aODXksjQmdNh7GvKf5xeVtkfVkyAjLfhNn/nDKXQQ9sc7MOkYRq37XQA0oa4MJWnRLpnwix4uXfFfARGnbgwWa6eOgNeW5mU9dMmEAUp278mBoQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=G+vFgao/NmbnoPHvAf1ph8oOlzqnwO2xj1EFk+4OqOs=;
b=TDpmvYgShY4a6W8j2hEsmMg/NYPsRKKnd6dlyVH1L3B+uW/eAssDR1d6PsrVdTXOi8ZXLcjX009Hj7PMODaT7gl9NPvz9Q42/mHsdfF4zdYjYK96cB/9oenf3hSplwJQyHmtl7N7GQBUwqo+jvHp0yMQLdXveR3JVmk71mxR/z5hz1/arq72S7E6RWEycH6ENRh7CNxzspApLdhjk35QXDobkcAedO1dc34UZ7nBPkOzZczn4oPPWkL58n4pb1MidxPuRIHfy8Zkr6WxzqfNzySTKsROaeBQR+Y+fs2xk5sEuWf7RLHushVWXk7fZ1yyjK5fkr2rUzScewpBxxbsrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19)
by BL1PR11MB5954.namprd11.prod.outlook.com (2603:10b6:208:385::16)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Tue, 8 Mar
2022 11:16:44 +0000
Received: from PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.027; Tue, 8 Mar 2022
11:16:43 +0000
Message-ID: <3fbecc49-9851-a0e3-473a-af00a60421d8@intel.com>
Date: Tue, 8 Mar 2022 11:16:37 +0000
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>, Junjie Lin
<277600718@qq.com>
CC: <dev@dpdk.org>, <linjunjie6@huawei.com>, <xuanziyang2@huawei.com>,
<zhouguoyang@huawei.com>
References: <tencent_DA7A37CEC963C36D31B0E4B959B8DE535306@qq.com>
<20220307080602.09340804@hermes.local>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/hinic: fix Tx mbuf length problem
X-User: ferruhy
In-Reply-To: <20220307080602.09340804@hermes.local>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: DB8PR06CA0048.eurprd06.prod.outlook.com
(2603:10a6:10:120::22) To PH0PR11MB5000.namprd11.prod.outlook.com
(2603:10b6:510:41::19)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4aaf315f-93f7-4b55-18ff-08da00f51ff6
X-MS-TrafficTypeDiagnostic: BL1PR11MB5954:EE_
X-Microsoft-Antispam-PRVS: <BL1PR11MB5954627DC7B387222BD9EBF395099@BL1PR11MB5954.namprd11.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1QDFy/DzFNGj/HG03v4zWvQzXWwiaiqlPDmmsr/nrDGvAKjTbskqGqaQb0C4TvI36+nicWaNKG+yYBcyQEoHRp/bjkTwc4Zk37srxH61gZvJRhK40OV9rdHXH4QQ4Bu3B4yXWtcljbDnBgYoS3ZtHMWuymBjGXH0IceTdOvY8OP/iN+1/aHF8f4HOyUbz//mhaBYVMLd4hdwSJK65Pv4cUfZZBe5GoZB/YNyt0lN2rz7QqNHti4s2649uvOs2eKjpRN4G8zzbgrXeqaUMZtxQ8gX/4BAyWXk5yxtFBfhf+nQfTYF5a4F1gXZ/koux7VJJs5yC7cnmCf1PdIf9u1rQppiKVcOa3X/IeYgMbC0KVE0eq6n2dW6GLNDDxyTiEVFuqeQ/ZI+ZQ6ITMybOUihKcbYmxoOUt4bN9UCICktlFO4OqrZLccwoWwl9hPjzRurHRPZNa5Xq0KFWniMFD2NWv8VDkJ9uChbl8VR//Da8b7peCq9jtrvBbAKLktYdS+1tI2GWl4nAa8bt2+kNz21BnHrPEYtk+dho0fKTMVrGAPUNjO8pIhIsVL80uW1CxAIKWN1ayEoYgchFH2S6NRNh3PouZKQNAVO6FcE4eetiHShymyIFiODRgwFpL00O7UT2gqBCnXmFu5z8TXy8Q3Iv/dC2GCwiSjDn8w2TWSEOorPePWddiCwahPz45rG7QBsyNsS3EyDYOz25Pja29uejg==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230001)(366004)(44832011)(5660300002)(86362001)(6506007)(53546011)(8936002)(6666004)(508600001)(4744005)(6486002)(2906002)(6512007)(186003)(26005)(66476007)(4326008)(31696002)(8676002)(66556008)(66946007)(38100700002)(2616005)(110136005)(82960400001)(316002)(31686004)(36756003)(83380400001)(45980500001);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODRianhDMlhEVFBQdlc2WXVVV294dXluU0FOQjQwYXpvVWR4cmJBZUVid0tw?=
=?utf-8?B?K0xUYzRqejZqUjgzRml6dUJDL0dEMVRVR21hY2M3TFFoVDc2TzhHaWYrRkNz?=
=?utf-8?B?RGtiSGxuMTBVSFJwWFpuOFBxaXg3NUdrRjZqZ0JnTys5S09rTVlrYXZoN0RO?=
=?utf-8?B?eTd5YlV1RDJKV1BGbHJ6dGdhRkZBanNtZzZxSXk5TjhUWnpTS2NEV3c1dG1P?=
=?utf-8?B?TnNtcWgzb0hNWG5ZYlJzaFdNbEZmK0FkRncrWEs4MXVDdVRmM1NTZVZaMkJZ?=
=?utf-8?B?dTdLNzEwNnhZMmVLUllpVk9BZWNJRFJ3R1ROMHRFZG5qYVdyN2NCTE5yd0pH?=
=?utf-8?B?ZHp2TzR6eVdpdlZZSGZRcCs5SE1qMm1YZDJLMDJpcGRoemN5STVoYjNBZUp5?=
=?utf-8?B?ek5FVXpCK21oYXZYUXU4Z0lGWG5pclFZYVlpSU94ckN2ekxSZzZrUStid2Jx?=
=?utf-8?B?OTNYN0RYcWVaOUZPYXh1SU00Vm5HMWZvM2dyb1Q1eGdwUWVuZTlnTVJZSEJV?=
=?utf-8?B?ZzJITnRRYTVXKzVFdWJpYzkzdHE1Z3ltV3JBQ2tQbkZ5dEZjU2FTanVzSngx?=
=?utf-8?B?MzJyTFowcFdTWFpGSFlqbDRxQVFxemxzTUhoY1QwL0ZDRE42VkNqQ2h6R0RV?=
=?utf-8?B?OHM3UlYxZ3hZRlZBSkgyeG9xS0JrOCt4emFDcHhwSmNBMlMycTlXT1Uzcnky?=
=?utf-8?B?QURKWUV2aXY4MmJvbytLalptU0lmMzJRVkJBZ2M2MnY5YVowSFAwbllhYXl1?=
=?utf-8?B?VVJiWVFtTmlHMitiOWp2Yk5IUVRrUFUrTzd3dnVka0svaXh2eitOdTN0dU1p?=
=?utf-8?B?em5PTFpGK3lEQTlzTEZUZUpWUVZuK1pkbjhLc0FUWm0ycXhNbGNwUHRaOHp3?=
=?utf-8?B?RFJRL1prL3B0YkM4NVhRM1NDd0JFbjFJK2NFZjlQOXI0bVVpYWgvWm5zVWF3?=
=?utf-8?B?ck9yZ1Bsck5wbDRud3RQamRvNDgxMGlUTU4xeWJvVnc2R2FxNkUzZU5uN3hQ?=
=?utf-8?B?dWxIWXNRMGRvYkZ5azNNcTB0RDRZeEx6NkNHODVyMTNkelQ5YjBiaHhsMnFY?=
=?utf-8?B?eHcwYk52RWlFdkJNWkRLMm5ENDVVcE91UXdrU0hoYmdPNlFtcDZlSUI3OWc2?=
=?utf-8?B?cFVYQnFyRyt4Mlk2cWhVR21ycXUzRlJiVXF4RU54dmtVQkt5VGV6STNKOG5C?=
=?utf-8?B?SmFTTk0vWHhJVGlXTDRsL2VKZ3gwMHl2MksvWlBFZDdCSE90VktXcE1ETFdv?=
=?utf-8?B?Smg3VWExd0pZcCtEaFUvZHEwcXdteG9EL0RJeUx5NnNvS2ErVFcvWlpKaGFS?=
=?utf-8?B?UnFDaVVycHdqeVd3cXFrajNkUDh3U0tqODh6TC9MVXVCcklJTXAxVGNyejcy?=
=?utf-8?B?Ym1vSW5DajFPbjBueWlIR2NKcHExSElmMFVyT0FRM3QxMDJ4NlJFWUV5a1B3?=
=?utf-8?B?RnpUWVBnOEh4eDdxcEwvK3VDY0dNWlh6dGdoR2NOb25yMjlObGRDclIwOWR6?=
=?utf-8?B?MlhEajdHMWN6emtZM1JKdzJYcEJ3SjRxMkI1TDlkTGcwYXRSNXVlOUdWT2N2?=
=?utf-8?B?N3pzY1hvYXpaZ2xQWTJpbUZlQUxBRHcxdEx0a0RCZkJ6UWpOcmRiYjdXd2Fi?=
=?utf-8?B?ckFTU1JVcVNoRE1XKzJuQXVFR2ZBQWNKd0w2OVhZeVRZQWNxSUh6TmE3SHBm?=
=?utf-8?B?WTZoK2JhbzFFM0xhTWUyNWVlT0Z4ekxuYnVyZE1tQ001b3BaUjdUSkhDVkpQ?=
=?utf-8?B?NXdCaElqdHIrR01tWWFpRnZvdGh5eE5LWW9PVFJoZHZhRXNCeFlVOTBrSVNC?=
=?utf-8?B?Nmh2OGJqSkQ4OVVUeGNpcThIdzBXSC9BcElRanp5S2l1a3RDNitrSElWa2lS?=
=?utf-8?B?YnlqWkErbk41YXh3QlY4K1AwOUgzSkErSnp2Rjh4MkkwcENIa3E4UzFWZEVK?=
=?utf-8?B?RVB1alZOOXlpaUdIRVJDSmVQdUNPUnlFaHNxYmcwQXg2bGxvdk5SZGI0clBO?=
=?utf-8?B?b0dFNThyUWp2WWIya0d1OVUwaEE4WEkxd28yZDFsRmgvOTBaWHd2YWlJR2xT?=
=?utf-8?B?OTBFOTF4TTB5OVhXUlY0UnRZOC9HSTE5a25laDhoWWYzTER0SnZOOFZnQm5M?=
=?utf-8?B?UEprZ1Q0T2V4ZVZ5MTgxQXNPRm1WS3lrUUp5OHM1bVY2RFdGOVdKOTBOSGhF?=
=?utf-8?Q?roblYggSWucbv3fM57bpcD4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4aaf315f-93f7-4b55-18ff-08da00f51ff6
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2022 11:16:43.4705 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cqrEbfJYmdUvSf4fCokrS8AuNrECfRNylEEiOdM2trfQgB8fzbmMeoxt40IMIisu1fUft4PcknpYPpCmnT9SOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5954
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 3/7/2022 4:06 PM, Stephen Hemminger wrote:
> On Mon, 7 Mar 2022 22:12:20 +0800
> Junjie Lin <277600718@qq.com> wrote:
>
>> From: Junjie Lin <linjunjie6@huawei.com>
>>
>> The Tx mbuf needs to be ignored if the pkt_len member is zero.
>>
>> Fixes: 54faba2295bd ("net/hinic:adds Tx queue xstats members")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Junjie Lin <linjunjie6@huawei.com>
>
> Not all drivers do this. It looks like you have a buggy application
> if it tries to send 0 length packets.
Agree, not sure if invalid packet check should be done in driver level.
Junjie, in which use case you are observing this problem?
Or in the past, I remember some PMD FW was crashing for similar
case, and check was added to protect device, do you have similar
problem?