From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB5EFA09E9; Wed, 9 Dec 2020 01:21:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C748C914; Wed, 9 Dec 2020 01:21:57 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 45124C912 for ; Wed, 9 Dec 2020 01:21:54 +0100 (CET) IronPort-SDR: QPFC/eJRtzktbepiSTq3GQc0GLqSxEOeTzXahLhSEFoGnoc20Wc+6ZNabwps1v11E/Qr7/WHvL reJQREd79n0A== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="173233431" X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="173233431" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 16:21:53 -0800 IronPort-SDR: icClSDZhIVQkEgrwNPSDWl2mlqaZOyraLxW1FyJSXMxMENyAVelP1FhOT9TlBhPp2+xi+awoIb DU6xFp3gNPtA== X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="370592456" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.209.7.12]) ([10.209.7.12]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 16:21:52 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, talshn@nvidia.com, ferruh.yigit@intel.com, beilei.xing@intel.com, jia.guo@intel.com References: <20201205011020.6276-1-pallavi.kadam@intel.com> <20201205011020.6276-3-pallavi.kadam@intel.com> <1656459.hZBu3j2uRN@thomas> From: "Kadam, Pallavi" Message-ID: <3fdb608d-1fb2-a307-8bbb-3878f7a1f38b@intel.com> Date: Tue, 8 Dec 2020 16:21:52 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <1656459.hZBu3j2uRN@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/6/2020 7:49 AM, Thomas Monjalon wrote: > 05/12/2020 02:10, Pallavi Kadam: >> --- a/drivers/net/meson.build >> +++ b/drivers/net/meson.build >> @@ -1,9 +1,6 @@ >> # SPDX-License-Identifier: BSD-3-Clause >> # Copyright(c) 2017 Intel Corporation >> >> -if is_windows >> - subdir_done() >> -endif >> >> drivers = ['af_packet', >> 'af_xdp', >> @@ -56,6 +53,12 @@ drivers = ['af_packet', >> 'virtio', >> 'vmxnet3', >> ] >> + >> +if is_windows >> + drivers = ['i40e', >> + ] >> +endif > Let's not add an alternative list please. > I prefer disabling compilation in other drivers. > > >> --- a/lib/librte_eal/common/meson.build >> +++ b/lib/librte_eal/common/meson.build >> @@ -33,6 +33,7 @@ if is_windows >> 'malloc_heap.c', >> 'rte_malloc.c', >> 'eal_common_timer.c', >> + 'rte_random.c', >> 'rte_service.c', >> ) >> subdir_done() >> diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def >> index 89166acd7..428201872 100644 >> --- a/lib/librte_eal/rte_eal_exports.def >> +++ b/lib/librte_eal/rte_eal_exports.def >> @@ -124,6 +124,7 @@ EXPORTS >> rte_memzone_reserve_bounded >> rte_memzone_walk >> rte_openlog_stream >> + rte_rand >> rte_realloc >> rte_rtm_supported >> rte_service_attr_get >> diff --git a/lib/librte_eal/windows/include/rte_windows.h b/lib/librte_eal/windows/include/rte_windows.h >> index b82af34f6..822922c11 100644 >> --- a/lib/librte_eal/windows/include/rte_windows.h >> +++ b/lib/librte_eal/windows/include/rte_windows.h >> @@ -18,6 +18,11 @@ >> #define WIN32_LEAN_AND_MEAN >> #endif >> >> +#ifdef __clang__ >> +#undef _m_prefetchw >> +#define _m_prefetchw __m_prefetchw >> +#endif > > These changes are not specific to i40e, please separate. Ok, will create a separate patch in v2. This change is required once we add rte_random.c file on windows. So, may be addition of rte_random.c file and this change should go together? Please suggest. Thanks, > >