From: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
To: "Morten Brørup" <mb@smartsharesystems.com>, dev@dpdk.org
Subject: Re: rte_ring_elem_pvt historical question
Date: Tue, 5 Jul 2022 09:54:55 +0100 [thread overview]
Message-ID: <3fefdb57-1b62-71d7-48f1-6d2332dd423f@yandex.ru> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D871A5@smartserver.smartshare.dk>
04/07/2022 12:35, Morten Brørup пишет:
> Does anyone here remember why the __rte_ring_enqueue/dequeue_elems_64/128() functions support unaligned object arrays, when the __rte_ring_enqueue/dequeue_elems_32() functions require 4 byte aligned object arrays?
As I remember, we added 'unaligned' to be able to use rte_ring with
elements that might have smaller alignment.
For 32 - as I remember we never explicitly require 4B aligned
objects for the rings ... Am I missing something here?
My guess, we just never hit such problem so it gets unnoticed.
Probably worth updating 32-bit version too with explicit 'unaligned' type.
>
> I'm wondering if the compiler could do better with a simpler implementation than the manually implemented loop unrolls, and if the unalignment silliness would stand in the way.
>
> Med venlig hilsen / Kind regards,
> -Morten Brørup
>
next prev parent reply other threads:[~2022-07-05 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 11:35 Morten Brørup
2022-07-05 8:54 ` Konstantin Ananyev [this message]
2022-07-05 13:40 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fefdb57-1b62-71d7-48f1-6d2332dd423f@yandex.ru \
--to=konstantin.v.ananyev@yandex.ru \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).