From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 70F0FB0A5 for ; Wed, 21 May 2014 18:07:33 +0200 (CEST) Received: by mail-wi0-f174.google.com with SMTP id r20so7972237wiv.1 for ; Wed, 21 May 2014 09:07:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=fpDbZK+ObYa0ZOzwRKchlB7+soms5PCKsyYr3ubOPRs=; b=S+/L8brHhKiWlubMaXp/e6mxv56vJ5gmaVDLD4PevNiqH4vPWYHMWJpHjQvkZfXr/h OGSm8ZJ2Cvlq8TAtNmlVkdwnHwKxXweXyvx8Dk7F5pISnaRO6hIazLTXfIxxzp7SrIKw gT3YFEtIsPfSxPMXNgj+tWOZrsp3tbCM9qiL+w48rvwLW1ew4eXZFq5TE9L0QdSHTWmd fKFh7pwWRr2BY0QopXPg5CHOCfnelZOiFamF7xCQ2YlWMYkcZtPLWeLrxEWw9d4zLniR 1jBquRxcvKtLVo5UDKrlc34qE4YCpPEh++ai8I+JOKcnvWYp1PwdHeBOJWqaxbRuDn8O F2xw== X-Gm-Message-State: ALoCoQnYt2weQazOwya7frYs3mstsqSh9Of8WSHy6tjYXo+OduzazxvyGn9l4hDvt05SaUD7EfKm X-Received: by 10.194.188.68 with SMTP id fy4mr44321233wjc.30.1400688461816; Wed, 21 May 2014 09:07:41 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id ph8sm23091769wjb.32.2014.05.21.09.07.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 May 2014 09:07:40 -0700 (PDT) From: Thomas Monjalon To: Anatoly Burakov Date: Wed, 21 May 2014 18:07:37 +0200 Message-ID: <4002874.rX8l5tMzHC@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400514709-24087-8-git-send-email-anatoly.burakov@intel.com> References: <1400514709-24087-8-git-send-email-anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 07/16] Add support for VFIO interrupts, add VFIO header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 May 2014 16:07:33 -0000 2014-05-19 16:51, Anatoly Burakov: > Creating code to handle VFIO interrupts in EAL interrupts, and also > adding a header eal_vfio.h. Maybe it's better to have 2 patches here. > This header checks two things: > * checks if CONFIG_RTE_EAL_VFIO was enabled during build time > * checks that kernel version is 3.6+ so that DPDK would still compile > on older kernels despite VFIO compilation being enabled by default. In case VFIO is backported on older kernel, it would be better to check a related macro instead of Linux version. > This header also defines a VFIO_PRESENT macro, which should be used to > conditionally compile all the VFIO code. This is because having > CONFIG_RTE_EAL_VFIO enabled doesn't guarantee that the VFIO support is > compiled in, because we're still dependent on kernel version. > > Signed-off-by: Anatoly Burakov > + struct vfio_irq_set * irq_set; There few lines like this one where checkpatch.pl reports an error: ERROR: "foo * bar" should be "foo *bar" Thanks -- Thomas