From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 25F5718F for ; Mon, 15 Dec 2014 15:17:07 +0100 (CET) Received: by mail-wi0-f172.google.com with SMTP id n3so9003314wiv.11 for ; Mon, 15 Dec 2014 06:17:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=7fBtqgzbqHLtIzKEql3+ucTHF4Vz353Hx7hzjsgF42U=; b=jxZbWULIK1+EjJe+0nqNzVmOicS85m/8b5dTR6M2CKnmStVSQFnZJaZrdkvRlERN+Z BQv0OSMCFY5tl0Lf28fsn6A4/ewVlZEhMjKOFCj3lj74TCfXc3yohwL9hFZlXBQCBoAj tnSUPNC/4V3jJL9qovsX33wriozLUhS2dYATKsPGHlqdVhJcOtlC4mboIJGsv8SpTaJg FFUIRN13BOC/wWm2EZmWlTooCA7VzmUOmOy71LvQku+/R8f9KSEJrxF5Qzlztobx9UGl Tx+x/EQeO6uC0QtUM7vsPVBBm1DK1GWuS8vyRpXcOj3e7fsq6KSLt6C2HSPLRCVfhwst RFPg== X-Gm-Message-State: ALoCoQmThP+l8xYS4NogYdPHC+IWcdWO80T6Qbi3xjyGRjniQHDljDjhnlY0gbpXHuf02DUm9Fem X-Received: by 10.180.83.228 with SMTP id t4mr32499724wiy.28.1418653026938; Mon, 15 Dec 2014 06:17:06 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id je12sm13409213wic.22.2014.12.15.06.17.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Dec 2014 06:17:06 -0800 (PST) From: Thomas Monjalon To: "Wodkowski, PawelX" Date: Mon, 15 Dec 2014 15:16:42 +0100 Message-ID: <4008093.EPhAooubXd@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <533710CFB86FA344BFBF2D6802E60286C9D989@SHSMSX101.ccr.corp.intel.com> <3427289.cFFhb9tNHS@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] error: value computed is not used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Dec 2014 14:17:07 -0000 2014-12-15 13:47, Wodkowski, PawelX: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2014-12-15 11:27, Wodkowski, PawelX: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > 2014-12-08 15:26, Wodkowski, PawelX: > > > > > From: Qiu, Michael > > > > > > On 2014/12/8 19:00, Wodkowski, PawelX wrote: > > > > > > >> lib/librte_pmd_enic/enic_main.c: In function 'enic_set_rsskey': > > > > > > >> lib/librte_pmd_enic/enic_main.c:862:2: error: value computed is not > > used > > > > > > >> > > > > > > >> I dig out that, it was ome issue of the macros rte_memcpy() > > > > > > >> #define rte_memcpy(dst, src, n) \ > > > > > > >> ((__builtin_constant_p(n)) ? \ > > > > > > >> memcpy((dst), (src), (n)) : \ > > > > > > >> rte_memcpy_func((dst), (src), (n))) > > > > > > >> > > > > > > >> When I use only (n) instead of (__builtin_constant_p(n), it will pass( I > > > > > > >> know that it was incorrect, just a experiment). > > > > > > >> > > > > > > >> But I try to use inline function instead of macros: > > > > > > >> static inline void * rte_memcpy(void *dst, const void *src, size_t n) > > > > > > >> { > > > > > > >> return __builtin_constant_p(n) ? memcpy(dst, src, n) : > > > > > > >> rte_memcpy_func(dst, src, n); > > > > > > >> } > > > > > > >> > > > > > > >> It will pass:), and works, this could be one potential workaround fix. > > > > > > >> > > > > > > >> Who knows why? The root cause is what? > > > > > > >> > > > > > > >> I've no idea about this. > > > > > > >> > > > > > > > I got the same issue while ago. I don't remember exactly everything > > > > > > > but my conclusion was that there was some bug in compiler. I think, > > > > > > > when 'n' I constant and/or small compiler is inlining memcpy and > > throwing > > > > > > > everything else (including returned value). In that case error is not > > > > > > > produced (I think this is a bug in compiler). In other case it is computing > > > > > > > some value calling memcpy or rte_ memcpy and you should at least > > > > > > > explicitly throw it away by casting to void. I like solution with static > > > > > > > > > > > > Actually, I try to pass "n" as a Int value like 4, it still report this > > > > > > error :) > > > > > > > > > > My workaround was: > > > > > (void) rte_memcpy(...); > > > > > > > > > > But this is only a workaround. > > > > > > > > It's not so bad. > > > > > > > > > > > inline but someone else should spoke about possible side effects. > > > > > > > > > > > > Yes, but as I know inline is better than macros. > > > > > > > > From the GCC manual: > > > > " > > > > You may use this built-in function in either a macro or an inline function. > > > > However, if you use it in an inlined function and pass an argument of the > > > > function as the argument to the built-in, GCC never returns 1 when you call > > > > the inline function with a string constant or compound literal and does not > > > > return 1 when you pass a constant numeric value to the inline function unless > > > > you specify the -O option. > > > > " > > > > > > > > It seems the "inline fix" cannot be used. > > > > > > > > I'm going to send a patch with Pawel's workaround. > > > > > > And something like this? > > > > > > #define rte_memcpy(dst, src, n) \ > > > - ((__builtin_constant_p(n)) ? \ > > > + ({ (__builtin_constant_p(n)) ? \ > > > memcpy((dst), (src), (n)) : \ > > > - rte_memcpy_func((dst), (src), (n))) > > > + rte_memcpy_func((dst), (src), (n)); }) > > > > What happens to the returned value after this change? > > ptr = rte_memcpy(dst, src, n) + offset: > > > https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html#Statement-Exprs > > Whole expression should be 'void *' type (like *memcpy()) and it should work > as usual (see maxint() example in above link). It is GCC extension. OK nice. I didn't test it on SUSE 11 SP3. I assume you did it? Please Pawel, could you send a proper patch quickly? If nobody disagree, it'll be merged in RC5 today. > > > Thomas, can you check build with EXTRA_CFLAG='-Wunused-value'. > > > > You mean EXTRA_CFLAGS (with a S). > > It fails in many locations. > > What's your point? > > I am just asking if this is an typo, error or intend to do statements with no effects like bellow. > > ixgbe_common.c:4429:3: error: statement with no effect [-Werror=unused-value] > > 4426: /* first pull in the header so we know the buffer length */ > 4427: for (bi = 0; bi < dword_len; bi++) { > 4428: buffer[bi] = IXGBE_READ_REG_ARRAY(hw, IXGBE_FLEX_MNG, bi); > 4429: IXGBE_LE32_TO_CPUS(&buffer[bi]); // <------ here > 4430 } It's an intent. On big endian CPU, this has an effect. > > Do you to support -Wunused-value? > > No, I just turned this on to check above change and was surprised what happened. Honestly, I don't know if there is a good fix for this warning. -- Thomas