From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5A6D11B202 for ; Tue, 10 Oct 2017 01:12:18 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 09 Oct 2017 16:12:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,501,1500966000"; d="scan'208";a="908332826" Received: from unknown (HELO [10.241.225.162]) ([10.241.225.162]) by FMSMGA003.fm.intel.com with ESMTP; 09 Oct 2017 16:12:16 -0700 To: Stephen Hemminger , dev@dpdk.org Cc: Stephen Hemminger References: <20170927092320.6837-1-stephen@networkplumber.org> From: Ferruh Yigit Message-ID: <40111fb2-af2a-6015-9dab-37a59f4e5894@intel.com> Date: Tue, 10 Oct 2017 00:12:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170927092320.6837-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: increase length device internal name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 23:12:19 -0000 On 9/27/2017 10:23 AM, Stephen Hemminger wrote: > Allow sufficicent space for UUID in string form (36+1). > Needed to use UUID with Hyper-V. This was in deprecation notice > for previous release and make it so in 17.11. > > Signed-off-by: Stephen Hemminger Except from below note, Reviewed-by: Ferruh Yigit > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > lib/librte_eal/common/include/rte_dev.h | 6 +++++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 3362f33501dd..ba5b68e70098 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -120,3 +120,6 @@ Deprecation Notices > The non-"do-sig" versions of the hash tables will be removed > (including the ``signature_offset`` parameter) > and the "do-sig" versions renamed accordingly. > + > +* ethdev: in 17.11 the size of internal device name is increased > + to 64 characters to allow for storing longer bus specific name. There is already a deprecation notice added in previous release for this release. Since this patch implements it, notice should be removed, instead of adding new one. > diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h > index 5386d3a28be5..4c4ac7e5d375 100644 > --- a/lib/librte_eal/common/include/rte_dev.h > +++ b/lib/librte_eal/common/include/rte_dev.h > @@ -152,7 +152,11 @@ struct rte_driver { > const char *alias; /**< Driver alias. */ > }; > > -#define RTE_DEV_NAME_MAX_LEN (32) > +/* > + * Internal identifier length > + * Sufficiently large to allow for UUID or PCI address > + */ > +#define RTE_DEV_NAME_MAX_LEN 64 > > /** > * A structure describing a generic device. >