From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Dumitru Ceara <dceara@redhat.com>, dev@dpdk.org
Cc: bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/ring: advertise multi segment support.
Date: Tue, 22 Sep 2020 15:21:25 +0100 [thread overview]
Message-ID: <40128dc3-e379-6916-67fa-69b4394cac0a@intel.com> (raw)
In-Reply-To: <1600425415-31834-1-git-send-email-dceara@redhat.com>
On 9/18/2020 11:36 AM, Dumitru Ceara wrote:
> Even though ring interfaces don't support any other TX/RX offloads they
> do support sending multi segment packets and this should be advertised
> in order to not break applications that use ring interfaces.
>
Does ring PMD support sending multi segmented packets?
As far as I can see ring PMD doesn't know about the mbuf segments.
>
> Signed-off-by: Dumitru Ceara <dceara@redhat.com>
> ---
> drivers/net/ring/rte_eth_ring.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
> index 733c898..59d1e67 100644
> --- a/drivers/net/ring/rte_eth_ring.c
> +++ b/drivers/net/ring/rte_eth_ring.c
> @@ -160,6 +160,7 @@ struct pmd_internals {
> dev_info->max_mac_addrs = 1;
> dev_info->max_rx_pktlen = (uint32_t)-1;
> dev_info->max_rx_queues = (uint16_t)internals->max_rx_queues;
> + dev_info->tx_offload_capa = DEV_TX_OFFLOAD_MULTI_SEGS;
> dev_info->max_tx_queues = (uint16_t)internals->max_tx_queues;
> dev_info->min_rx_bufsize = 0;
>
>
next prev parent reply other threads:[~2020-09-22 14:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 10:36 Dumitru Ceara
2020-09-22 14:21 ` Ferruh Yigit [this message]
2020-09-28 7:31 ` Dumitru Ceara
2020-09-28 10:25 ` Ferruh Yigit
2020-09-28 11:00 ` Ananyev, Konstantin
2020-09-28 12:42 ` Ferruh Yigit
2020-09-28 13:10 ` Ananyev, Konstantin
2020-09-28 13:26 ` Ferruh Yigit
2020-09-28 13:58 ` Dumitru Ceara
2020-09-28 15:02 ` Ferruh Yigit
2020-09-28 11:01 ` Bruce Richardson
2020-09-28 12:45 ` Ferruh Yigit
2020-09-28 18:47 ` [dpdk-dev] [PATCH v2] net/ring: advertise multi segment TX and scatter RX Dumitru Ceara
2020-09-29 8:37 ` Bruce Richardson
2020-09-30 17:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40128dc3-e379-6916-67fa-69b4394cac0a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dceara@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).