From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26BF8A04B6; Tue, 22 Sep 2020 16:21:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07BF31C132; Tue, 22 Sep 2020 16:21:43 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 89A0B1C128 for ; Tue, 22 Sep 2020 16:21:41 +0200 (CEST) IronPort-SDR: FV+nmMAC5KxCuf9mf3BeODYBET4iyz81FmMAjr4DdbcCmkqCvbZzVc3HIY/Ut4LlYc4DXJ0HAK 5MIqNwNR4J5Q== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="157988050" X-IronPort-AV: E=Sophos;i="5.77,291,1596524400"; d="scan'208";a="157988050" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 07:21:34 -0700 IronPort-SDR: YrdOTkeRLF9FZqhrBDeasFG0YaMFU7vYGtfMcxlO2Iy0aAvweMXXL8JQKocQblulWGBEz6rYiP jl3841LzL2PA== X-IronPort-AV: E=Sophos;i="5.77,291,1596524400"; d="scan'208";a="454504898" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.201]) ([10.213.227.201]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 07:21:29 -0700 To: Dumitru Ceara , dev@dpdk.org Cc: bruce.richardson@intel.com References: <1600425415-31834-1-git-send-email-dceara@redhat.com> From: Ferruh Yigit Message-ID: <40128dc3-e379-6916-67fa-69b4394cac0a@intel.com> Date: Tue, 22 Sep 2020 15:21:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <1600425415-31834-1-git-send-email-dceara@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/ring: advertise multi segment support. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/18/2020 11:36 AM, Dumitru Ceara wrote: > Even though ring interfaces don't support any other TX/RX offloads they > do support sending multi segment packets and this should be advertised > in order to not break applications that use ring interfaces. > Does ring PMD support sending multi segmented packets? As far as I can see ring PMD doesn't know about the mbuf segments. > > Signed-off-by: Dumitru Ceara > --- > drivers/net/ring/rte_eth_ring.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c > index 733c898..59d1e67 100644 > --- a/drivers/net/ring/rte_eth_ring.c > +++ b/drivers/net/ring/rte_eth_ring.c > @@ -160,6 +160,7 @@ struct pmd_internals { > dev_info->max_mac_addrs = 1; > dev_info->max_rx_pktlen = (uint32_t)-1; > dev_info->max_rx_queues = (uint16_t)internals->max_rx_queues; > + dev_info->tx_offload_capa = DEV_TX_OFFLOAD_MULTI_SEGS; > dev_info->max_tx_queues = (uint16_t)internals->max_tx_queues; > dev_info->min_rx_bufsize = 0; > >