From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8B9441B1C4; Fri, 29 Jun 2018 02:02:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2ED1F21D19; Thu, 28 Jun 2018 20:02:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Jun 2018 20:02:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=tLytGYr2s6lCIMT+PYKiF98FUB IGmhqcmGRIqkWCxtk=; b=HTyVPBlPMPRBs0lYNOfaE0wqBothMrTXFAzmEtWAfW QaFApcmdMgKhjEzCQVuXpVfa55u8YYVR7X0tCa+0Z0E+hyUevqlPSgsq3HjOpGAI eRn0RlfaU30sjTz8odv3nVMxl4oYXjhZ8uaQM7l8s/pLye6HIGIWwesxmdWL3A3f A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=tLytGY r2s6lCIMT+PYKiF98FUBIGmhqcmGRIqkWCxtk=; b=UqLT0qfcnbDO9X1ulxoep1 QDyKCCIQ1d04H6qdpagbu9cmzjOwg04kadqP/iQ+vfwRGcsS1MgyPuIz2rZJmwJL pC+KfMeiesjeoxal+BN2pUBYHTNdwwQG6LNlxmDu9bzmWYTfYtdOiQu1nl8Nwlo4 ws6fLwbI2SOCa1H9vNZ8eO9rp98K00+7LMPSZhgN8xbr3si9dJl/n8NH9UDkMseS sZ8IbM/a724kbjkP3KSVnN3eF4RNeoEqqJ364cwzduQNy8lKB+W0dLT3oXcEUl2x +Q7tbu/4RiK47qDVLwkrfyJT0X3/otI+0Vys9v6KY/+cYtBbrhqOD6098Ay0sqvA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EF3AD1027B; Thu, 28 Jun 2018 20:02:39 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: stable@dpdk.org, "Zhang, Qi Z" , "dev@dpdk.org" Date: Fri, 29 Jun 2018 02:02:38 +0200 Message-ID: <4017209.qn6vUfZg5o@xps> In-Reply-To: <039ED4275CED7440929022BC67E706115323F36E@SHSMSX103.ccr.corp.intel.com> References: <164824cc66c16755416bb8d3d6911385f52f8c1e.1530092380.git.anatoly.burakov@intel.com> <039ED4275CED7440929022BC67E706115323F36E@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] ipc: fix locking while sending messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 00:02:41 -0000 27/06/2018 14:25, Zhang, Qi Z: > From: Burakov, Anatoly > > > > Previously, we were putting an exclusive lock to prevent secondary processes > > spinning up while we are sending our messages. However, using exclusive > > locks had an effect of disallowing multiple simultaenous unrelated > > messages/requests being sent, which was not the intention behind locking. > > > > Fix it to put a shared lock on the directory. That way, we still prevent > > secondary process initializations while sending data over IPC, but allow > > multiple unrelated transmissions to proceed. > > > > Fixes: 89f1fe7e6d95 ("eal: lock IPC directory on init and send") > > Cc: stable@dpdk.org > > > > Signed-off-by: Anatoly Burakov > > Tested-by: Qi Zhang > > Thanks for the quick fix! > Qi Applied, thanks