DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Gaoxiang Liu <gaoxiangliu0@163.com>,
	chas3@att.com, humin29@huawei.com, kiran.kn80@gmail.com,
	nandu.rangaswamy@gmail.com
Cc: dev@dpdk.org, liugaoxiang@huawei.com, stable@dpdk.org
Subject: Re: [PATCH v2] net/bonding: failover of LACP with mode 4 takes long time
Date: Wed, 17 Apr 2024 14:16:34 +0100	[thread overview]
Message-ID: <401aec2e-de31-4c6f-b9c3-d59109e1f8f4@amd.com> (raw)
In-Reply-To: <58328abb-1249-4eb6-a625-91cb149496ca@amd.com>

On 4/16/2024 4:44 PM, Ferruh Yigit wrote:
> On 6/6/2022 3:34 PM, Gaoxiang Liu wrote:
>> When the primary port of bond slaves with bond mode 4 linked down,
>> the system id of the other slave ports channged.
>> It may cause some switches to renegotiate,
>> and the process takes a few seconds. It is not acceptable for any
>> Telcos.
>> We need sub-second switchover time like in linux.
>>
>> Set the mac of the bond port to the slave port's system to solve the
>> problem.
>>
>> Bugzilla ID: 551
>> Fixes: 46fb43683679 ("bond: add mode 4")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Gaoxiang Liu <liugaoxiang@huawei.com>
>>
>>
> 
> This is another old patch, as far as I can see from bugzilla, the patch
> the issue is reported by Kiran and proposed by Nandu, and shared in mail
> list by Gaoxiang.
> 
> As it is addressing two bugzilla items, and we are at the beginning of
> the release cycle, I am willing to take risk and apply this patch
> without ack from a bonding maintainer.
> If we found some issues we can revert this back.
> 
> Chas, Connor, if you have any objection, or if you need time for review
> please let me know, otherwise I will merge the patch soon.
> 
> And if anyone can provide test, like Kiran who reported the issue, or
> any other stakeholder, it helps a lot to give confidence to the fix.
> 

Applied to dpdk-next-net/main, thanks.


Please help on verifying the patch.


      reply	other threads:[~2024-04-17 13:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-05  3:07 [PATCH] " Gaoxiang Liu
2022-06-06 14:34 ` [PATCH v2] " Gaoxiang Liu
2022-06-09  8:28   ` Andrew Rybchenko
2024-04-16 15:44   ` Ferruh Yigit
2024-04-17 13:16     ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=401aec2e-de31-4c6f-b9c3-d59109e1f8f4@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=chas3@att.com \
    --cc=dev@dpdk.org \
    --cc=gaoxiangliu0@163.com \
    --cc=humin29@huawei.com \
    --cc=kiran.kn80@gmail.com \
    --cc=liugaoxiang@huawei.com \
    --cc=nandu.rangaswamy@gmail.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).