From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E58D743E92; Wed, 17 Apr 2024 15:16:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6013840E09; Wed, 17 Apr 2024 15:16:42 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2071.outbound.protection.outlook.com [40.107.220.71]) by mails.dpdk.org (Postfix) with ESMTP id 43A1A402AE; Wed, 17 Apr 2024 15:16:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h8ov8fz5ZK9xUrETXKr078t/fKTSmIjVMBtPqgDfNOmrB5APChaOpLcBu693jjwN7KL1nKOucChcIyMSEJlHa5VW+uyos1CBbOzgXBJJ3YlbWWA6v2up+9TUT5OHQU8JmJ62VsEAFBrhlEnlszx2/UxKcociT24A8ZGLTdr+p1SfbCfq+vlZNVhKLeHs+mb3zvCScfurwgpuedE6ai+gNedyqdqoKVbof2HxatVcOlXkO41wV8Bga/wEubVmMgZfvCkCigUDVFc9jmlLEpgGipRzrwfyEPEvepTHG/6PlPIbK1RTl/XZMIXWp2AVI+SY/GPMkaZAz1HVbsQmYeod+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gTcjFioeFZwJjsDi/J7BJGx+f0uYYZ/lYJtEt11Vpjw=; b=P+5wTiqkscvJZGQxM5Oo8LjEAf0FHAlXbU1oJvkTqnHydFqQHLibng3bIXWk+Id5pDPteKFITHb3USXiVapBCmXwUCs7WfdPS+S0nZely89upBP67W1T7uTlXETia8rThDnvZUW6YzuTXRGLWDlDOg599KBmu24pFLuHIPHLfYpMRm/p3XPvX4agun3rdh59dU717mvaBUmFZzJCfvGmCpX8ksLMCdkCOH6Dcu3oW0ZbzTnGowu3w2OhrXyJ8sTJ7jN2C8JUvPfbIrgUjAtgqG94HGKMT0kdIGIe0G89BiGkjloa7SKgp69Gy+lm95++hdSJZaG35VSGMAzW/B1hug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gTcjFioeFZwJjsDi/J7BJGx+f0uYYZ/lYJtEt11Vpjw=; b=2rbmzeEI90h5MBjKnViDmaedn9aKHJa+otjc6mbADxOFso+/NR/e7kQou0xTfHTYY0hce1JbzbrbnCBnki0F9M/Ac30m55b3B+eCRwrBljn12MAujB1LIjoozKldwXO45HdchXU0YpAoCcnUaxRlu6dQShGDxl0ZB1UojdiPs3g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA3PR12MB8440.namprd12.prod.outlook.com (2603:10b6:806:2f8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.49; Wed, 17 Apr 2024 13:16:38 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7452.049; Wed, 17 Apr 2024 13:16:38 +0000 Message-ID: <401aec2e-de31-4c6f-b9c3-d59109e1f8f4@amd.com> Date: Wed, 17 Apr 2024 14:16:34 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net/bonding: failover of LACP with mode 4 takes long time From: Ferruh Yigit To: Gaoxiang Liu , chas3@att.com, humin29@huawei.com, kiran.kn80@gmail.com, nandu.rangaswamy@gmail.com Cc: dev@dpdk.org, liugaoxiang@huawei.com, stable@dpdk.org References: <20220605030737.4670-1-gaoxiangliu0@163.com> <20220606143445.501-1-gaoxiangliu0@163.com> <58328abb-1249-4eb6-a625-91cb149496ca@amd.com> Content-Language: en-US Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <58328abb-1249-4eb6-a625-91cb149496ca@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0006.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA3PR12MB8440:EE_ X-MS-Office365-Filtering-Correlation-Id: 39ae0ce4-ccdf-4f40-1e9e-08dc5ee09d2e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2yTAEMh/iabo6K7/aLApSiFpVCK27T4VmxUG+7N3mRb1fFCF2ajx9htwfApYmzxgk+SsVTyl+WxKTgp4lgj8FrS+U/Kw03gjDcDT4DF61ZeVARCFmiufm+6dvFAag+O87/JNQ1GZUP4Y42klCUYrh1kxMHtZV1ZhfVbOmBIdXCbfCClJ6xvYCchgJGjYGI8RpynCTX8Lu4PYV9IODdKsAsV6CVCRCAJDXH451onbfbsOJveyaqIZ6p6+GOvv233Y3/Nl8rK1XoO+BT1IC59kAx9oE0ozyBdP+CX/D8V9zBTYtdNsS8i5Jcs6CKuAxQ8U1kwf/31O1RcAnsqJG69/VsGlVrZtYJz5DzPZz4p1ODwEK5mkTkF8Kpa+v6ZJrijjadZ4ptKfQ5IP4PRqFVOoUaMu1UtwIcnfY4V6rFpmgnNrExhLoesaUupeGJcsTkC9Wdej5Di2aK0GHSqeHjsHuDQXQRvRzZjCWp9e0iezpEwQjYNYD82o9+i7t49gzdTkYzLnipyxy9q43YMEpm7LgfCHLcVSP5uGsXIi5iDfxsd20uHAPcoy9biZ9GEJCY+4v4Ou77eEI8acG9/JG9MyYurLW0Hew1Z3YVRtQdQwxZVhEZMMQRUUnUA+m8yLKXYxqpCtrxjAoVmwZmtCAugVtOjiDHT789gxIydcG4tJrd8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmJpSnJyR1A1VXEvQlJKRTcrRnZZSlJzVjV2eTF2TG85ZkxTd3E5TDBFWHFO?= =?utf-8?B?cVZtVzFNNVJrK2NPYXo5em50ZW12YnVSNzg2M0k0Y2JaK0wrMC9xQVVxVHVn?= =?utf-8?B?MlRCcWQvOW0zNytjTW9vVDkxT1h4VUZscDBrZVl1ckhRVGNYMCtGMlZVcGxC?= =?utf-8?B?RjlSVzArb3oraWtNMVFhTzlrK3UrL2ZDZWIrcXZIQkVNcnZncEtIWmRMc3k2?= =?utf-8?B?MXJ0V1IxV0F0UklXWWNuNFowSTA4OEduV3M3Y1NGcnVQYkRmb1gwOHdSMXlH?= =?utf-8?B?UnYyY3NETUU3R25Ja2YxbURsbEpGbnl0djFyM1I5OUxhS00wbEtBZzdERUNK?= =?utf-8?B?YitJSDNmUFpaODJJaUNvWjJISkdaS0hXTGtuYXBtRE95RVNaeWxDalNPZ2t3?= =?utf-8?B?SUxTNXFFU0NoTVR1ckk4RlZVQlAwS2FDcjJVbS9ScmdzcCs5QXNqSDAzYkVl?= =?utf-8?B?UU1RSUo2bk9reU1oWGJVODlOQ2ZDUTlCV3EyVUdreU93Y1JDZ25nMzF2L3Ji?= =?utf-8?B?RlJPYUxKc0xyMldQcThNRkZaTzhyQ01wNGtPM0k0WEovQjdxWHVyckJPVW94?= =?utf-8?B?NlJjaHZWa3E2bk1lSEU5M0FIUU0wdEdKZ3N2ZjN3VjJYbXJRTVZYWFNNdUFG?= =?utf-8?B?TVVIWkg1RUVmYW1qTDlMMmlaK25wbWYxVy83K3paV2ZFaE80WlgzU1JCTUVP?= =?utf-8?B?Ui9CYVYvZ0F4UG41dUVMZEY2cis2UTV3MkxRUzFsanpxUDV4cjZnSy9GQ09n?= =?utf-8?B?Zzk1eU5iaS96SHRXUVFjWXlWUEJNdStFNEZpOTl4eVRxa1hRMEY3dlJ4ZWl0?= =?utf-8?B?WGxjOGVZVmFYT1FFVlg4VjloSUtjWGxMTzNqT1l2U24yR2FNKytmSzM2SnNF?= =?utf-8?B?SlEvaVFsb2MrU2hXbmVoVlc3azVHNEdYVm5QNmxYK0tJY0laVUpDdm1GYS9u?= =?utf-8?B?NnFhMEdhS1BNR2FRNGlrU3FrSktOMnNGdzdjZWRrYUVmYTdjR0J5ZnJ4N05G?= =?utf-8?B?VlVnWEhZT2J2ZUVNZUhya1FQeDZwbnNKejFkSS8yK1FZeGQ0SEZ5M1lKK3Y3?= =?utf-8?B?b1RTNEZ1b3NqektkSHcvbklrbjJMS0lQL1pZTlRyNU1Xa1dVYU5qQ0Ztd05w?= =?utf-8?B?M3cvbU1CQkltZUpIdndKNTFNK25GTVNLVzF3Ujl4WWhZOVJCcGd3SVFOMUJk?= =?utf-8?B?N3orQ3hhVDhCMnRHV1hrbDZiSGpkY1pjV1Y3S25XSThzOHRZdjg4VDhVM2dB?= =?utf-8?B?amJ4U2xFT20xZEIrK3NWSmtPM1R3RXR1YkhwUlZycFFWZ0c3a2srRE8rRkZF?= =?utf-8?B?aXhyTFR4OHIzY1kvTDFTYUpyTHE2V251bUJ6cElUMWE2UnVLaTdta3ZDL2N1?= =?utf-8?B?UFRKU2pWK0RpRmsxVjlSU2NzRzVHbnlGMUdYVVJSQVFpNEN5cGF3VVlnVHVR?= =?utf-8?B?TTJGUjZNRFhqbzJpYlc0MkdrYy9DbDhpWEJVT3I5NEVYSnpqcklyTnVJTjVu?= =?utf-8?B?elc3S21uaDRITExKenlRa2dTS3hYSnhoVzVtTWZrOXdZRm16VHRpNkFhYkdB?= =?utf-8?B?Q3hpTVVaRHo2WTRCZ2dsZVZnVEZUeGJtTEpyZDFzOHp0OGtmdERCNGo4aERr?= =?utf-8?B?V0ZlZDlHWlJENkovRThML3d3MDljZnpZZU0wSTJVUlExQlp4c1hqRFNlZDBW?= =?utf-8?B?UnhQUHdaWVFrcm9RbmU4RVpTNG0rMC9Gd081UExGZEIrRGR1ek9aR1cwdi82?= =?utf-8?B?VGMyY1FiN0FDa0Vzbko0R1Rpa1h2MngvWk9XRVhGK1c4SnFwMGhuZVZlcnhF?= =?utf-8?B?REFwQUR1OXpndTlQV0U5YmhUNXM1NFBacFdER1Z0SzdnZnBrZHpSWUNHWWt1?= =?utf-8?B?ZDFCeDUzckx1bFhPVkhsOFR2clFKaTFyZFhEUkNjTGdEb2FtSWdPaml4RWs2?= =?utf-8?B?MkllM29xelVYZUxPYlJ3NGExN0s3K0NIQ1dkNkFuTk1COTZnTFlqQXFPdFRo?= =?utf-8?B?c2FaaTNlRkpjL2ZkeFVwenZpb1Z3OXFFOGl3aHRsaFQyYzB3d2JYQ2tvb0hC?= =?utf-8?B?WkFVQ2FkSytuWENaaUdGL0crU0V1MEpxVkJZVE1NbnBmQTdCeW9ndWFMWUJa?= =?utf-8?Q?daUkVnQOv3y0MMMRVHNP9EJ14?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39ae0ce4-ccdf-4f40-1e9e-08dc5ee09d2e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 13:16:38.5419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 82JKMsgNulHuHE/1t2+1CM8igmyrxljbdUmgUnjqjthDNwjxhJdkN4wOavpwdeSN X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8440 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/16/2024 4:44 PM, Ferruh Yigit wrote: > On 6/6/2022 3:34 PM, Gaoxiang Liu wrote: >> When the primary port of bond slaves with bond mode 4 linked down, >> the system id of the other slave ports channged. >> It may cause some switches to renegotiate, >> and the process takes a few seconds. It is not acceptable for any >> Telcos. >> We need sub-second switchover time like in linux. >> >> Set the mac of the bond port to the slave port's system to solve the >> problem. >> >> Bugzilla ID: 551 >> Fixes: 46fb43683679 ("bond: add mode 4") >> Cc: stable@dpdk.org >> >> Signed-off-by: Gaoxiang Liu >> >> > > This is another old patch, as far as I can see from bugzilla, the patch > the issue is reported by Kiran and proposed by Nandu, and shared in mail > list by Gaoxiang. > > As it is addressing two bugzilla items, and we are at the beginning of > the release cycle, I am willing to take risk and apply this patch > without ack from a bonding maintainer. > If we found some issues we can revert this back. > > Chas, Connor, if you have any objection, or if you need time for review > please let me know, otherwise I will merge the patch soon. > > And if anyone can provide test, like Kiran who reported the issue, or > any other stakeholder, it helps a lot to give confidence to the fix. > Applied to dpdk-next-net/main, thanks. Please help on verifying the patch.