From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DADF042DCC; Wed, 5 Jul 2023 10:41:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9DC8406BC; Wed, 5 Jul 2023 10:41:53 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 101CF40150 for ; Wed, 5 Jul 2023 10:41:52 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id BA549AC2 for ; Wed, 5 Jul 2023 10:41:51 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id B8BFF8EA; Wed, 5 Jul 2023 10:41:51 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=ALL_TRUSTED, AWL, NICE_REPLY_A, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.6 X-Spam-Score: -1.5 Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 36199D1D; Wed, 5 Jul 2023 10:41:49 +0200 (CEST) Message-ID: <401d9c75-84d1-2b13-527c-395e1e6ab997@lysator.liu.se> Date: Wed, 5 Jul 2023 10:41:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] eventdev: remove single-event enqueue operation Content-Language: en-US To: Jerin Jacob , =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Cc: jerinj@marvell.com, dev@dpdk.org, Pavan Nikhilesh , Timothy McDaniel , Hemant Agrawal , Sachin Saxena , Harry van Haaren , Liang Ma , Peter Mccarthy References: <20230609174205.150027-1-mattias.ronnblom@ericsson.com> <20230704115307.243031-1-mattias.ronnblom@ericsson.com> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023-07-05 09:47, Jerin Jacob wrote: > On Tue, Jul 4, 2023 at 5:29 PM Mattias Rönnblom > wrote: >> >> Eliminate non-burst enqueue operation from Eventdev. >> >> The effect of this change is to reduce Eventdev code complexity >> somewhat and slightly improve performance. >> >> The single-event enqueue shortcut provided a very minor performance >> advantage in some situations (e.g., with a compile time-constant burst >> size of '1'), but would in other situations cause a noticeable >> performance penalty (e.g., rte_event_enqueue_forward_burst() with run >> time-variable burst sizes varying between '1' and larger burst sizes). >> >> Signed-off-by: Mattias Rönnblom >> >> -- >> >> PATCH: Add ABI deprecation notice. > > > Need to split this patch as depreciation notice only will be merged to > this release. > Example: https://patches.dpdk.org/project/dpdk/patch/20230704194445.3332847-1-gakhil@marvell.com/ > > I think, we need to remove the single dequeue as well. So I think, we > can write a generic deprecation notice > which says size of struct rte_event_fp_ops will be changed by removing > single enqueue, dequeue and. > Reservation fields size . Later we can analysis the performance impact > when the implementation patch is ready. > For now, let make deprecation notice for this release. OK, sounds good. The size may be the same, but layout will be different.