From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id D9AE111A2 for ; Tue, 15 Dec 2015 13:16:22 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id p66so87896512wmp.0 for ; Tue, 15 Dec 2015 04:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=dIrTk79HFlQUQq+lTfMv5ECj0JW6NV6DN0iWY80AVrk=; b=Kzw/E0Q/syL4t4iu+1CT7R6GZYev9dZD5XixR7O4yECKAk+f8wRXr5YyS1TQr1hBY+ ySSSDCVNH4GXvh6dHJfZhaIady0+NLgQbBgIL9b9xNKt1vO1fhT5wTJml0dlc7fpFwWI YCWcqjRjTmVJPvVuoXdpdwhSSAuBVCVKaHEjDZXIDeKUApKjxqBaLCVULWunoVR7mFdB 7UnvDF742Nprj3gUqDhbNkVWDqjymmLWXH7YGnHE/Y33uT0JCj2I00u2+9WI/CDEjcUa DTV1j+Qbox8tv6C5p/tG/RnUkReLFS5aFt/UsMgSsyid7I6YH8wZSVeZA1PyUgrJhx/Y UIQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=dIrTk79HFlQUQq+lTfMv5ECj0JW6NV6DN0iWY80AVrk=; b=DD5/ucIjfvJ++dZ03/Av42fGFcWfxv+iXUjxE+bDqAURQHiY/bbeZnCh5zEfL53gN3 23mfeB1KaUpGkLZGzDsOKUhXGIISlKtW1S6eKwf6EGJeaTz+nLljw3HLqE6kE+6+CF9H lKWR9EG7deOAGSdNVH/xPLJfmOAY6QKG64Syr9gd+l6+7k1tqBecWlPL6hqG2SGcG5Xh v1EbKKXxWP5Z9J4iaSKViSu1vFMW3NaoGv7oUTckNt0ph3aUtXl/BPOYIQbZYTdv1DHY Pv+J6AP8dIXgAnPl0AD1wR0BQI35u0QqsrxtzkSXz3Zzjgm+FsWrI6z7rebcWOEIDsff 7VKQ== X-Gm-Message-State: ALoCoQlfW8NqM8jegKpwv8uWyX1n6LD1yW1vKAqWb/JTLN0muPuQICmAc+KmqgigJq6A2Z+zRKCSi+/+hJYvRrecdgqUJ/8jyg== X-Received: by 10.28.183.198 with SMTP id h189mr4174045wmf.44.1450181782681; Tue, 15 Dec 2015 04:16:22 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id e62sm11798758wma.11.2015.12.15.04.16.21 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 15 Dec 2015 04:16:21 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Tue, 15 Dec 2015 13:15:06 +0100 Message-ID: <40293176.xbuDhvPVS6@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <566FFC81.2010601@redhat.com> References: <1450176434-7213-1-git-send-email-thomas.monjalon@6wind.com> <1450176434-7213-2-git-send-email-thomas.monjalon@6wind.com> <566FFC81.2010601@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: remove old flow director symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 12:16:23 -0000 2015-12-15 13:41, Panu Matilainen: > On 12/15/2015 12:47 PM, Thomas Monjalon wrote: > > The API has been removed but the symbols were still declared in the map. > > > > Fixes: a421b86a4a02 ("ethdev: remove old flow director API") > > > > Signed-off-by: Thomas Monjalon > > --- > > lib/librte_ether/rte_ether_version.map | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map > > index 17a11c7..d8db24d 100644 > > --- a/lib/librte_ether/rte_ether_version.map > > +++ b/lib/librte_ether/rte_ether_version.map > > @@ -27,14 +27,6 @@ DPDK_2.2 { > > rte_eth_dev_count; > > rte_eth_dev_default_mac_addr_set; > > rte_eth_dev_detach; > > - rte_eth_dev_fdir_add_perfect_filter; > > - rte_eth_dev_fdir_add_signature_filter; > > - rte_eth_dev_fdir_get_infos; > > - rte_eth_dev_fdir_remove_perfect_filter; > > - rte_eth_dev_fdir_remove_signature_filter; > > - rte_eth_dev_fdir_set_masks; > > - rte_eth_dev_fdir_update_perfect_filter; > > - rte_eth_dev_fdir_update_signature_filter; > > rte_eth_dev_filter_ctrl; > > rte_eth_dev_filter_supported; > > rte_eth_dev_flow_ctrl_get; > > > > Good spotting. What did you use find these and the ones in eal? Just > thinking this seems like something that could and should be automated. Yes, it must be automated. There are also some symbols which are defined in headers and do not need to be in the .map. I'll send more cleanup and the script in the coming days (for 2.3).