From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6ACA6A04DC; Tue, 20 Oct 2020 17:15:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C4F51AD4F; Tue, 20 Oct 2020 17:15:52 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 10CE1A9F3 for ; Tue, 20 Oct 2020 17:15:51 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 51D03437; Tue, 20 Oct 2020 11:15:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 20 Oct 2020 11:15:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= W4rcOIwR2vG31+KLlKwJTsUDZcI9msr7FTJTh2OZt7U=; b=IOB1SvB41uitrVim f0Nk1Zf43vK8AJUvOxu1vwPt6GgWKU3QmnNUBnSkt7TTWLk8eKc1PDV+joxt4vQ+ GTBwOhjrDl8zxwZBAY1bY4Oztpfk2QZ7jty4q/P0PCu6QofBql2iM5rSFp1J6h5Y oZY4mdvJPWGAFOLGr2HdGGxJv1nO4TRowX6ExavaJFY1jCl+ysgZKMsj4f0ZxqLJ 3IDiePI7M/TxycLYJUdv73JnkMAmJUVxNOR8pQNxq+SNkLuQ6UkTTHqsxJ4FpbAt pIIUaG+DB/WxyS3TwJeEMs1Vej3hncdQclEMhiWMXXloHn4+4fHx52mChqnizjJf 43KkPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=W4rcOIwR2vG31+KLlKwJTsUDZcI9msr7FTJTh2OZt 7U=; b=eAQCwbKvanlwtFh15nUdwgNnExp+EYsQvbY9iuB025T9MXq3iWS6PYm4d mHssi5JM8iXFIWQaxVSRxwtWpNyvuC6n3vUR8npKJT4eT2mGlUn8wrV9aQatGFuq dKgbVl8aqAnxSmb3+1MKMT9geVQz/r+VxM2UlAkSPyoLkG9QtEG9T2ncGsdTWDf9 MyE5YzidzujaDQIT2SsJhBH0U4uvjnVegAG+xB7lmd2bntDG7BaxUY7aOK1nmLMx P+mx5vmIqdBEG4cViE8PMEVTt9+Y9JZ9OkWo8PxrWdTgswXz9Zc5BzpnlFIP8TA8 qTgLml4h76gzbmEat4qIYNl+CE8mg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjeefgdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ECC1F306467E; Tue, 20 Oct 2020 11:15:44 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger , bruce.richardson@intel.com, ciara.power@intel.com Cc: dev@dpdk.org Date: Tue, 20 Oct 2020 17:15:42 +0200 Message-ID: <4029344.V9UO92IR4n@thomas> In-Reply-To: <20201020080255.6d5023ab@hermes.local> References: <20200702172852.6201-1-stephen@networkplumber.org> <3266348.IbmaAm1IaQ@thomas> <20201020080255.6d5023ab@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] rte_metrics: move maximum number of metrics into rte_config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/10/2020 17:02, Stephen Hemminger: > Thomas Monjalon wrote: > > 05/09/2020 00:31, Stephen Hemminger: > > > If using lots of queues and ports, and having per port or per queue > > > metrics it is easy to exceed the upper bound of the metric library. > > > Move the limit into rte_config where user can change it. > > > > > > Ideally, there would be no upper bound and a dynamic structure > > > such as red-black tree or hash table would be used for these. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > --- a/config/rte_config.h > > > +++ b/config/rte_config.h > > > +/* rte_metrics defines */ > > > +#define RTE_METRICS_MAX_METRICS 256 > > > > Not sure we want to go in the direction of adding such tuning > > in rte_config.h. > > The only other option is to rewrite rte_metrics to support a > dynamic data structure! Yes it seems a better solution. How rte_metrics will fit in the picture of the new telemetry? Maybe we will deprecate rte_metrics in future?