Re: [PATCH v1 4/9] test/bbdev: change iter-max argument

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 4/22/24 21:07, Hernan Vargas wrote:
> -t --iter-max used for max number of iterations.
> -T --timeout used for test timeout value.
> 
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
>   app/test-bbdev/test-bbdev.py | 16 +++++-----------
>   1 file changed, 5 insertions(+), 11 deletions(-)
> 
> diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py
> index 65a34390548d..9ddca9e78d3b 100755
> --- a/app/test-bbdev/test-bbdev.py
> +++ b/app/test-bbdev/test-bbdev.py
> @@ -27,16 +27,10 @@ def kill(process):
>   parser.add_argument("-e", "--eal-params",
>                       help="EAL arguments which must be passed to the test app",
>                       default="--vdev=baseband_null0 -a00:00.0")
> -# Until deprecated in next release keep -t as an valid argument for timeout, then use -T
> -parser.add_argument("-t", "--timeout",
> +parser.add_argument("-T", "--timeout",
>                       type=int,
>                       help="Timeout in seconds",
>                       default=600)
> -# This will become -t option for iter_max in next release
> -parser.add_argument("--iter-max",
> -                    type=int,
> -                    help="Max iterations",
> -                    default=6)
>   parser.add_argument("-c", "--test-cases",
>                       nargs="+",
>                       help="Defines test cases to run. Run all if not specified")
> @@ -58,6 +52,10 @@ def kill(process):
>                       type=int,
>                       help="SNR in dB for BLER tests",
>                       default=0)
> +parser.add_argument("-t", "--iter-max",
> +                    type=int,
> +                    help="Max iterations",
> +                    default=6)
>   parser.add_argument("-l", "--num-lcores",
>                       type=int,
>                       help="Number of lcores to run.",
> @@ -83,10 +81,6 @@ def kill(process):
>   
>   if args.iter_max:
>       params.extend(["-t", str(args.iter_max)])
> -    print("The argument for iter_max will be -t in next release")
> -
> -if args.timeout:
> -    print("The argument for timeout will be -T in next release")
>   
>   if args.num_ops:
>       params.extend(["-n", str(args.num_ops)])


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime