From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0D26A0562; Tue, 4 May 2021 12:58:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FCEC40147; Tue, 4 May 2021 12:58:20 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id BCB1040141 for ; Tue, 4 May 2021 12:58:19 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3547B5C00F2; Tue, 4 May 2021 06:58:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 04 May 2021 06:58:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= J9Fyw/m/LjqBWg7yO0i4nPIXgc5nVyElkVC+C0CBQx4=; b=2obCifxrmRCnIJYz gpuvbpRAQGBbaAg96BsvIsDrx2jUTfRc5CmpUL0iUNo8TpNqYiiLKImeHTpwS3E5 vy3hgDQ39Drf4XTIS6FpmDg7HwPkdchLuEl67cxYt6La7xkzZGX/mM0GBgZoFA3Z +9b/qYcLnsdoJuRvgW9rfoN1GQaZbKfqTUXL32iBhfF3q2bcMtsWftgPMbASMOx+ w1fi2+Gq72Gg/Zljfn+uD4h02kwJYaikzsxlmA86hC2QPvyyFLrdE15wTkuM+KbC oIgQ8QS9mRte8XpIAahzXYErhKanFceGvreruMZDS1levlIsZv+2aIe0UPCU0ZFQ yUtIgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=J9Fyw/m/LjqBWg7yO0i4nPIXgc5nVyElkVC+C0CBQ x4=; b=iQU6AEyxlLz+Wxm1dzucX/Vbi37h7Yr3lR4LWUscZEhyAUSuxk7b2gzzO /e5DDI16r760c/+fObt67AjLfRsq+sm1ZSAG9fq1XCfC0GS3vSZNxlp8r9wFl45k jWdTsLEEXQ/uuJdSYPOrjZoLRbYJURPSsdYZhDA6cQ590NgnH7tAD8n8BfqXy4VZ +ITT/1FSay24jUYsG1TbwjIwXOwOa8T0hf8/jszacw2H8ZoHsdb+MFcgDK4ut9PM 3gha2tI4pFWLtivx7Llvqc1+QvXeTYO80OPGXJBlowjo7YjHwctVVfxYZvDge2ln wH21fOGoNeKk1o8PbvDI2b92fwt6Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefiedgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 May 2021 06:58:18 -0400 (EDT) From: Thomas Monjalon To: Matan Azrad Cc: dev@dpdk.org, matan@nvidia.com, gakhil@marvell.com, suanmingm@nvidia.com, Dekel Peled Date: Tue, 04 May 2021 12:58:16 +0200 Message-ID: <4051574.U56rfsV2qO@thomas> In-Reply-To: <20210429154335.2820028-16-matan@nvidia.com> References: <20210408204849.9543-1-shirik@nvidia.com> <20210429154335.2820028-1-matan@nvidia.com> <20210429154335.2820028-16-matan@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 15/16] common/mlx5: support register write access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/04/2021 17:43, Matan Azrad: > From: Dekel Peled > > This patch adds support of write operation to NIC registers. > > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad > --- > --- a/drivers/common/mlx5/version.map > +++ b/drivers/common/mlx5/version.map > @@ -13,8 +13,17 @@ INTERNAL { > mlx5_dev_to_pci_addr; # WINDOWS_NO_EXPORT > > mlx5_devx_cmd_alloc_pd; > + mlx5_devx_alloc_uar; Please keep alphabetical order. > + > mlx5_devx_cmd_create_cq; > + mlx5_devx_cmd_create_credential_obj; > + mlx5_devx_cmd_create_crypto_login_obj; > + mlx5_devx_cmd_create_dek_obj; > mlx5_devx_cmd_create_flex_parser; > + mlx5_devx_cmd_create_flow_hit_aso_obj; > + mlx5_devx_cmd_create_flow_meter_aso_obj; > + mlx5_devx_cmd_create_geneve_tlv_option; > + mlx5_devx_cmd_create_import_kek_obj; > mlx5_devx_cmd_create_qp; > mlx5_devx_cmd_create_rq; > mlx5_devx_cmd_create_rqt; > @@ -24,13 +33,6 @@ INTERNAL { > mlx5_devx_cmd_create_tis; > mlx5_devx_cmd_create_virtio_q_counters; # WINDOWS_NO_EXPORT > mlx5_devx_cmd_create_virtq; > - mlx5_devx_cmd_create_flow_hit_aso_obj; > - mlx5_devx_cmd_create_flow_meter_aso_obj; > - mlx5_devx_cmd_create_geneve_tlv_option; > - mlx5_devx_cmd_create_dek_obj; > - mlx5_devx_cmd_create_import_kek_obj; > - mlx5_devx_cmd_create_credential_obj; > - mlx5_devx_cmd_create_crypto_login_obj; Are they changes of previous patches? It seems some cleaning is required in previous patches. > mlx5_devx_cmd_destroy; > mlx5_devx_cmd_flow_counter_alloc; > mlx5_devx_cmd_flow_counter_query; > @@ -51,12 +53,17 @@ INTERNAL { > mlx5_devx_cmd_queue_counter_alloc; # WINDOWS_NO_EXPORT > mlx5_devx_cmd_queue_counter_query; # WINDOWS_NO_EXPORT > mlx5_devx_cmd_register_read; > + mlx5_devx_cmd_register_write; > mlx5_devx_cmd_wq_query; # WINDOWS_NO_EXPORT > mlx5_devx_get_out_command_status; > mlx5_devx_alloc_uar; # WINDOWS_NO_EXPORT > > + > mlx5_devx_cq_create; There is an extra blank line here.