From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5A67A0A0E; Wed, 12 May 2021 16:57:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 529A04003F; Wed, 12 May 2021 16:57:04 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id D56D64003E; Wed, 12 May 2021 16:57:02 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 19E3D580680; Wed, 12 May 2021 10:57:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 12 May 2021 10:57:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= zPMZ1GDVcogbmKTD0t8vqLiUcXOwEiDdsur+Rr02eUA=; b=J4a/M65nIa1l6KjW XcD/G9OLI30zLknDbH/3OfOdRXruvXWeFAtM8qDFgk7OHe4nO9bHQQWv4XRM0pVC lPP2j2txufk3f735cWtV4CuKWZYZ8syiqYsu0+VmEtNhth0Jm5/KgdmP7OKWjCm3 wRj8q/dW05f/nYq6/aqSGx7Ce4sQy8kbcC9Nsr5IoUn7PtmPXurvz0VTiK2hNZyK XaBU+/Y/DNHcZ2wfEzjje+9SfyoYSyfV5dZSdquuHqB2yefxZOpdqk5SSs5X3Rkx vjxCQ6wsABdbcYAO6r01Ch52TSc8TlWsIzmSHivpB53EQ9ucDWT85cx7r4lrkPfR pqia+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=zPMZ1GDVcogbmKTD0t8vqLiUcXOwEiDdsur+Rr02e UA=; b=BmXo5j/1ImSqJtpnn5DxjJ6LMHXbV3TiOyisePrZ8eeQpEjhcojWaEbdB oyPFta7nIUn5b+LO3EzOLRpWjnPp8vktaV7XetL7mW36nbI2Mu7hoPIKE2i95slz 1NfVhaeEGfqNXKQSdcpY557I5UbvGGsupTATxI/9bTm7SkL6bGMRESOGhcJKiua/ dPBRJnnVB0cFCryTKDA8uAJlTIxRlJwFqp0MGTuKBKZldTmtELJw2IcTChxm8TV+ xTgV2ZyqOIryBD0qLMiwtsHQn58JWadB7M9FQ4GLsyzrn8Q+8iLBEInfSOmcIvWX U52urfZCz4TUN5JfxxlRKl/tgCbag== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehvddgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 May 2021 10:57:00 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk , Ranjit Menon Cc: dev@dpdk.org, stable@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Harman Kalra , Harini Ramakrishnan , talshn@nvidia.com, Tyler Retzlaff Date: Wed, 12 May 2021 16:56:59 +0200 Message-ID: <40523071.HP5OjQfDZR@thomas> In-Reply-To: <331c7872-1513-1927-486c-27285a54144d@intel.com> References: <20210502023333.30351-1-dmitry.kozliuk@gmail.com> <20210511105934.104bbca5@sovereign> <331c7872-1513-1927-486c-27285a54144d@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] eal/windows: cleanup interrupt resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/05/2021 19:21, Ranjit Menon: > On 5/11/2021 12:59 AM, Dmitry Kozlyuk wrote: > > 2021-05-11 09:41 (UTC+0200), Thomas Monjalon: > >> 02/05/2021 04:33, Dmitry Kozlyuk: > >>> Interrupt manager in Windows EAL allocates on IOCP and starts > >>> a control thread that runs indefinitely. At DPDK cleanup > >>> this thread was not stopped and IOCP handle was not closed. > >>> > >>> Gracefully stop interrupt-handling in rte_eal_cleanup(). > >>> The thread already closes IOCP handle before exiting. > >>> > >>> Fixes: 5c016fc0205a ("eal/windows: add interrupt thread skeleton") > >>> Cc: stable@dpdk.org > >>> > >>> Signed-off-by: Dmitry Kozlyuk > >>> --- > >>> lib/eal/windows/eal.c | 1 + > >>> lib/eal/windows/eal_interrupts.c | 26 ++++++++++++++++++++++++-- > >>> lib/eal/windows/eal_windows.h | 5 +++++ > >>> 3 files changed, 30 insertions(+), 2 deletions(-) > >> It seems nobody reviewed. > >> To be on the safe side, I'll merge this series after DPDK 21.05 is released. > >> Or am I missing any critical issue? > > IIRC Windows DPDK is not shipped anywhere yet, so the fix can be postponed. > > > > Without fix in 2/3 rte_eal_alarm_set() will start failing after some > > thousands of calls (i40e calls every 50 ms, mlx5 call every 1 sec or less). > > For mlx5 it seems to break flow counters (mlx5_flow_query_alarm function). > > It appears that Tyler reviewed and ack-ed this. I'll add my ACK too. If > we can get this in to 21.05, it would be great. Tyler acked only the patch 1. It would be good to have tests with mlx5 and i40e for the patch 2.