From: Kevin Traynor <ktraynor@redhat.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org, Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx queue setup
Date: Tue, 1 Oct 2019 17:29:26 +0100 [thread overview]
Message-ID: <4057f198-1faa-708e-bf60-075d53b92a97@redhat.com> (raw)
In-Reply-To: <1569944672-24754-1-git-send-email-arybchenko@solarflare.com>
Hi,
On 01/10/2019 16:44, Andrew Rybchenko wrote:
> From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
>
> Deferred start Rx queue is not supported by the driver.
>
> Fixes: 0748be2cf9a2 ("ethdev: queue start and stop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> drivers/net/virtio/virtio_rxtx.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
> index 929aa4cbd..9c8c617f7 100644
> --- a/drivers/net/virtio/virtio_rxtx.c
> +++ b/drivers/net/virtio/virtio_rxtx.c
> @@ -929,6 +929,11 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev,
>
const struct rte_eth_rxconf *rx_conf __rte_unused,
^^^^^^^^^^^^
The unused can be removed now
> PMD_INIT_FUNC_TRACE();
>
> + if (rx_conf->rx_deferred_start) {
> + PMD_INIT_LOG(ERR, "Rx deferred start is not supported");
> + return -EINVAL;
> + }
> +
> if (nb_desc == 0 || nb_desc > vq->vq_nentries)
> nb_desc = vq->vq_nentries;
> vq->vq_free_cnt = RTE_MIN(vq->vq_free_cnt, nb_desc);
>
next prev parent reply other threads:[~2019-10-01 16:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 15:44 Andrew Rybchenko
2019-10-01 15:44 ` [dpdk-dev] [PATCH 2/3] net/virtio: reject deferred start Tx " Andrew Rybchenko
2019-10-08 5:35 ` Tiwei Bie
2019-10-01 15:44 ` [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes Andrew Rybchenko
2019-10-08 5:46 ` Tiwei Bie
2019-10-09 8:04 ` Andrew Rybchenko
2019-10-09 8:43 ` Tiwei Bie
2019-10-09 9:00 ` Andrew Rybchenko
2019-10-09 10:41 ` Tiwei Bie
2019-10-09 11:24 ` Andrew Rybchenko
2019-10-10 7:42 ` Thomas Monjalon
2019-10-10 8:13 ` Andrew Rybchenko
2019-10-10 8:23 ` David Marchand
2019-10-10 8:27 ` Andrew Rybchenko
2019-10-10 9:10 ` Tiwei Bie
2019-10-01 16:29 ` Kevin Traynor [this message]
2019-10-01 16:39 ` [dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx queue setup Andrew Rybchenko
2019-10-09 12:32 ` [dpdk-dev] [PATCH v2 1/4] " Andrew Rybchenko
2019-10-09 12:32 ` [dpdk-dev] [PATCH v2 2/4] net/virtio: reject deferred start Tx " Andrew Rybchenko
2019-10-24 9:44 ` Maxime Coquelin
2019-10-09 12:32 ` [dpdk-dev] [PATCH v2 3/4] net/virtio: reject unsupported Rx multi queue modes Andrew Rybchenko
2019-10-24 9:44 ` Maxime Coquelin
2019-10-09 12:32 ` [dpdk-dev] [PATCH v2 4/4] net/virtio: reject unsupported Tx " Andrew Rybchenko
2019-10-24 9:44 ` Maxime Coquelin
2019-10-24 9:44 ` [dpdk-dev] [PATCH v2 1/4] net/virtio: reject deferred start Rx queue setup Maxime Coquelin
2019-10-24 10:19 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4057f198-1faa-708e-bf60-075d53b92a97@redhat.com \
--to=ktraynor@redhat.com \
--cc=Dilshod.Urazov@oktetlabs.ru \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).